Can't resolve maven-checkstyle-plugin el7 for vdsm-jsonrpc
This patch [1] adds maven-checkstyle plugin for project vdsm-jsonrpc but it keep complaining [2] it can't resolve it . The plugin is the same version, 2.9.1 as ovirt engine uses. The F24 build is passing. What am I missing here? [1] https://gerrit.ovirt.org/67990 [2] http://jenkins.ovirt.org/job/vdsm-jsonrpc-java_master_check-patch-el7-x86_64...
Which maven repository does vdsm-jsonrpc-java is using in its automation scripts? On Sun, Dec 11, 2016 at 1:19 PM, Roy Golan <rgolan@redhat.com> wrote:
This patch [1] adds maven-checkstyle plugin for project vdsm-jsonrpc but it keep complaining [2] it can't resolve it . The plugin is the same version, 2.9.1 as ovirt engine uses. The F24 build is passing. What am I missing here?
[1] https://gerrit.ovirt.org/67990 [2] http://jenkins.ovirt.org/job/vdsm-jsonrpc-java_master_ check-patch-el7-x86_64/100/console
_______________________________________________ Infra mailing list Infra@ovirt.org http://lists.phx.ovirt.org/mailman/listinfo/infra
-- Eyal Edri Associate Manager RHV DevOps EMEA ENG Virtualization R&D Red Hat Israel phone: +972-9-7692018 irc: eedri (on #tlv #rhev-dev #rhev-integ)
On 12/11/2016 12:27 PM, Eyal Edri wrote:
Which maven repository does vdsm-jsonrpc-java is using in its automation scripts?
That project uses "maven-local" to build, and takes the dependencies from the RPM .spec file, not for the POM. So you need to make sure that the package for checkstyle is listed in as a "BuildRequires" in the .spec.in file. As far as I know there is no package containing checkstyle for EL7, at least not in the standard repositories. So this will always fail, unless you explicity remove the checkstyle plugin when building in EL7.
On Sun, Dec 11, 2016 at 1:19 PM, Roy Golan <rgolan@redhat.com <mailto:rgolan@redhat.com>> wrote:
This patch [1] adds maven-checkstyle plugin for project vdsm-jsonrpc but it keep complaining [2] it can't resolve it . The plugin is the same version, 2.9.1 as ovirt engine uses. The F24 build is passing. What am I missing here?
[1] https://gerrit.ovirt.org/67990 [2] http://jenkins.ovirt.org/job/vdsm-jsonrpc-java_master_check-patch-el7-x86_64... <http://jenkins.ovirt.org/job/vdsm-jsonrpc-java_master_check-patch-el7-x86_64/100/console>
_______________________________________________ Infra mailing list Infra@ovirt.org <mailto:Infra@ovirt.org> http://lists.phx.ovirt.org/mailman/listinfo/infra <http://lists.phx.ovirt.org/mailman/listinfo/infra>
-- Eyal Edri Associate Manager RHV DevOps EMEA ENG Virtualization R&D Red Hat Israel
phone: +972-9-7692018 irc: eedri (on #tlv #rhev-dev #rhev-integ)
_______________________________________________ Infra mailing list Infra@ovirt.org http://lists.phx.ovirt.org/mailman/listinfo/infra
On 11 December 2016 at 13:30, Juan Hernández <jhernand@redhat.com> wrote:
On 12/11/2016 12:27 PM, Eyal Edri wrote:
Which maven repository does vdsm-jsonrpc-java is using in its automation scripts?
That project uses "maven-local" to build, and takes the dependencies from the RPM .spec file, not for the POM. So you need to make sure that the package for checkstyle is listed in as a "BuildRequires" in the .spec.in file. As far as I know there is no package containing checkstyle for EL7, at least not in the standard repositories. So this will always fail, unless you explicity remove the checkstyle plugin when building in EL7.
Thanks Juan. Piotr, Juan do you have insights on why the project is structured like that at all and why can't this be simple mvn project and a simple makefile without this voodo?
On Sun, Dec 11, 2016 at 1:19 PM, Roy Golan <rgolan@redhat.com <mailto:rgolan@redhat.com>> wrote:
This patch [1] adds maven-checkstyle plugin for project vdsm-jsonrpc but it keep complaining [2] it can't resolve it . The plugin is the same version, 2.9.1 as ovirt engine uses. The F24 build is passing. What am I missing here?
[1] https://gerrit.ovirt.org/67990 [2] http://jenkins.ovirt.org/job/vdsm-jsonrpc-java_master_ check-patch-el7-x86_64/100/console <http://jenkins.ovirt.org/job/vdsm-jsonrpc-java_master_ check-patch-el7-x86_64/100/console>
_______________________________________________ Infra mailing list Infra@ovirt.org <mailto:Infra@ovirt.org> http://lists.phx.ovirt.org/mailman/listinfo/infra <http://lists.phx.ovirt.org/mailman/listinfo/infra>
-- Eyal Edri Associate Manager RHV DevOps EMEA ENG Virtualization R&D Red Hat Israel
phone: +972-9-7692018 irc: eedri (on #tlv #rhev-dev #rhev-integ)
_______________________________________________ Infra mailing list Infra@ovirt.org http://lists.phx.ovirt.org/mailman/listinfo/infra
On Mon, Dec 12, 2016 at 10:34 AM, Roy Golan <rgolan@redhat.com> wrote:
On 11 December 2016 at 13:30, Juan Hernández <jhernand@redhat.com> wrote:
On 12/11/2016 12:27 PM, Eyal Edri wrote:
Which maven repository does vdsm-jsonrpc-java is using in its automation scripts?
That project uses "maven-local" to build, and takes the dependencies from the RPM .spec file, not for the POM. So you need to make sure that the package for checkstyle is listed in as a "BuildRequires" in the .spec.in file. As far as I know there is no package containing checkstyle for EL7, at least not in the standard repositories. So this will always fail, unless you explicity remove the checkstyle plugin when building in EL7.
Thanks Juan. Piotr, Juan do you have insights on why the project is structured like that at all and why can't this be simple mvn project and a simple makefile without this voodo?
It was suggested by fedora packager as part of work to have it released on fedora repo. This work is still in progress [1] but we are almost there. [1] https://gerrit.ovirt.org/#/c/63673/
On Sun, Dec 11, 2016 at 1:19 PM, Roy Golan <rgolan@redhat.com <mailto:rgolan@redhat.com>> wrote:
This patch [1] adds maven-checkstyle plugin for project vdsm-jsonrpc but it keep complaining [2] it can't resolve it . The plugin is the same version, 2.9.1 as ovirt engine uses. The F24 build is passing. What am I missing here?
[1] https://gerrit.ovirt.org/67990 [2] http://jenkins.ovirt.org/job/vdsm-jsonrpc-java_master_check -patch-el7-x86_64/100/console <http://jenkins.ovirt.org/job/vdsm-jsonrpc-java_master_c heck-patch-el7-x86_64/100/console>
_______________________________________________ Infra mailing list Infra@ovirt.org <mailto:Infra@ovirt.org> http://lists.phx.ovirt.org/mailman/listinfo/infra <http://lists.phx.ovirt.org/mailman/listinfo/infra>
-- Eyal Edri Associate Manager RHV DevOps EMEA ENG Virtualization R&D Red Hat Israel
phone: +972-9-7692018 irc: eedri (on #tlv #rhev-dev #rhev-integ)
_______________________________________________ Infra mailing list Infra@ovirt.org http://lists.phx.ovirt.org/mailman/listinfo/infra
On 12 December 2016 at 11:50, Piotr Kliczewski <pkliczew@redhat.com> wrote:
On Mon, Dec 12, 2016 at 10:34 AM, Roy Golan <rgolan@redhat.com> wrote:
On 11 December 2016 at 13:30, Juan Hernández <jhernand@redhat.com> wrote:
On 12/11/2016 12:27 PM, Eyal Edri wrote:
Which maven repository does vdsm-jsonrpc-java is using in its automation scripts?
That project uses "maven-local" to build, and takes the dependencies from the RPM .spec file, not for the POM. So you need to make sure that the package for checkstyle is listed in as a "BuildRequires" in the .spec.in file. As far as I know there is no package containing checkstyle for EL7, at least not in the standard repositories. So this will always fail, unless you explicity remove the checkstyle plugin when building in EL7.
Thanks Juan. Piotr, Juan do you have insights on why the project is structured like that at all and why can't this be simple mvn project and a simple makefile without this voodo?
It was suggested by fedora packager as part of work to have it released on fedora repo. This work is still in progress [1] but we are almost there.
And why do we have to have the pom.xml.in? just to template the name? can we get rid of it please? [1] https://gerrit.ovirt.org/#/c/63673/
On Sun, Dec 11, 2016 at 1:19 PM, Roy Golan <rgolan@redhat.com <mailto:rgolan@redhat.com>> wrote:
This patch [1] adds maven-checkstyle plugin for project vdsm-jsonrpc but it keep complaining [2] it can't resolve it . The plugin is the same version, 2.9.1 as ovirt engine uses. The F24 build is passing. What am I missing here?
[1] https://gerrit.ovirt.org/67990 [2] http://jenkins.ovirt.org/job/vdsm-jsonrpc-java_master_check -patch-el7-x86_64/100/console <http://jenkins.ovirt.org/job/vdsm-jsonrpc-java_master_chec k-patch-el7-x86_64/100/console>
_______________________________________________ Infra mailing list Infra@ovirt.org <mailto:Infra@ovirt.org> http://lists.phx.ovirt.org/mailman/listinfo/infra <http://lists.phx.ovirt.org/mailman/listinfo/infra>
-- Eyal Edri Associate Manager RHV DevOps EMEA ENG Virtualization R&D Red Hat Israel
phone: +972-9-7692018 irc: eedri (on #tlv #rhev-dev #rhev-integ)
_______________________________________________ Infra mailing list Infra@ovirt.org http://lists.phx.ovirt.org/mailman/listinfo/infra
On Mon, Dec 12, 2016 at 10:53 AM, Roy Golan <rgolan@redhat.com> wrote:
On 12 December 2016 at 11:50, Piotr Kliczewski <pkliczew@redhat.com> wrote:
On Mon, Dec 12, 2016 at 10:34 AM, Roy Golan <rgolan@redhat.com> wrote:
On 11 December 2016 at 13:30, Juan Hernández <jhernand@redhat.com> wrote:
On 12/11/2016 12:27 PM, Eyal Edri wrote:
Which maven repository does vdsm-jsonrpc-java is using in its automation scripts?
That project uses "maven-local" to build, and takes the dependencies from the RPM .spec file, not for the POM. So you need to make sure that the package for checkstyle is listed in as a "BuildRequires" in the .spec.in file. As far as I know there is no package containing checkstyle for EL7, at least not in the standard repositories. So this will always fail, unless you explicity remove the checkstyle plugin when building in EL7.
Thanks Juan. Piotr, Juan do you have insights on why the project is structured like that at all and why can't this be simple mvn project and a simple makefile without this voodo?
It was suggested by fedora packager as part of work to have it released on fedora repo. This work is still in progress [1] but we are almost there.
And why do we have to have the pom.xml.in? just to template the name? can we get rid of it please?
What would be the reason to get rid of it? Thanks to this approach we change version only in configure.ac file and without it we would need to change it in few places like we do in the engine.
[1] https://gerrit.ovirt.org/#/c/63673/
On Sun, Dec 11, 2016 at 1:19 PM, Roy Golan <rgolan@redhat.com <mailto:rgolan@redhat.com>> wrote:
This patch [1] adds maven-checkstyle plugin for project vdsm-jsonrpc but it keep complaining [2] it can't resolve it . The plugin is the same version, 2.9.1 as ovirt engine uses. The F24 build is passing. What am I missing here?
[1] https://gerrit.ovirt.org/67990 [2] http://jenkins.ovirt.org/job/vdsm-jsonrpc-java_master_check -patch-el7-x86_64/100/console <http://jenkins.ovirt.org/job/vdsm-jsonrpc-java_master_chec k-patch-el7-x86_64/100/console>
_______________________________________________ Infra mailing list Infra@ovirt.org <mailto:Infra@ovirt.org> http://lists.phx.ovirt.org/mailman/listinfo/infra <http://lists.phx.ovirt.org/mailman/listinfo/infra>
-- Eyal Edri Associate Manager RHV DevOps EMEA ENG Virtualization R&D Red Hat Israel
phone: +972-9-7692018 irc: eedri (on #tlv #rhev-dev #rhev-integ)
_______________________________________________ Infra mailing list Infra@ovirt.org http://lists.phx.ovirt.org/mailman/listinfo/infra
participants (4)
-
Eyal Edri -
Juan Hernández -
Piotr Kliczewski -
Roy Golan