Adding managers as no reply was received and I am not sure if anyone is looking into this. On Thu, Feb 7, 2019 at 9:46 AM Dafna Ron <dron(a)redhat.com&gt; wrote: > Hi, > > We have a failure on ovirt-engine for test > 002_bootstrap.add_direct_lun_vm0 in basic suite. > > CQ is reporting this patch as the first one failed (i.e root cause): > > https://gerrit.ovirt.org/#/c/96490/ - engine: Display all errors at once > when upgrading cluster compitability level > > But I am also seeing that this patch was merged around the same time and > my be the cause > > https://gerrit.ovirt.org/#/c/97604/ - core: call hotplug after a new > disk is added to a VM > > Can you please have a look at the issue? > > Error: > <> > 2019-02-06 23:34:31,586-05 WARN > [org.ovirt.engine.core.bll.storage.disk.AddDiskCommand] (default task-1) > [f36d809b-4bba-4926-b997-443f70f0d7a0] Validation of action 'AddDisk' > failed for user admin@internal-auth > z. Reasons: > VAR__ACTION__ADD,VAR__TYPE__DISK,ACTION_TYPE_FAILED_DISK_SIZE_ZERO >

> [org.ovirt.engine.core.bll.storage.disk.AddDiskCommand] (default task-1) > [f36d809b-4bba-4926-b997-443f70f0d7a0] Lock freed to object > 'EngineLock:{exclusiveLocks='', sharedLocks=' > [462445ca-9622-4aa9-88aa-dedea6ebbea8=VM]'}' > 2019-02-06 23:34:31,593-05 DEBUG > [org.ovirt.engine.core.common.di.interceptor.DebugLoggingInterceptor] > (default task-1) [f36d809b-4bba-4926-b997-443f70f0d7a0] method: runAction, > params: [AddDisk, AddDiskParamete > rs:{commandId='3a9584cb-b896-488e-a858-d9c97b1e2a27', user='null', > commandType='Unknown', vmId='462445ca-9622-4aa9-88aa-dedea6ebbea8'}], > timeElapsed: 180ms > 2019-02-06 23:34:31,597-05 ERROR > [org.ovirt.engine.api.restapi.resource.AbstractBackendResource] (default > task-1) [] Operation Failed: [Cannot add Virtual Disk. Disk's provisioned > size has to be greater than 0.] > 2019-02-06 23:34:31,608-05 DEBUG > [org.ovirt.engine.core.aaa.filters.SsoRestApiAuthFilter] (default task-1) > [] Entered SsoRestApiAuthFilter > <> > > Thanks, > Dafna > >

On Thu, Feb 7, 2019 at 3:14 PM Martin Perina <mperina(a)redhat.com&gt; wrote: > > > On Thu, Feb 7, 2019 at 2:10 PM Dafna Ron <dron(a)redhat.com&gt; wrote: > >> Adding managers as no reply was received and I am not sure if anyone is >> looking into this. >> >> >> >> On Thu, Feb 7, 2019 at 9:46 AM Dafna Ron <dron(a)redhat.com&gt; wrote: >> >>> Hi, >>> >>> We have a failure on ovirt-engine for test >>> 002_bootstrap.add_direct_lun_vm0 in basic suite. >>> >>> CQ is reporting this patch as the first one failed (i.e root cause): >>> >>> https://gerrit.ovirt.org/#/c/96490/ - engine: Display all errors at >>> once when upgrading cluster compitability level >>> >>> But I am also seeing that this patch was merged around the same time >>> and my be the cause >>> >>> https://gerrit.ovirt.org/#/c/97604/ - core: call hotplug after a new >>> disk is added to a VM >>> >>> Can you please have a look at the issue? >>> >> Issue fixed and will be merged as soon as OST passes > >>> Error: >>> <> >>> 2019-02-06 23:34:31,586-05 WARN >>> [org.ovirt.engine.core.bll.storage.disk.AddDiskCommand] (default task-1) >>> [f36d809b-4bba-4926-b997-443f70f0d7a0] Validation of action 'AddDisk' >>> failed for user admin@internal-auth >>> z. Reasons: >>> VAR__ACTION__ADD,VAR__TYPE__DISK,ACTION_TYPE_FAILED_DISK_SIZE_ZERO >>> >> > Above error is raised in AddDiskCommand, so I think the issue is probably > related to https://gerrit.ovirt.org/#/c/97604/ > Benny/Fred could you please take a look? > > 2019-02-06 23:34:31,587-05 INFO >>> [org.ovirt.engine.core.bll.storage.disk.AddDiskCommand] (default task-1) >>> [f36d809b-4bba-4926-b997-443f70f0d7a0] Lock freed to object >>> 'EngineLock:{exclusiveLocks='', sharedLocks=' >>> [462445ca-9622-4aa9-88aa-dedea6ebbea8=VM]'}' >>> 2019-02-06 23:34:31,593-05 DEBUG >>> [org.ovirt.engine.core.common.di.interceptor.DebugLoggingInterceptor] >>> (default task-1) [f36d809b-4bba-4926-b997-443f70f0d7a0] method: runAction, >>> params: [AddDisk, AddDiskParamete >>> rs:{commandId='3a9584cb-b896-488e-a858-d9c97b1e2a27', user='null', >>> commandType='Unknown', vmId='462445ca-9622-4aa9-88aa-dedea6ebbea8'}], >>> timeElapsed: 180ms >>> 2019-02-06 23:34:31,597-05 ERROR >>> [org.ovirt.engine.api.restapi.resource.AbstractBackendResource] (default >>> task-1) [] Operation Failed: [Cannot add Virtual Disk. Disk's provisioned >>> size has to be greater than 0.] >>> 2019-02-06 23:34:31,608-05 DEBUG >>> [org.ovirt.engine.core.aaa.filters.SsoRestApiAuthFilter] (default task-1) >>> [] Entered SsoRestApiAuthFilter >>> <> >>> >>> Thanks, >>> Dafna >>> >>> > > -- > Martin Perina > Associate Manager, Software Engineering > Red Hat Czech s.r.o. >

Sorry for not replying earlier, this mail skipped my inbox (probably because it's sent to infra list, can we have this sent to devel list too?)

Anyway this patch: https://gerrit.ovirt.org/#/c/97604/ is not related since it isn't merged yet, and I'm not sure how it appeared in CQ The actual culprit is this patch: https://gerrit.ovirt.org/#/c/97075/ - this was merged two days ago, but it seems there was another issue with OST that masked it And this is the fix: https://gerrit.ovirt.org/#/c/97622/ (passed OST and merged)

On Thu, Feb 7, 2019 at 3:33 PM Dafna Ron <dron(a)redhat.com&gt; wrote: > Thanks Tal, > Can you please put the fix here so I can follow? > Thanks, > Dafna > > > On Thu, Feb 7, 2019 at 1:24 PM Tal Nisan <tnisan(a)redhat.com&gt; wrote: > >> >> >> On Thu, Feb 7, 2019 at 3:14 PM Martin Perina <mperina(a)redhat.com&gt; wrote: >> >>> >>> >>> On Thu, Feb 7, 2019 at 2:10 PM Dafna Ron <dron(a)redhat.com&gt; wrote: >>> >>>> Adding managers as no reply was received and I am not sure if anyone >>>> is looking into this. >>>> >>>> >>>> >>>> On Thu, Feb 7, 2019 at 9:46 AM Dafna Ron <dron(a)redhat.com&gt; wrote: >>>> >>>>> Hi, >>>>> >>>>> We have a failure on ovirt-engine for test >>>>> 002_bootstrap.add_direct_lun_vm0 in basic suite. >>>>> >>>>> CQ is reporting this patch as the first one failed (i.e root cause): >>>>> >>>>> https://gerrit.ovirt.org/#/c/96490/ - engine: Display all errors at >>>>> once when upgrading cluster compitability level >>>>> >>>>> But I am also seeing that this patch was merged around the same time >>>>> and my be the cause >>>>> >>>>> https://gerrit.ovirt.org/#/c/97604/ - core: call hotplug after a new >>>>> disk is added to a VM >>>>> >>>>> Can you please have a look at the issue? >>>>> >>>> Issue fixed and will be merged as soon as OST passes >> >>> >>>>> Error: >>>>> <> >>>>> 2019-02-06 23:34:31,586-05 WARN >>>>> [org.ovirt.engine.core.bll.storage.disk.AddDiskCommand] (default task-1) >>>>> [f36d809b-4bba-4926-b997-443f70f0d7a0] Validation of action 'AddDisk' >>>>> failed for user admin@internal-auth >>>>> z. Reasons: >>>>> VAR__ACTION__ADD,VAR__TYPE__DISK,ACTION_TYPE_FAILED_DISK_SIZE_ZERO >>>>> >>>> >>> Above error is raised in AddDiskCommand, so I think the issue is >>> probably related to https://gerrit.ovirt.org/#/c/97604/ >>> Benny/Fred could you please take a look? >>> >>> 2019-02-06 23:34:31,587-05 INFO >>>>> [org.ovirt.engine.core.bll.storage.disk.AddDiskCommand] (default task-1) >>>>> [f36d809b-4bba-4926-b997-443f70f0d7a0] Lock freed to object >>>>> 'EngineLock:{exclusiveLocks='', sharedLocks=' >>>>> [462445ca-9622-4aa9-88aa-dedea6ebbea8=VM]'}' >>>>> 2019-02-06 23:34:31,593-05 DEBUG >>>>> [org.ovirt.engine.core.common.di.interceptor.DebugLoggingInterceptor] >>>>> (default task-1) [f36d809b-4bba-4926-b997-443f70f0d7a0] method: runAction, >>>>> params: [AddDisk, AddDiskParamete >>>>> rs:{commandId='3a9584cb-b896-488e-a858-d9c97b1e2a27', user='null', >>>>> commandType='Unknown', vmId='462445ca-9622-4aa9-88aa-dedea6ebbea8'}], >>>>> timeElapsed: 180ms >>>>> 2019-02-06 23:34:31,597-05 ERROR >>>>> [org.ovirt.engine.api.restapi.resource.AbstractBackendResource] (default >>>>> task-1) [] Operation Failed: [Cannot add Virtual Disk. Disk's provisioned >>>>> size has to be greater than 0.] >>>>> 2019-02-06 23:34:31,608-05 DEBUG >>>>> [org.ovirt.engine.core.aaa.filters.SsoRestApiAuthFilter] (default task-1) >>>>> [] Entered SsoRestApiAuthFilter >>>>> <> >>>>> >>>>> Thanks, >>>>> Dafna >>>>> >>>>> >>> >>> -- >>> Martin Perina >>> Associate Manager, Software Engineering >>> Red Hat Czech s.r.o. >>> >>