[ https://ovirt-jira.atlassian.net/browse/OVIRT-1759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=36520#comment-36520 ] Barak Korren commented on OVIRT-1759: ------------------------------------- [~eedri] this is not a new ticket - and the cost of fixing this properly is high, so it really depends on how likely is this to happen in practice. In the meantime we can try to invest some time in reporting the issue to the upstreams. We need to: 1. Setup a job that runs on gerrit merge events with no parallel processing but finishes quickly. 2. Submit a chain of patches 3. See if/when the job processes patchs out-of-order 4. Check if the events reach us out of order from Gerrit - in that case a issue needs to be reported to Gerrit 5. Check if events reaches in-order from Gerrti but the job was scheduled out-of-order - in this case issue needs to be reported on the Gerrit plugin.

Gerrit patches can reach CQ out-of-order ----------------------------------------

Key: OVIRT-1759 URL: https://ovirt-jira.atlassian.net/browse/OVIRT-1759 Project: oVirt - virtualization made easy Issue Type: Bug Components: Change Queue, Gerrit/git Reporter: Barak Korren Assignee: infra Priority: High Labels: change-queue, gerrit

Is seems that despite the fact that all the jobs involved were designed to preserve proper patch ordering, there can be cases where patches trigger Jenkins jobs in the wrong order, which in turn end up putting the patches in the wrong order into the CQ. This in turn, causes the CQ to fail accurately detecting the patches that cause issues. Here is en example of such an occurance. The following patches were merged in the order specified below: # https://gerrit.ovirt.org/c/83917 # https://gerrit.ovirt.org/c/83918 # https://gerrit.ovirt.org/c/83919 # https://gerrit.ovirt.org/c/83920 The standard-enqueue runs putting them in the CQ however, seem to have run in a different order: # http://jenkins.ovirt.org/job/standard-enqueue/6712/ (83917) # http://jenkins.ovirt.org/job/standard-enqueue/6713/ (83919) # http://jenkins.ovirt.org/job/standard-enqueue/6714/ (83920) # http://jenkins.ovirt.org/job/standard-enqueue/6715/ (83918) This resulted in CQ 'add' command running in the wrong order: # http://jenkins.ovirt.org/job/ovirt-master_change-queue/12200/ (add 83917) # http://jenkins.ovirt.org/job/ovirt-master_change-queue/12201/ (add 83919) # http://jenkins.ovirt.org/job/ovirt-master_change-queue/12202/ (add 83920) # http://jenkins.ovirt.org/job/ovirt-master_change-queue/12203/ (add 83918) We need to come up with a way to make the system properly preserver order.

-- This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100083)