[JIRA] (OVIRT-1895) CI votes not forwarded on commit message change

13 Feb 2018


      This is a multi-part message in MIME format...

------------=_1518516975-15615-100
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit


    [ https://ovirt-jira.atlassian.net/browse/OVIRT-1895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=35821#comment-35821 ] 

Daniel Belenky commented on OVIRT-1895:
---------------------------------------

It's a known bug that's coming from the Gerrit Trigger Plugin,  the current solution is not to push commit message changes if you have CI tests running.
...
CI votes not forwarded on commit message change
-----------------------------------------------
Key: OVIRT-1895
                URL: https://ovirt-jira.atlassian.net/browse/OVIRT-1895
            Project: oVirt - virtualization made easy
         Issue Type: By-EMAIL
           Reporter: Yedidyah Bar David
           Assignee: infra
Hi all,
If a change goes through this flow:
1. Push an update N
2. CI triggers check-patch for N
3. Push another update N+1 that changes only commit message
4. CI marks +1 N
Then we have logic to not trigger CI for N+1 (with the assumption that
a change to commit message should not affect the result), but also do
not mark +1 N+1, leaving the patch unmarked.
We should either forward the +1, when giving it, to all consecutive
future patchsets that only changed the commit message, or give up on
the optimization and always trigger CI.
As an example, see:
https://gerrit.ovirt.org/87515
Best regards,
-- 
Didi
--
This message was sent by Atlassian Jira
(v1001.0.0-SNAPSHOT#100079)

------------=_1518516975-15615-100
Content-Type: text/html; charset="UTF-8"
Content-Disposition: inline
Content-Transfer-Encoding: 7bit

<html><body>
<pre>[ https://ovirt-jira.atlassian.net/browse/OVIRT-1895?page=com.atlassian.jira.p... ]</pre>
<h3>Daniel Belenky commented on OVIRT-1895:</h3>
<p>It's a known bug that's coming from the Gerrit Trigger Plugin,  the current solution is not to push commit message changes if you have CI tests running.</p>
<blockquote><h3>CI votes not forwarded on commit message change</h3>
<pre>     Key: OVIRT-1895
     URL: https://ovirt-jira.atlassian.net/browse/OVIRT-1895
 Project: oVirt - virtualization made easy
         Issue Type: By-EMAIL
Reporter: Yedidyah Bar David
Assignee: infra</pre>
<p>Hi all, If a change goes through this flow:</p>
<ol><li><p>Push an update N</p></li>
<li><p>CI triggers check-patch for N</p></li>
<li><p>Push another update N+1 that changes only commit message</p></li>
<li><p>CI marks +1 N</p></li></ol>
<p>Then we have logic to not trigger CI for N+1 (with the assumption that a change to commit message should not affect the result), but also do not mark +1 N+1, leaving the patch unmarked. We should either forward the +1, when giving it, to all consecutive future patchsets that only changed the commit message, or give up on the optimization and always trigger CI. As an example, see: <a href="https://gerrit.ovirt.org/87515">https://gerrit.ovirt.org/87515</a> Best regards, — Didi</p></blockquote>
<p>— This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100079)</p>

<img src="https://u4043402.ct.sendgrid.net/wf/open?upn=i5TMWGV99amJbNxJpSp2-2BJ33BSM3t..." alt="" width="1" height="1" border="0" style="height:1px !important;width:1px !important;border-width:0 !important;margin-top:0 !important;margin-bottom:0 !important;margin-right:0 !important;margin-left:0 !important;padding-top:0 !important;padding-bottom:0 !important;padding-right:0 !important;padding-left:0 !important;"/>
</body></html>

------------=_1518516975-15615-100--

Daniel Belenky (oVirt JIRA)

tags

participants (1)