Forwarding to Jira. ---------- Forwarded message ---------- From: Yedidyah Bar David <didi@redhat.com> Date: 16 February 2017 at 15:02 Subject: build-artifacts-on-demand marks CI +1 To: infra <infra@ovirt.org> Hi all, I have a change [1] that currently fails some jenkins jobs, so it gets -1 from it. After pushing patchset 4 (a mere rebase actually), I ran build-artifacts-on-demand ("ci please build"), and it passed, and set CI +1. Then I rebased again and again got -1 as expected. IMO build-artifacts-on-demand should not set CI +1, it might be misleading for the maintainer to think that all is good when in fact CI failed. [1] https://gerrit.ovirt.org/71590 -- Didi _______________________________________________ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra -- Barak Korren bkorren@redhat.com RHCE, RHCi, RHV-DevOps Team https://ifireball.wordpress.com/