Re: [ovirt-devel] vdsm from 3.5 branch is currently failing to build on Fedora
On Jul 31, 2015, at 08:08 , Sandro Bonazzola <sbonazzo@redhat.com> wrote:
Hi, vdsm from 3.5 branch is currently failing to build on Fedora, failing pep8. Please fix ASAP.
Fedora 20: http://jenkins.ovirt.org/view/Stable%20branches%20per%20project/view/vdsm/jo... Fedora 21: http://jenkins.ovirt.org/view/Stable%20branches%20per%20project/view/vdsm/jo...
looks like [1] merged 3 weeks ago hm..running CI on merged patches doesn't alert on failure? Thanks, michal [1] https://gerrit.ovirt.org/#/c/43276/
-- Sandro Bonazzola Better technology. Faster innovation. Powered by community collaboration. See how it works at redhat.com _______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
On Fri, Jul 31, 2015 at 9:06 AM, Michal Skrivanek < michal.skrivanek@redhat.com> wrote:
On Jul 31, 2015, at 08:08 , Sandro Bonazzola <sbonazzo@redhat.com> wrote:
Hi, vdsm from 3.5 branch is currently failing to build on Fedora, failing pep8. Please fix ASAP.
Fedora 20: http://jenkins.ovirt.org/view/Stable%20branches%20per%20project/view/vdsm/jo... Fedora 21: http://jenkins.ovirt.org/view/Stable%20branches%20per%20project/view/vdsm/jo...
looks like [1] merged 3 weeks ago
hm..running CI on merged patches doesn't alert on failure?
Looks like no email is triggered on failure since jenkins already comment on gerrit and gerrit send an email to all people reviewing the patch. So all of them have been warned that the patch was failing on merge. I think vdsm is also missing a pep8 / pyflakes validation on patch sent, it would help avoiding to discover the issue after having merged the patch.
Thanks, michal
[1] https://gerrit.ovirt.org/#/c/43276/
-- Sandro Bonazzola Better technology. Faster innovation. Powered by community collaboration. See how it works at redhat.com _______________________________________________ Devel mailing list Devel@ovirt.org http://lists.ovirt.org/mailman/listinfo/devel
-- Sandro Bonazzola Better technology. Faster innovation. Powered by community collaboration. See how it works at redhat.com
On Fri, Jul 31, 2015 at 09:13:45AM +0200, Sandro Bonazzola wrote:
On Fri, Jul 31, 2015 at 9:06 AM, Michal Skrivanek < michal.skrivanek@redhat.com> wrote:
On Jul 31, 2015, at 08:08 , Sandro Bonazzola <sbonazzo@redhat.com> wrote:
Hi, vdsm from 3.5 branch is currently failing to build on Fedora, failing pep8. Please fix ASAP.
Fedora 20: http://jenkins.ovirt.org/view/Stable%20branches%20per%20project/view/vdsm/jo... Fedora 21: http://jenkins.ovirt.org/view/Stable%20branches%20per%20project/view/vdsm/jo...
looks like [1] merged 3 weeks ago
hm..running CI on merged patches doesn't alert on failure?
Looks like no email is triggered on failure since jenkins already comment on gerrit and gerrit send an email to all people reviewing the patch. So all of them have been warned that the patch was failing on merge.
I think vdsm is also missing a pep8 / pyflakes validation on patch sent, it would help avoiding to discover the issue after having merged the patch.
We have pep8 job like that on master, but apparently - not on ovirt-3.5. Anyway, I have just posted https://gerrit.ovirt.org/#/c/44239/ to unbreak the long line of [1] and other damage done for stock el7 pep8. I'll merge it asap.
On Fri, Jul 31, 2015 at 1:53 PM, Dan Kenigsberg <danken@redhat.com> wrote:
On Fri, Jul 31, 2015 at 09:13:45AM +0200, Sandro Bonazzola wrote:
On Fri, Jul 31, 2015 at 9:06 AM, Michal Skrivanek < michal.skrivanek@redhat.com> wrote:
On Jul 31, 2015, at 08:08 , Sandro Bonazzola <sbonazzo@redhat.com>
wrote:
Hi, vdsm from 3.5 branch is currently failing to build on Fedora, failing pep8. Please fix ASAP.
Fedora 20:
http://jenkins.ovirt.org/view/Stable%20branches%20per%20project/view/vdsm/jo...
Fedora 21:
http://jenkins.ovirt.org/view/Stable%20branches%20per%20project/view/vdsm/jo...
looks like [1] merged 3 weeks ago
hm..running CI on merged patches doesn't alert on failure?
Looks like no email is triggered on failure since jenkins already comment on gerrit and gerrit send an email to all people reviewing the patch. So all of them have been warned that the patch was failing on merge.
I think vdsm is also missing a pep8 / pyflakes validation on patch sent, it would help avoiding to discover the issue after having merged the patch.
We have pep8 job like that on master, but apparently - not on ovirt-3.5.
Anyway, I have just posted https://gerrit.ovirt.org/#/c/44239/ to unbreak the long line of [1] and other damage done for stock el7 pep8.
I'll merge it asap.
Looks like jenkins is not happy yet. http://jenkins.ovirt.org/job/vdsm_3.5_create-rpms-fc21-x86_64_merged/118/art... -- Sandro Bonazzola Better technology. Faster innovation. Powered by community collaboration. See how it works at redhat.com
participants (3)
-
Dan Kenigsberg -
Michal Skrivanek -
Sandro Bonazzola