Have a nice evening,
Roman
On Fri, Sep 4, 2015 at 11:40 AM, Sandro Bonazzola <sbonazzo(a)redhat.com>
wrote:
>
>
> On Fri, Sep 4, 2015 at 11:28 AM, Roman Mohr <rmohr(a)redhat.com> wrote:
>
>> On Wed, Sep 2, 2015 at 5:21 PM, Sandro Bonazzola <sbonazzo(a)redhat.com>
>> wrote:
>>
>>>
>>>
>>> On Wed, Sep 2, 2015 at 4:07 PM, Alon Bar-Lev <alonbl(a)redhat.com>
wrote:
>>>
>>>>
>>>> We soon need to build entire product using xmvn, this includes tests.
>>>> So these argument is incorrect.
>>>> We should have no dependencies (especially new ones) that fedora does
>>>> not provide.
>>>> Sandro, please enforce.
>>>>
>>>>
>>> Not that I have super powers for enforcing that, but yes I toatlly
>>> agree with Alon.
>>> If we can't really live without such dependency, please package it for
>>> Fedora first.
>>> We want to be able to adhere to fedora guidelines now that we can drop
>>> el6 / mead build.
>>>
>>
>> Well of course we can live without that dependency but it will greatly
>> improve the way of writing meaningful assertions (having hamcrest is better
>> than not having it but it is a pain to use and read its assertions).
>> And more easy test-writing means more happy test-writing developers.
>>
>> Here are the packages:
>>
https://bugzilla.redhat.com/show_bug.cgi?id=1259852
>>
https://bugzilla.redhat.com/show_bug.cgi?id=1259851
>>
>>
> Requested Fedora Java SIG to review.
>
>
>
>> The second package is just a test dependency so that I can run the
>> assertj unit tests when building the package.
>>
>> Some of you are package maintainers so I would be delighted if someone
>> wants to review them (they are easy reviews).
>> Otherwise I am sure I will find someone on the fedora mailing list for
>> some review exchange.
>>
>>
>>
>>>
>>>
>>
>>>
>>>> ----- Original Message -----
>>>> > From: "Roy Golan" <rgolan(a)redhat.com>
>>>> > To: "Alon Bar-Lev" <alonbl(a)redhat.com>
>>>> > Cc: "Eyal Edri" <eedri(a)redhat.com>, "Roman
Mohr" <rmohr(a)redhat.com>,
>>>> "infra" <infra(a)ovirt.org>
>>>> > Sent: Wednesday, September 2, 2015 5:04:54 PM
>>>> > Subject: Re: Add AssertJ to artifactory
>>>> >
>>>> > its a test depency, its not needed for packaging
>>>> >
>>>> > On Wed, Sep 2, 2015 at 4:56 PM, Alon Bar-Lev
<alonbl(a)redhat.com>
>>>> wrote:
>>>> >
>>>> > > needless to say that this assertj is not available in fedora
and
>>>> if not
>>>> > > actually required for production use and actual important use
case
>>>> should
>>>> > > not be added as dependency to our project.
>>>> > >
>>>> > > ----- Original Message -----
>>>> > > > From: "Roy Golan" <rgolan(a)redhat.com>
>>>> > > > To: "Eyal Edri" <eedri(a)redhat.com>
>>>> > > > Cc: "Roman Mohr" <rmohr(a)redhat.com>,
"infra" <infra(a)ovirt.org>
>>>> > > > Sent: Wednesday, September 2, 2015 4:52:20 PM
>>>> > > > Subject: Re: Add AssertJ to artifactory
>>>> > > >
>>>> > > > Thanks, its there.
>>>> > > >
>>>> > > > On Wed, Sep 2, 2015 at 3:40 PM, Eyal Edri <
eedri(a)redhat.com >
>>>> wrote:
>>>> > > >
>>>> > > >
>>>> > > >
>>>> > > > you're looking at the wrong artifactory.
>>>> > > > our mirror in in
>>>>
http://artifactory.ovirt.org/artifactory/ovirt-mirror .
>>>> > > >
>>>> > > > e.
>>>> > > >
>>>> > > > On Wed, Sep 2, 2015 at 1:42 PM, Roy Golan <
rgolan(a)redhat.com >
>>>> wrote:
>>>> > > >
>>>> > > >
>>>> > > >
>>>> > > > I would expect the artifactory to find it on a search
query but
>>>> it didn't
>>>> > > >
>>>> > >
>>>>
http://artifactory.eng.lab.tlv.redhat.com:8081/artifactory/webapp/search/...
>>>> > > >
>>>> > > > On Wed, Sep 2, 2015 at 1:37 PM, Eyal Edri <
eedri(a)redhat.com >
>>>> wrote:
>>>> > > >
>>>> > > >
>>>> > > >
>>>> > > > adding infra.
>>>> > > > any reason why this isn't on maven central?
>>>> > > >
>>>> > > > e.
>>>> > > >
>>>> > > > On Wed, Sep 2, 2015 at 12:35 PM, Roy Golan <
rgolan(a)redhat.com
>>>> > wrote:
>>>> > > >
>>>> > > >
>>>> > > >
>>>> > > > We want to add a test jar dependency to the project and
want to
>>>> make sure
>>>> > > > artifactory has that.
>>>> > > >
>>>> > > > Can you add this?
>>>> > > >
>>>> > > >
http://mvnrepository.com/artifact/org.assertj/assertj-core/2.1.0
>>>> > > >
>>>> > > >
>>>> > > > <dependency>
>>>> > > > <groupId>org.assertj</groupId>
>>>> > > > <artifactId>assertj-core</artifactId>
>>>> > > > <version>2.1.0</version>
>>>> > > > </dependency>
>>>> > > >
>>>> > > >
>>>> > > > Thanks
>>>> > > >
>>>> > > >
>>>> > > >
>>>> > > > --
>>>> > > > Eyal Edri
>>>> > > > Supervisor, RHEV CI
>>>> > > > EMEA ENG Virtualization R&D
>>>> > > > Red Hat Israel
>>>> > > >
>>>> > > > phone: +972-9-7692018
>>>> > > > irc: eedri (on #tlv #rhev-dev #rhev-integ)
>>>> > > >
>>>> > > >
>>>> > > >
>>>> > > >
>>>> > > > --
>>>> > > > Eyal Edri
>>>> > > > Supervisor, RHEV CI
>>>> > > > EMEA ENG Virtualization R&D
>>>> > > > Red Hat Israel
>>>> > > >
>>>> > > > phone: +972-9-7692018
>>>> > > > irc: eedri (on #tlv #rhev-dev #rhev-integ)
>>>> > > >
>>>> > > >
>>>> > > > _______________________________________________
>>>> > > > Infra mailing list
>>>> > > > Infra(a)ovirt.org
>>>> > > >
http://lists.ovirt.org/mailman/listinfo/infra
>>>> > > >
>>>> > >
>>>> >
>>>>
>>>
>>>
>>>
>>> --
>>> Sandro Bonazzola
>>> Better technology. Faster innovation. Powered by community
>>> collaboration.
>>> See how it works at
redhat.com
>>>
>>
>> Have a nice weekend :)
>>
>> Roman
>>
>
>
>
> --
> Sandro Bonazzola
> Better technology. Faster innovation. Powered by community collaboration.
> See how it works at
redhat.com
>
--
Sandro Bonazzola
Better technology. Faster innovation. Powered by community collaboration.
See how it works at