Re: Build broken cause of commit aeb98b5a5ac807d23008ed26293244efab103bde, please fix ASAP

Hi, so I probably found the issue why this broke the build. I have checked the CI before merging and it was OK, see CI+1 on patch set 20. Now looking at console outputs of those jobs, the build itself failed, but build jobs are marked as SUCCESSFULL. So it seems we have a bug in those jobs!!! On Thu, May 19, 2016 at 3:53 PM, Tal Nisan <tnisan@redhat.com> wrote:
This commit broke the build, missing KernelEnv. Normally I'd revert but since it's feature freeze I'm more forgiving :) Please either revert or send a fix asap.
Thanks.

--17pEHd4RhPHOinZp Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 05/19 16:14, Martin Perina wrote:
Hi, =20 so I probably found the issue why this broke the build. I have checked the CI before merging and it was OK, see CI+1 on patch set 20. =20 Now looking at console outputs of those jobs, the build itself failed, but build jobs are marked as SUCCESSFULL. So it seems we have a bug in those jobs!!!
We will need a bit more info on which project/jenkins job/build, etc, by the email I can't extract the project that failed
=20 =20 =20 =20 =20 On Thu, May 19, 2016 at 3:53 PM, Tal Nisan <tnisan@redhat.com> wrote: =20
This commit broke the build, missing KernelEnv. Normally I'd revert but since it's feature freeze I'm more forgiving :) Please either revert or send a fix asap.
Thanks.
_______________________________________________ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra
--=20 David Caro Red Hat S.L. Continuous Integration Engineer - EMEA ENG Virtualization R&D Tel.: +420 532 294 605 Email: dcaro@redhat.com IRC: dcaro|dcaroest@{freenode|oftc|redhat} Web: www.redhat.com RHT Global #: 82-62605 --17pEHd4RhPHOinZp Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJXPcqcAAoJEEBxx+HSYmnDKC4H/3ZLGBWdlXmRIt/g1lfabqKm WCR3yyhbsKXd7LKLfN9v8KQBa2B8MjqcyYJCecmunU0doKVBlKAWBv4ISRCKTU2u fScW/5PYmQIYw3RQIWT8XwYWhLVaZc7BaU+LgFI4V2zseebebqyM1qhev79jXiyO U8PKyoVi/S5+R2TpkvdDJ5ybbCi5XtRTIMCHO77aoPKh9BeSY5AMbwIGt8ZPz3MG RRGjeY6IDqOZ4GUpAul/rTFpTaRm/DK1IBe+s4IX8d6eqImyYueoLopZ/6xpswns 1hO5A2G2JZmulo4nHqLDbpf6CwTVczjHqSvTyxjCwET8vb1cZ4qy+BIy3rjOebg= =GEGH -----END PGP SIGNATURE----- --17pEHd4RhPHOinZp--

On Thu, May 19, 2016 at 4:15 PM, David Caro <dcaro@redhat.com> wrote:
Hi,
so I probably found the issue why this broke the build. I have checked
On 05/19 16:14, Martin Perina wrote: the
CI before merging and it was OK, see CI+1 on patch set 20.
Now looking at console outputs of those jobs, the build itself failed, but build jobs are marked as SUCCESSFULL. So it seems we have a bug in those jobs!!!
We will need a bit more info on which project/jenkins job/build, etc, by the email I can't extract the project that failed
Sorry, here is the problematic patch: https://gerrit.ovirt.org/#/c/57052/ The problematic patch is build on patch set 20. It's marked as successfull, although engine build failed: http://jenkins.ovirt.org/job/ovirt-engine_master_check-patch-el7-x86_64/1250... Anyway, we are preparing reverting patch ... Sorry for the issue. Martin
On Thu, May 19, 2016 at 3:53 PM, Tal Nisan <tnisan@redhat.com> wrote:
This commit broke the build, missing KernelEnv. Normally I'd revert but since it's feature freeze I'm more forgiving :) Please either revert or send a fix asap.
Thanks.
_______________________________________________ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra
-- David Caro
Red Hat S.L. Continuous Integration Engineer - EMEA ENG Virtualization R&D
Tel.: +420 532 294 605 Email: dcaro@redhat.com IRC: dcaro|dcaroest@{freenode|oftc|redhat} Web: www.redhat.com RHT Global #: 82-62605

--K8nIJk4ghYZn606h Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 05/19 16:20, Martin Perina wrote:
On Thu, May 19, 2016 at 4:15 PM, David Caro <dcaro@redhat.com> wrote: =20
Hi,
so I probably found the issue why this broke the build. I have checked
On 05/19 16:14, Martin Perina wrote: the
CI before merging and it was OK, see CI+1 on patch set 20.
Now looking at console outputs of those jobs, the build itself failed, but build jobs are marked as SUCCESSFULL. So it seems we have a bug in those jobs!!!
We will need a bit more info on which project/jenkins job/build, etc, by the email I can't extract the project that failed
=20 =E2=80=8BSorry, here is the problematic patch: https://gerrit.ovirt.org/#= /c/57052/ =20 The problematic patch is build on patch set 20. It's marked as successful= l, although engine build failed: =20 http://jenkins.ovirt.org/job/ovirt-engine_master_check-patch-el7-x86_64/1= 250/console =20 =20 Anyway, we are preparing reverting patch ...
I see, the issue was introduced by me in the mock_runner.sh script, will se= nd a patch right away
=20 Sorry for the issue. =20 Martin =E2=80=8B =20 =20
On Thu, May 19, 2016 at 3:53 PM, Tal Nisan <tnisan@redhat.com> wrote:
This commit broke the build, missing KernelEnv. Normally I'd revert but since it's feature freeze I'm more forgivin=
g :)
Please either revert or send a fix asap.
Thanks.
_______________________________________________ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra
-- David Caro
Red Hat S.L. Continuous Integration Engineer - EMEA ENG Virtualization R&D
Tel.: +420 532 294 605 Email: dcaro@redhat.com IRC: dcaro|dcaroest@{freenode|oftc|redhat} Web: www.redhat.com RHT Global #: 82-62605
--=20 David Caro Red Hat S.L. Continuous Integration Engineer - EMEA ENG Virtualization R&D Tel.: +420 532 294 605 Email: dcaro@redhat.com IRC: dcaro|dcaroest@{freenode|oftc|redhat} Web: www.redhat.com RHT Global #: 82-62605 --K8nIJk4ghYZn606h Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJXPcwhAAoJEEBxx+HSYmnDhD8H/jJZOEIGbOgxVBQ9JhpLaEO8 hzed7jpOJrW/+SABH42MQIRGoCWs9hIjAjWdVTR+Ev2BF4Kslto6VELRvylkzDc3 bhWRycF2w54mB7G48S8eyLh53ySDmHG5lNplgRo70ffu/IGOpGOvztQ7Z8CJS6gX 86GeDNOrZMG8kZR2N505iOGtswRZR2JeP5R+8cUGjKPF58ficbyhQ7DsvUobJeuI dcM4/5Ehnt/XFjJD/E7rlI74KJRbbK+d6L/SEX8CEt+xqc+quYwbNBRfH4Gm2MQ1 6KDSUuTbW5/kBG2MqxYLZ5okJ+ZTyKwG1x5LOlr3OP/xtvOA7QstoZ9L4H3vdv0= =8MPV -----END PGP SIGNATURE----- --K8nIJk4ghYZn606h--

No need, already reverted once I've read you message, had it reverted and verified so I could keep working on the branch - https://gerrit.ovirt.org/#/c/57742/ BTW, both jobs ended with a failure: http://jenkins.ovirt.org/job/ovirt-engine_master_upgrade-from-master_el7_mer... : FAILURE http://jenkins.ovirt.org/job/ovirt-engine_master_upgrade-from-3.6_el7_merged... : FAILURE On Thu, May 19, 2016 at 5:22 PM, David Caro <dcaro@redhat.com> wrote:
On 05/19 16:20, Martin Perina wrote:
On Thu, May 19, 2016 at 4:15 PM, David Caro <dcaro@redhat.com> wrote:
Hi,
so I probably found the issue why this broke the build. I have checked
On 05/19 16:14, Martin Perina wrote: the
CI before merging and it was OK, see CI+1 on patch set 20.
Now looking at console outputs of those jobs, the build itself failed, but build jobs are marked as SUCCESSFULL. So it seems we have a bug in those jobs!!!
We will need a bit more info on which project/jenkins job/build, etc, by the email I can't extract the project that failed
Sorry, here is the problematic patch: https://gerrit.ovirt.org/#/c/57052/
The problematic patch is build on patch set 20. It's marked as successfull, although engine build failed:
http://jenkins.ovirt.org/job/ovirt-engine_master_check-patch-el7-x86_64/1250...
Anyway, we are preparing reverting patch ...
I see, the issue was introduced by me in the mock_runner.sh script, will send a patch right away
Sorry for the issue.
Martin
On Thu, May 19, 2016 at 3:53 PM, Tal Nisan <tnisan@redhat.com>
wrote:
This commit broke the build, missing KernelEnv. Normally I'd revert but since it's feature freeze I'm more
forgiving :)
Please either revert or send a fix asap.
Thanks.
_______________________________________________ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra
-- David Caro
Red Hat S.L. Continuous Integration Engineer - EMEA ENG Virtualization R&D
Tel.: +420 532 294 605 Email: dcaro@redhat.com IRC: dcaro|dcaroest@{freenode|oftc|redhat} Web: www.redhat.com RHT Global #: 82-62605
-- David Caro
Red Hat S.L. Continuous Integration Engineer - EMEA ENG Virtualization R&D
Tel.: +420 532 294 605 Email: dcaro@redhat.com IRC: dcaro|dcaroest@{freenode|oftc|redhat} Web: www.redhat.com RHT Global #: 82-62605

On Thu, May 19, 2016 at 4:26 PM, Tal Nisan <tnisan@redhat.com> wrote:
No need, already reverted once I've read you message, had it reverted and verified so I could keep working on the branch - https://gerrit.ovirt.org/#/c/57742/ BTW, both jobs ended with a failure:
http://jenkins.ovirt.org/job/ovirt-engine_master_upgrade-from-master_el7_mer... : FAILURE
http://jenkins.ovirt.org/job/ovirt-engine_master_upgrade-from-3.6_el7_merged... : FAILURE
Yes, but those are executed only after patch is merged, check-patch jobs are return SUCCESS if when build failed, David is working on that.
On Thu, May 19, 2016 at 5:22 PM, David Caro <dcaro@redhat.com> wrote:
On 05/19 16:20, Martin Perina wrote:
On Thu, May 19, 2016 at 4:15 PM, David Caro <dcaro@redhat.com> wrote:
Hi,
so I probably found the issue why this broke the build. I have checked
On 05/19 16:14, Martin Perina wrote: the
CI before merging and it was OK, see CI+1 on patch set 20.
Now looking at console outputs of those jobs, the build itself failed, but build jobs are marked as SUCCESSFULL. So it seems we have a bug in those jobs!!!
We will need a bit more info on which project/jenkins job/build, etc, by the email I can't extract the project that failed
Sorry, here is the problematic patch: https://gerrit.ovirt.org/#/c/57052/
The problematic patch is build on patch set 20. It's marked as successfull, although engine build failed:
http://jenkins.ovirt.org/job/ovirt-engine_master_check-patch-el7-x86_64/1250...
Anyway, we are preparing reverting patch ...
I see, the issue was introduced by me in the mock_runner.sh script, will send a patch right away
Sorry for the issue.
Martin
On Thu, May 19, 2016 at 3:53 PM, Tal Nisan <tnisan@redhat.com>
wrote:
This commit broke the build, missing KernelEnv. Normally I'd revert but since it's feature freeze I'm more
forgiving :)
Please either revert or send a fix asap.
Thanks.
_______________________________________________ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra
-- David Caro
Red Hat S.L. Continuous Integration Engineer - EMEA ENG Virtualization R&D
Tel.: +420 532 294 605 Email: dcaro@redhat.com IRC: dcaro|dcaroest@{freenode|oftc|redhat} Web: www.redhat.com RHT Global #: 82-62605
-- David Caro
Red Hat S.L. Continuous Integration Engineer - EMEA ENG Virtualization R&D
Tel.: +420 532 294 605 Email: dcaro@redhat.com IRC: dcaro|dcaroest@{freenode|oftc|redhat} Web: www.redhat.com RHT Global #: 82-62605

Oh I see now what you are talking about, indeed in patchset 20 jobs were marked as successful even though the actually failed, a bug indeed On Thu, May 19, 2016 at 5:33 PM, Martin Perina <mperina@redhat.com> wrote:
On Thu, May 19, 2016 at 4:26 PM, Tal Nisan <tnisan@redhat.com> wrote:
No need, already reverted once I've read you message, had it reverted and verified so I could keep working on the branch - https://gerrit.ovirt.org/#/c/57742/ BTW, both jobs ended with a failure:
http://jenkins.ovirt.org/job/ovirt-engine_master_upgrade-from-master_el7_mer... : FAILURE
http://jenkins.ovirt.org/job/ovirt-engine_master_upgrade-from-3.6_el7_merged... : FAILURE
Yes, but those are executed only after patch is merged, check-patch jobs are return SUCCESS if when build failed, David is working on that.
On Thu, May 19, 2016 at 5:22 PM, David Caro <dcaro@redhat.com> wrote:
On 05/19 16:20, Martin Perina wrote:
On Thu, May 19, 2016 at 4:15 PM, David Caro <dcaro@redhat.com> wrote:
Hi,
so I probably found the issue why this broke the build. I have checked
On 05/19 16:14, Martin Perina wrote: the
CI before merging and it was OK, see CI+1 on patch set 20.
Now looking at console outputs of those jobs, the build itself failed, but build jobs are marked as SUCCESSFULL. So it seems we have a bug in those jobs!!!
We will need a bit more info on which project/jenkins job/build, etc, by the email I can't extract the project that failed
Sorry, here is the problematic patch: https://gerrit.ovirt.org/#/c/57052/
The problematic patch is build on patch set 20. It's marked as successfull, although engine build failed:
http://jenkins.ovirt.org/job/ovirt-engine_master_check-patch-el7-x86_64/1250...
Anyway, we are preparing reverting patch ...
I see, the issue was introduced by me in the mock_runner.sh script, will send a patch right away
Sorry for the issue.
Martin
On Thu, May 19, 2016 at 3:53 PM, Tal Nisan <tnisan@redhat.com>
wrote:
> This commit broke the build, missing KernelEnv. > Normally I'd revert but since it's feature freeze I'm more
forgiving :)
> Please either revert or send a fix asap. > > Thanks. > >
_______________________________________________ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra
-- David Caro
Red Hat S.L. Continuous Integration Engineer - EMEA ENG Virtualization R&D
Tel.: +420 532 294 605 Email: dcaro@redhat.com IRC: dcaro|dcaroest@{freenode|oftc|redhat} Web: www.redhat.com RHT Global #: 82-62605
-- David Caro
Red Hat S.L. Continuous Integration Engineer - EMEA ENG Virtualization R&D
Tel.: +420 532 294 605 Email: dcaro@redhat.com IRC: dcaro|dcaroest@{freenode|oftc|redhat} Web: www.redhat.com RHT Global #: 82-62605
participants (3)
-
David Caro
-
Martin Perina
-
Tal Nisan