Hello, Seems like no tests are running after merging to master. Is it intentionally? Master got broken due to one of the merges. Can we push the tests back in? Thanks, Edy.
On 01/25/2016 09:56 AM, Edward Haas wrote:
Hello,
Seems like no tests are running after merging to master. Is it intentionally?
Master got broken due to one of the merges. Can we push the tests back in?
https://gerrit.ovirt.org/#/c/51704/
Thanks, Edy. _______________________________________________ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra
The tests did run, see the last comment on the patch. Though they took some time, probably due to heavy load on jenkins - that usually happens when a feature branch or a massive patch is merged, adding to the jenkins queue. We are working on ways to handle it, but it would be better if the people who merge those patches will try to aim it to night time or over the weekend so the queue will have time to decrease and not affect the CI dramatically. E. On Mon, Jan 25, 2016 at 9:57 AM, Edward Haas <edwardh@redhat.com> wrote:
On 01/25/2016 09:56 AM, Edward Haas wrote:
Hello,
Seems like no tests are running after merging to master. Is it intentionally?
Master got broken due to one of the merges. Can we push the tests back in?
https://gerrit.ovirt.org/#/c/51704/
Thanks, Edy. _______________________________________________ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra
_______________________________________________ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra
-- Eyal Edri Associate Manager EMEA ENG Virtualization R&D Red Hat Israel phone: +972-9-7692018 irc: eedri (on #tlv #rhev-dev #rhev-integ)
On 01/25/2016 10:13 AM, Eyal Edri wrote:
The tests did run, see the last comment on the patch.
I meant the check_patch (it runs the tests)
Though they took some time, probably due to heavy load on jenkins - that usually happens when a feature branch or a massive patch is merged, adding to the jenkins queue.
We are working on ways to handle it, but it would be better if the people who merge those patches will try to aim it to night time or over the weekend so the queue will have time to decrease and not affect the CI dramatically.
E.
On Mon, Jan 25, 2016 at 9:57 AM, Edward Haas <edwardh@redhat.com <mailto:edwardh@redhat.com>> wrote:
On 01/25/2016 09:56 AM, Edward Haas wrote: > Hello, > > Seems like no tests are running after merging to master. > Is it intentionally? > > Master got broken due to one of the merges. > Can we push the tests back in?
https://gerrit.ovirt.org/#/c/51704/
> > Thanks, > Edy. > _______________________________________________ > Infra mailing list > Infra@ovirt.org <mailto:Infra@ovirt.org> > http://lists.ovirt.org/mailman/listinfo/infra >
_______________________________________________ Infra mailing list Infra@ovirt.org <mailto:Infra@ovirt.org> http://lists.ovirt.org/mailman/listinfo/infra
-- Eyal Edri Associate Manager EMEA ENG Virtualization R&D Red Hat Israel
phone: +972-9-7692018 irc: eedri (on #tlv #rhev-dev #rhev-integ)
Jenkins CI Jan 12 12:34 PM ↩ Patch Set 1: Continuous-Integration-1 Build Failed http://jenkins.ovirt.org/job/vdsm_master_check-patch-fc23-x86_64/2089/ : FAILURE Shahar Havivi Patch Set 1: Verified-1 On Mon, Jan 25, 2016 at 10:27 AM, Edward Haas <edwardh@redhat.com> wrote:
On 01/25/2016 10:13 AM, Eyal Edri wrote:
The tests did run, see the last comment on the patch.
I meant the check_patch (it runs the tests)
Though they took some time, probably due to heavy load on jenkins - that usually happens when a feature branch or a massive patch is merged, adding to the jenkins queue.
We are working on ways to handle it, but it would be better if the people who merge those patches will try to aim it to night time or over the weekend so the queue will have time to decrease and not affect the CI dramatically.
E.
On Mon, Jan 25, 2016 at 9:57 AM, Edward Haas <edwardh@redhat.com <mailto:edwardh@redhat.com>> wrote:
On 01/25/2016 09:56 AM, Edward Haas wrote: > Hello, > > Seems like no tests are running after merging to master. > Is it intentionally? > > Master got broken due to one of the merges. > Can we push the tests back in?
https://gerrit.ovirt.org/#/c/51704/
> > Thanks, > Edy. > _______________________________________________ > Infra mailing list > Infra@ovirt.org <mailto:Infra@ovirt.org> > http://lists.ovirt.org/mailman/listinfo/infra >
_______________________________________________ Infra mailing list Infra@ovirt.org <mailto:Infra@ovirt.org> http://lists.ovirt.org/mailman/listinfo/infra
-- Eyal Edri Associate Manager EMEA ENG Virtualization R&D Red Hat Israel
phone: +972-9-7692018 irc: eedri (on #tlv #rhev-dev #rhev-integ)
-- Eyal Edri Associate Manager EMEA ENG Virtualization R&D Red Hat Israel phone: +972-9-7692018 irc: eedri (on #tlv #rhev-dev #rhev-integ)
On 25 January 2016 at 10:27, Edward Haas <edwardh@redhat.com> wrote:
On 01/25/2016 10:13 AM, Eyal Edri wrote:
The tests did run, see the last comment on the patch.
I meant the check_patch (it runs the tests)
check_patch runs for patch before merge. check_merged runs after merge. So if you want tests to run after merge you need to put them in check_merged.sh -- Barak Korren bkorren@redhat.com RHEV-CI Team
On 01/25/2016 10:33 AM, Barak Korren wrote:
On 25 January 2016 at 10:27, Edward Haas <edwardh@redhat.com> wrote:
On 01/25/2016 10:13 AM, Eyal Edri wrote:
The tests did run, see the last comment on the patch.
I meant the check_patch (it runs the tests)
check_patch runs for patch before merge. check_merged runs after merge.
So if you want tests to run after merge you need to put them in check_merged.sh
Yes sorry, check_merge is the one. Was it removed intentionally?
Yes, we never ran check_patch for vdsm Can we add back our el7,f22,f21 runs for our current check_patch? I asked for that few weeks ago, and I think its important to avoid regressions Thanks. On Mon, Jan 25, 2016 at 11:20 AM, Barak Korren <bkorren@redhat.com> wrote:
Yes sorry, check_merge is the one. Was it removed intentionally?
Looks like there aren't check_merged jobs for vdsm, were there? Did anyone made any at some point?
-- Barak Korren bkorren@redhat.com RHEV-CI Team _______________________________________________ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra
-- *Yaniv Bronhaim.*
I'm guessing there was a reason to remove/disable them? Adding Danken. Anton can help to re-enable them if needed. e. On Mon, Jan 25, 2016 at 11:48 AM, Yaniv Bronheim <ybronhei@redhat.com> wrote:
Yes, we never ran check_patch for vdsm
Can we add back our el7,f22,f21 runs for our current check_patch? I asked for that few weeks ago, and I think its important to avoid regressions Thanks.
On Mon, Jan 25, 2016 at 11:20 AM, Barak Korren <bkorren@redhat.com> wrote:
Yes sorry, check_merge is the one. Was it removed intentionally?
Looks like there aren't check_merged jobs for vdsm, were there? Did anyone made any at some point?
-- Barak Korren bkorren@redhat.com RHEV-CI Team _______________________________________________ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra
-- *Yaniv Bronhaim.*
-- Eyal Edri Associate Manager EMEA ENG Virtualization R&D Red Hat Israel phone: +972-9-7692018 irc: eedri (on #tlv #rhev-dev #rhev-integ)
On Mon, Jan 25, 2016 at 02:39:24PM +0200, Eyal Edri wrote:
I'm guessing there was a reason to remove/disable them? Adding Danken.
Anton can help to re-enable them if needed.
We should simply add automation/check_merge to vdsm.git; and we should start by having them as a softlink to automation/check_patch* files. Edy, can you take care of that?
----- Original Message ----- | From: "Dan Kenigsberg" <danken@redhat.com> | To: "Eyal Edri" <eedri@redhat.com> | Cc: "Yaniv Bronheim" <ybronhei@redhat.com>, "Anton Marchukov" <amarchuk@redhat.com>, "Barak Korren" | <bkorren@redhat.com>, "Edward Haas" <edwardh@redhat.com>, "infra" <infra@ovirt.org> | Sent: Wednesday, January 27, 2016 8:31:21 AM | Subject: Re: CI does not run tests post merge | | On Mon, Jan 25, 2016 at 02:39:24PM +0200, Eyal Edri wrote: | > I'm guessing there was a reason to remove/disable them? | > Adding Danken. | > | > Anton can help to re-enable them if needed. | | We should simply add automation/check_merge to vdsm.git; and we should | start by having them as a softlink to automation/check_patch* files. | | Edy, can you take care of that? | Done, https://gerrit.ovirt.org/#/c/52779 Is there a way to test it before merging it?
Done, https://gerrit.ovirt.org/#/c/52779
Is there a way to test it before merging it?
You can use mock_runner.sh (see "Testing the scripts locally" here: [1]) You will also need to merge this patch to get this actually running in Jenkins: https://gerrit.ovirt.org/#/c/52780/ [1]: http://www.ovirt.org/CI/Build_and_test_standards -- Barak Korren bkorren@redhat.com RHEV-CI Team
participants (5)
-
Barak Korren -
Dan Kenigsberg -
Edward Haas -
Eyal Edri -
Yaniv Bronheim