About https://gerrit.ovirt.org/#/c/46925/ *Juan Hernandez* Mar 7 5:34 PM Patch Set 14: The only important thing that is missing is what will happen with the findbugs reports. Will we still have a report that tells us what bugs exist, what have been fixed since the last build, etc? If I understand correctly that is generated by the Jenkins findbugs plugin, and this patch doesn't use it. Will we preserve the separate findbugs job? In addition I have recently learned that the "findbugs:findbugs" mojo runs the checks, but doesn't fail the build if it finds issues. There is a different "findbugs:check" mojo that runs the check and fails the build with the first issue. It may be more appropriate for this purpose. Eyal, David, other infra members, any hint on how to progress with this patch? -- Sandro Bonazzola Better technology. Faster innovation. Powered by community collaboration. See how it works at redhat.com
--oTHb8nViIGeoXxdp Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 03/09 15:57, Sandro Bonazzola wrote:
About https://gerrit.ovirt.org/#/c/46925/ =20 =20 *Juan Hernandez* Mar 7 5:34 PM =20 Patch Set 14: =20 The only important thing that is missing is what will happen with the findbugs reports. Will we still have a report that tells us what bugs exist, what have been fixed since the last build, etc?=20
No, it won't
If I understand correctly that is generated by the Jenkins findbugs plugin, and this patch doesn't use it. Will we preserve the separate findbugs job?
No, we shouldn't (that's the idea if generalizing the jobs, so there are no special ones)
=20 In addition I have recently learned that the "findbugs:findbugs" mojo runs the checks, but doesn't fail the build if it finds issues. There is a different "findbugs:check" mojo that runs the check and fails the build with the first issue. It may be more appropriate for this purpose.
That's a nice improvement, as allows removing the check for errors in the report file that it's doing right now.
=20 =20 Eyal, David, other infra members, any hint on how to progress with this patch?
My idea of this was to solve it creating dynamic jobs with the pipeline plu= gin whenever we started using it for the standard ci as it allows you to dynamically generate jobs, you might be able to see if there was a report generated before enabling certain plugin (like findbugs), as the current is= sue is that if you enable it for the standard ci, it will fail if the report is= not generated (and not all the jobs generate it). But that might take some time (more now that it's dropped from my prioritie= s) so you might want to find another solution. I really don't recommend it, but it should be possible to use yaml macros a= nd write one macro for each job that needs those extra plugins including the standard and adding the publisher. But that's bread for today and hunger for tomorrow, so be careful.
=20 =20 --=20 Sandro Bonazzola Better technology. Faster innovation. Powered by community collaboration. See how it works at redhat.com
_______________________________________________ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra
--=20 David Caro Red Hat S.L. Continuous Integration Engineer - EMEA ENG Virtualization R&D Tel.: +420 532 294 605 Email: dcaro@redhat.com IRC: dcaro|dcaroest@{freenode|oftc|redhat} Web: www.redhat.com RHT Global #: 82-62605 --oTHb8nViIGeoXxdp Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJW4DyCAAoJEEBxx+HSYmnDElwH/0yWD0XQhRwnuebXy1SBt0wo vAjyT8fuj0OskJdLocbGv69Ry7fMpdEpeOVs6A0GSgzKwW9yexgoB5uo+c82XgNu w6X0w8cGs1bslDZnIeMEC00dQzSv6pUobL2IPIxoW9alZz9xEM5y2ynKXi2QipqD a3eo9HgvtnHSSWdPQB0cvB5pXn6/2erm/ZCqu8pXehm61Z/zOXmLTZUsdNn1Psps Tw9pzaswH3E1pAi6uivbJnW08UrO7hPy9MFMU8L2wmJHk8w97pAPw2kGov1AYKFC rNp2K2jhS61YEWJTFiG9/9b3sdXtESAXA9+CV8kQ1/PP7UZdha37dTGaWOakOXc= =1Bpl -----END PGP SIGNATURE----- --oTHb8nViIGeoXxdp--
I think the idea is to add report.html generic file that will show anything we'd like. Having said that, it might be too complex or overkill to do it right now just for findbugs, so maybe we can still use the findbugs plugin and provide the xml file (?) to the plugin? Maybe we can use [1] as a generic static analysis single plugin that will work for multiple tools? [1] https://wiki.jenkins-ci.org/display/JENKINS/Analysis+Collector+Plugin On Wed, Mar 9, 2016 at 2:57 PM, Sandro Bonazzola <sbonazzo@redhat.com> wrote:
About https://gerrit.ovirt.org/#/c/46925/
*Juan Hernandez* Mar 7 5:34 PM
Patch Set 14:
The only important thing that is missing is what will happen with the findbugs reports. Will we still have a report that tells us what bugs exist, what have been fixed since the last build, etc? If I understand correctly that is generated by the Jenkins findbugs plugin, and this patch doesn't use it. Will we preserve the separate findbugs job?
In addition I have recently learned that the "findbugs:findbugs" mojo runs the checks, but doesn't fail the build if it finds issues. There is a different "findbugs:check" mojo that runs the check and fails the build with the first issue. It may be more appropriate for this purpose.
Eyal, David, other infra members, any hint on how to progress with this patch?
-- Sandro Bonazzola Better technology. Faster innovation. Powered by community collaboration. See how it works at redhat.com
-- Eyal Edri Associate Manager EMEA ENG Virtualization R&D Red Hat Israel phone: +972-9-7692018 irc: eedri (on #tlv #rhev-dev #rhev-integ)
--n2Pv11Ogg/Ox8ay5 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 03/09 15:19, Eyal Edri wrote:
I think the idea is to add report.html generic file that will show anythi= ng we'd like. Having said that, it might be too complex or overkill to do it right now just for findbugs, so maybe we can still use the findbugs plugin and provide the xml file (?) to the plugin? =20 Maybe we can use [1] as a generic static analysis single plugin that will work for multiple tools? =20 [1] https://wiki.jenkins-ci.org/display/JENKINS/Analysis+Collector+Plugin
This has the same issues than using each specific plugin, as it requires ea= ch of them to be configured (it just aggregates them, but does not do the result computations)
=20 =20 On Wed, Mar 9, 2016 at 2:57 PM, Sandro Bonazzola <sbonazzo@redhat.com> wrote: =20
About https://gerrit.ovirt.org/#/c/46925/
*Juan Hernandez* Mar 7 5:34 PM
Patch Set 14:
The only important thing that is missing is what will happen with the findbugs reports. Will we still have a report that tells us what bugs exist, what have been fixed since the last build, etc? If I understand correctly that is generated by the Jenkins findbugs plugin, and this pa= tch doesn't use it. Will we preserve the separate findbugs job?
In addition I have recently learned that the "findbugs:findbugs" mojo r= uns the checks, but doesn't fail the build if it finds issues. There is a different "findbugs:check" mojo that runs the check and fails the build with the first issue. It may be more appropriate for this purpose.
Eyal, David, other infra members, any hint on how to progress with this patch?
-- Sandro Bonazzola Better technology. Faster innovation. Powered by community collaboratio= n. See how it works at redhat.com
=20 =20 =20 --=20 Eyal Edri Associate Manager EMEA ENG Virtualization R&D Red Hat Israel =20 phone: +972-9-7692018 irc: eedri (on #tlv #rhev-dev #rhev-integ)
--=20 David Caro Red Hat S.L. Continuous Integration Engineer - EMEA ENG Virtualization R&D Tel.: +420 532 294 605 Email: dcaro@redhat.com IRC: dcaro|dcaroest@{freenode|oftc|redhat} Web: www.redhat.com RHT Global #: 82-62605 --n2Pv11Ogg/Ox8ay5 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJW4D9wAAoJEEBxx+HSYmnD/iAH/iS9+W/1NctfiZBPxCmXTS5n VwsmC/E/aA13yB51ObdRc+P3YZTa4EgZ1Ad/cNfVb4fvPOdGFTA1bdQ3eJE6Vrdb JWkEnRkAYip8a0uXbPm3jXHA5noWDvdjeRsTnBak3f/yH1ykyVut/Li9DNtQoF4O uWmysbezVdnoDPqGgMtwW600G1p1YEqguMDsh74ZtREbzoUoJDmT0cGJLGUALnG4 OP4B+J8EYFUqTmD7eOrk9Am6p47HgK5diogBhjpWF6x11xzZxw3LE8wjU3Fzn3TW cDN6ziXLELdydNs+dP2OmquWa9QJ5+UbvQnKhSkoDX2BT7J0T5QlOIimzmaKbUo= =cwbQ -----END PGP SIGNATURE----- --n2Pv11Ogg/Ox8ay5--
Isn't there a plugin like x-unit for findbugs that can just get XML file and present the graphs? for the alerts on limit maybe we can implement something ourselves. On Wed, Mar 9, 2016 at 3:21 PM, David Caro Estevez <dcaro@redhat.com> wrote:
On 03/09 15:19, Eyal Edri wrote:
I think the idea is to add report.html generic file that will show anything we'd like. Having said that, it might be too complex or overkill to do it right now just for findbugs, so maybe we can still use the findbugs plugin and provide the xml file (?) to the plugin?
Maybe we can use [1] as a generic static analysis single plugin that will work for multiple tools?
[1] https://wiki.jenkins-ci.org/display/JENKINS/Analysis+Collector+Plugin
This has the same issues than using each specific plugin, as it requires each of them to be configured (it just aggregates them, but does not do the result computations)
On Wed, Mar 9, 2016 at 2:57 PM, Sandro Bonazzola <sbonazzo@redhat.com> wrote:
About https://gerrit.ovirt.org/#/c/46925/
*Juan Hernandez* Mar 7 5:34 PM
Patch Set 14:
The only important thing that is missing is what will happen with the findbugs reports. Will we still have a report that tells us what bugs exist, what have been fixed since the last build, etc? If I understand correctly that is generated by the Jenkins findbugs plugin, and this
patch
doesn't use it. Will we preserve the separate findbugs job?
In addition I have recently learned that the "findbugs:findbugs" mojo runs the checks, but doesn't fail the build if it finds issues. There is a different "findbugs:check" mojo that runs the check and fails the build with the first issue. It may be more appropriate for this purpose.
Eyal, David, other infra members, any hint on how to progress with this patch?
-- Sandro Bonazzola Better technology. Faster innovation. Powered by community
collaboration. > > See how it works at redhat.com > > > > > > -- > Eyal Edri > Associate Manager > EMEA ENG Virtualization R&D > Red Hat Israel > > phone: +972-9-7692018 > irc: eedri (on #tlv #rhev-dev #rhev-integ)
-- David Caro
Red Hat S.L. Continuous Integration Engineer - EMEA ENG Virtualization R&D
Tel.: +420 532 294 605 Email: dcaro@redhat.com IRC: dcaro|dcaroest@{freenode|oftc|redhat} Web: www.redhat.com RHT Global #: 82-62605
-- Eyal Edri Associate Manager EMEA ENG Virtualization R&D Red Hat Israel phone: +972-9-7692018 irc: eedri (on #tlv #rhev-dev #rhev-integ)
--2hMgfIw2X+zgXrFs Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 03/09 15:28, Eyal Edri wrote:
Isn't there a plugin like x-unit for findbugs that can just get XML file and present the graphs? for the alerts on limit maybe we can implement something ourselves.
=20 On Wed, Mar 9, 2016 at 3:21 PM, David Caro Estevez <dcaro@redhat.com> wro= te: =20
On 03/09 15:19, Eyal Edri wrote:
I think the idea is to add report.html generic file that will show anything we'd like. Having said that, it might be too complex or overkill to do it right = now just for findbugs, so maybe we can still use the findbugs plugin and provide the xml file (?) to the plugin?
Maybe we can use [1] as a generic static analysis single plugin that = will work for multiple tools?
[1] https://wiki.jenkins-ci.org/display/JENKINS/Analysis+Collector+Plugin
This has the same issues than using each specific plugin, as it requires each of them to be configured (it just aggregates them, but does not do the result computations)
On Wed, Mar 9, 2016 at 2:57 PM, Sandro Bonazzola <sbonazzo@redhat.com> wrote:
About https://gerrit.ovirt.org/#/c/46925/
*Juan Hernandez* Mar 7 5:34 PM
Patch Set 14:
The only important thing that is missing is what will happen with t=
findbugs reports. Will we still have a report that tells us what bu= gs exist, what have been fixed since the last build, etc? If I underst= and correctly that is generated by the Jenkins findbugs plugin, and this
he patch
doesn't use it. Will we preserve the separate findbugs job?
In addition I have recently learned that the "findbugs:findbugs" mo= jo runs the checks, but doesn't fail the build if it finds issues. There is= a different "findbugs:check" mojo that runs the check and fails the b= uild with the first issue. It may be more appropriate for this purpose.
Eyal, David, other infra members, any hint on how to progress with =
There is, the issue is that if that xml file does not exist it fails the jo= b, so it's not good to be added to the ci-standard this
patch?
-- Sandro Bonazzola Better technology. Faster innovation. Powered by community
collaboration. > > See how it works at redhat.com > > > > > > -- > Eyal Edri > Associate Manager > EMEA ENG Virtualization R&D > Red Hat Israel > > phone: +972-9-7692018 > irc: eedri (on #tlv #rhev-dev #rhev-integ)
-- David Caro
Red Hat S.L. Continuous Integration Engineer - EMEA ENG Virtualization R&D
Tel.: +420 532 294 605 Email: dcaro@redhat.com IRC: dcaro|dcaroest@{freenode|oftc|redhat} Web: www.redhat.com RHT Global #: 82-62605
=20 =20 =20 --=20 Eyal Edri Associate Manager EMEA ENG Virtualization R&D Red Hat Israel =20 phone: +972-9-7692018 irc: eedri (on #tlv #rhev-dev #rhev-integ)
--=20 David Caro Red Hat S.L. Continuous Integration Engineer - EMEA ENG Virtualization R&D Tel.: +420 532 294 605 Email: dcaro@redhat.com IRC: dcaro|dcaroest@{freenode|oftc|redhat} Web: www.redhat.com RHT Global #: 82-62605 --2hMgfIw2X+zgXrFs Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJW4EG9AAoJEEBxx+HSYmnDD50H/3L9m3TTRVKyqDcHoiNVf2hX 9J2HWCja9vR7N3Qs0OEExMmpGsUYULQyT8EVzeuHrV1OvLUqhFi6TFvCCmTobarO qWfSr9Uyz7Wfvrua9uM9xDuGqAfeEIb61fOfU0VWSe65nwkMMIV5HXIVBbaaeeUf onTJK8u0kj/EziwkzSXLh7AjkdaF7VKTYIZ4/ti1z8d2kA7DDh/fpmtaItOTsseU KBMONAxLUCUQ4HSloALexBj+oR0A/Xcm19cuu0UDZSEejC5B96L540GRzgvWusIS FjDDjPaLKjNMg5jPy4jAEqNL8yWB3QFNryQyCEu3v3eu9Rw54FTHv3YEY1MsIdY= =9dfD -----END PGP SIGNATURE----- --2hMgfIw2X+zgXrFs--
On Wed, Mar 9, 2016 at 3:31 PM, David Caro Estevez <dcaro@redhat.com> wrote:
On 03/09 15:28, Eyal Edri wrote:
Isn't there a plugin like x-unit for findbugs that can just get XML file and present the graphs? for the alerts on limit maybe we can implement something ourselves.
There is, the issue is that if that xml file does not exist it fails the job, so it's not good to be added to the ci-standard
What is the reason for not having that xml job? if we don't choose to run findbugs mvn goal?
On Wed, Mar 9, 2016 at 3:21 PM, David Caro Estevez <dcaro@redhat.com>
wrote:
On 03/09 15:19, Eyal Edri wrote:
I think the idea is to add report.html generic file that will show anything we'd like. Having said that, it might be too complex or overkill to do it right
just for findbugs, so maybe we can still use the findbugs plugin and provide the xml file (?) to the plugin?
Maybe we can use [1] as a generic static analysis single plugin that will work for multiple tools?
[1] https://wiki.jenkins-ci.org/display/JENKINS/Analysis+Collector+Plugin
This has the same issues than using each specific plugin, as it requires each of them to be configured (it just aggregates them, but does not do the result computations)
On Wed, Mar 9, 2016 at 2:57 PM, Sandro Bonazzola <
sbonazzo@redhat.com>
wrote:
About https://gerrit.ovirt.org/#/c/46925/
*Juan Hernandez* Mar 7 5:34 PM
Patch Set 14:
The only important thing that is missing is what will happen with
findbugs reports. Will we still have a report that tells us what bugs exist, what have been fixed since the last build, etc? If I understand correctly that is generated by the Jenkins findbugs plugin, and
patch
doesn't use it. Will we preserve the separate findbugs job?
In addition I have recently learned that the "findbugs:findbugs" mojo runs the checks, but doesn't fail the build if it finds issues. There is a different "findbugs:check" mojo that runs the check and fails the build with the first issue. It may be more appropriate for this purpose.
Eyal, David, other infra members, any hint on how to progress with
now the this this
patch?
-- Sandro Bonazzola Better technology. Faster innovation. Powered by community
collaboration. > > See how it works at redhat.com > > > > > > -- > Eyal Edri > Associate Manager > EMEA ENG Virtualization R&D > Red Hat Israel > > phone: +972-9-7692018 > irc: eedri (on #tlv #rhev-dev #rhev-integ)
-- David Caro
Red Hat S.L. Continuous Integration Engineer - EMEA ENG Virtualization R&D
Tel.: +420 532 294 605 Email: dcaro@redhat.com IRC: dcaro|dcaroest@{freenode|oftc|redhat} Web: www.redhat.com RHT Global #: 82-62605
-- Eyal Edri Associate Manager EMEA ENG Virtualization R&D Red Hat Israel
phone: +972-9-7692018 irc: eedri (on #tlv #rhev-dev #rhev-integ)
-- David Caro
Red Hat S.L. Continuous Integration Engineer - EMEA ENG Virtualization R&D
Tel.: +420 532 294 605 Email: dcaro@redhat.com IRC: dcaro|dcaroest@{freenode|oftc|redhat} Web: www.redhat.com RHT Global #: 82-62605
-- Eyal Edri Associate Manager EMEA ENG Virtualization R&D Red Hat Israel phone: +972-9-7692018 irc: eedri (on #tlv #rhev-dev #rhev-integ)
--aZoGpuMECXJckB41 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 03/09 15:32, Eyal Edri wrote:
On Wed, Mar 9, 2016 at 3:31 PM, David Caro Estevez <dcaro@redhat.com> wro= te: =20
On 03/09 15:28, Eyal Edri wrote:
Isn't there a plugin like x-unit for findbugs that can just get XML f= ile and present the graphs? for the alerts on limit maybe we can implement something ourselves.
There is, the issue is that if that xml file does not exist it fails the job, so it's not good to be added to the ci-standard
=20 What is the reason for not having that xml job? if we don't choose to run findbugs mvn goal?
=20 =20
On Wed, Mar 9, 2016 at 3:21 PM, David Caro Estevez <dcaro@redhat.com>
wrote:
On 03/09 15:19, Eyal Edri wrote:
I think the idea is to add report.html generic file that will show anything we'd like. Having said that, it might be too complex or overkill to do it ri=
ght
now
just for findbugs, so maybe we can still use the findbugs plugin = and provide the xml file (?) to the plugin?
Maybe we can use [1] as a generic static analysis single plugin t= hat will work for multiple tools?
[1] https://wiki.jenkins-ci.org/display/JENKINS/Analysis+Collector+Plug= in
This has the same issues than using each specific plugin, as it requires each of them to be configured (it just aggregates them, but does not do =
result computations)
On Wed, Mar 9, 2016 at 2:57 PM, Sandro Bonazzola <
sbonazzo@redhat.com>
wrote:
About https://gerrit.ovirt.org/#/c/46925/
*Juan Hernandez* Mar 7 5:34 PM
Patch Set 14:
The only important thing that is missing is what will happen wi=
It's running the findbugs, and it will fail if there are any errors, the question is if it would show nice graphs and compare the job historic resul= ts (what the jenkins findbugs plugin does). And you can't do that out of jenki= ns (not easily at least) the th
findbugs reports. Will we still have a report that tells us what bugs exist, what have been fixed since the last build, etc? If I understand correctly that is generated by the Jenkins findbugs plugin, and
patch
doesn't use it. Will we preserve the separate findbugs job?
In addition I have recently learned that the "findbugs:findbugs" mojo runs the checks, but doesn't fail the build if it finds issues. There is a different "findbugs:check" mojo that runs the check and fails t= he build with the first issue. It may be more appropriate for this purpo= se.
Eyal, David, other infra members, any hint on how to progress w= ith
the this this
patch?
-- Sandro Bonazzola Better technology. Faster innovation. Powered by community
collaboration. > > See how it works at redhat.com > > > > > > -- > Eyal Edri > Associate Manager > EMEA ENG Virtualization R&D > Red Hat Israel > > phone: +972-9-7692018 > irc: eedri (on #tlv #rhev-dev #rhev-integ)
-- David Caro
Red Hat S.L. Continuous Integration Engineer - EMEA ENG Virtualization R&D
Tel.: +420 532 294 605 Email: dcaro@redhat.com IRC: dcaro|dcaroest@{freenode|oftc|redhat} Web: www.redhat.com RHT Global #: 82-62605
-- Eyal Edri Associate Manager EMEA ENG Virtualization R&D Red Hat Israel
phone: +972-9-7692018 irc: eedri (on #tlv #rhev-dev #rhev-integ)
-- David Caro
Red Hat S.L. Continuous Integration Engineer - EMEA ENG Virtualization R&D
Tel.: +420 532 294 605 Email: dcaro@redhat.com IRC: dcaro|dcaroest@{freenode|oftc|redhat} Web: www.redhat.com RHT Global #: 82-62605
=20 =20 =20 --=20 Eyal Edri Associate Manager EMEA ENG Virtualization R&D Red Hat Israel =20 phone: +972-9-7692018 irc: eedri (on #tlv #rhev-dev #rhev-integ)
--=20 David Caro Red Hat S.L. Continuous Integration Engineer - EMEA ENG Virtualization R&D Tel.: +420 532 294 605 Email: dcaro@redhat.com IRC: dcaro|dcaroest@{freenode|oftc|redhat} Web: www.redhat.com RHT Global #: 82-62605 --aZoGpuMECXJckB41 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJW4EK1AAoJEEBxx+HSYmnDTLcH/0BVB3jHVI0vlGQR1ZscgtN4 boOeQ++PG+l6XMEx0cETqXIylECiwTKEnisliaRrcdiSLb4cv8qXhqDtT6S/eury 97qe1evijN/yZQXZD4sgGYzvM5OPq2QdHDgltlFd5lQIciu/a5Of15ABKizFhu5Y W3mO7+bkWaYDBTzSiFmBLsWrIEJXH0krL92cxdczdpecsi53ro26PlQv/phEXWFe VZeN/WvovgtNw2MLgdP4RPHpux3jxshtO495Ofia7W8vMxPupI1cYZMn+QYW1pjX ry9bZopQvlV+Uc49Iipd7cdSEpzxZGk1Kwzwl0e8O6l6UNLOF8qLqapMHuEmelQ= =xky6 -----END PGP SIGNATURE----- --aZoGpuMECXJckB41--
participants (3)
-
David Caro Estevez -
Eyal Edri -
Sandro Bonazzola