Invalid version of pep8 on some slaves
Hi infra, There is too old version of pep8 used on some slave, that cause pep8 test to fail for valid sources. Here is one example: http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/11846/console gerrit failure: + pep8 --version 1.4.5 + git diff HEAD~ + sed 's%^./*%%' + pep8 --diff '--filename=*.py,*.py.in,*/vdsm,*/supervdsmServer' + [[ 1 -ne 0 ]] + echo 'PEP8 Failed' PEP8 Failed + cat /home/jenkins/workspace/vdsm_master_pep8_gerrit/violations.xml lib/vdsm/tool/configurator.py:41:9: E123 closing bracket does not match indentation of opening bracket's line Running pep8 on Fedora 19 (version 1.4.6): $ pep8 lib/vdsm/tool/configurator.py; echo $? 0 Thanks, Nir
--KJvkvZqQCzHgjKcr Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 08/21, Nir Soffer wrote:
Hi infra, =20 There is too old version of pep8 used on some slave, that cause pep8 test= to fail for valid sources. =20 Here is one example: =20 http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/11846/console =20 gerrit failure: =20 + pep8 --version 1.4.5 + git diff HEAD~ + sed 's%^./*%%' + pep8 --diff '--filename=3D*.py,*.py.in,*/vdsm,*/supervdsmServer' + [[ 1 -ne 0 ]] + echo 'PEP8 Failed' PEP8 Failed + cat /home/jenkins/workspace/vdsm_master_pep8_gerrit/violations.xml lib/vdsm/tool/configurator.py:41:9: E123 closing bracket does not match i= ndentation of opening bracket's line =20 Running pep8 on Fedora 19 (version 1.4.6):
That's a centos 6 slave, and it seens that's the greatest python-pep8 we have for centos, it's greater than the on here: http://www.ovirt.org/Vdsm_Developers Can you please supply the correct version so we can add it to our repos? Thanks!
=20 $ pep8 lib/vdsm/tool/configurator.py; echo $? 0 =20 Thanks, Nir _______________________________________________ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra
--=20 David Caro Red Hat S.L. Continuous Integration Engineer - EMEA ENG Virtualization R&D Tel.: +420 532 294 605 Email: dcaro@redhat.com Web: www.redhat.com RHT Global #: 82-62605 --KJvkvZqQCzHgjKcr Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJT9ikgAAoJEEBxx+HSYmnDR68IAIz5OuX4tYt3vrONWVLsovbE DZbpPpYQSzhVu7YOEsK0HyZoqRgJth3rmzFvFNH4FCNeTEcwVgSiCq/LlSKuv35P oIU+bUyo58hfdN2l+n75UgF9tGqN/5tR0MACsHyfNv8KZ0shxn2LwWBsbvUu57uR GbYrHusQj2bq3oSM/D+fTufoOYTaHDf4re6GCgqTuh5ZarOmq01Au7EAX8OiNEFh u0QMcONwudl9qVB8cKrxtWkyYPJhJpiZmljqrt9BIaBdPSU9+axrFFwgnlnmTJo6 NXbLRz+/X7qsVlkVkTCrD/OhapsIa4B/1HJHcf0YtM5g3QUG0zjfoJC/TtEaC3c= =FCLQ -----END PGP SIGNATURE----- --KJvkvZqQCzHgjKcr--
----- Original Message -----
From: "David Caro" <dcaroest@redhat.com> To: "Nir Soffer" <nsoffer@redhat.com> Cc: "infra" <infra@ovirt.org> Sent: Thursday, August 21, 2014 8:15:12 PM Subject: Re: Invalid version of pep8 on some slaves
On 08/21, Nir Soffer wrote:
Hi infra,
There is too old version of pep8 used on some slave, that cause pep8 test to fail for valid sources.
Here is one example:
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/11846/console
gerrit failure:
+ pep8 --version 1.4.5 + git diff HEAD~ + sed 's%^./*%%' + pep8 --diff '--filename=*.py,*.py.in,*/vdsm,*/supervdsmServer' + [[ 1 -ne 0 ]] + echo 'PEP8 Failed' PEP8 Failed + cat /home/jenkins/workspace/vdsm_master_pep8_gerrit/violations.xml lib/vdsm/tool/configurator.py:41:9: E123 closing bracket does not match indentation of opening bracket's line
Running pep8 on Fedora 19 (version 1.4.6):
That's a centos 6 slave, and it seens that's the greatest python-pep8 we have for centos, it's greater than the on here: http://www.ovirt.org/Vdsm_Developers
David: you are correct, we need to fix the documentation. Dan: the version on that wiki page is too old - do you have a newer build?
Can you please supply the correct version so we can add it to our repos?
Thanks!
$ pep8 lib/vdsm/tool/configurator.py; echo $? 0
Thanks, Nir _______________________________________________ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra
-- David Caro
Red Hat S.L. Continuous Integration Engineer - EMEA ENG Virtualization R&D
Tel.: +420 532 294 605 Email: dcaro@redhat.com Web: www.redhat.com RHT Global #: 82-62605
On Thu, Aug 21, 2014 at 01:18:38PM -0400, Nir Soffer wrote:
----- Original Message -----
From: "David Caro" <dcaroest@redhat.com> To: "Nir Soffer" <nsoffer@redhat.com> Cc: "infra" <infra@ovirt.org> Sent: Thursday, August 21, 2014 8:15:12 PM Subject: Re: Invalid version of pep8 on some slaves
On 08/21, Nir Soffer wrote:
Hi infra,
There is too old version of pep8 used on some slave, that cause pep8 test to fail for valid sources.
Here is one example:
http://jenkins.ovirt.org/job/vdsm_master_pep8_gerrit/11846/console
gerrit failure:
+ pep8 --version 1.4.5 + git diff HEAD~ + sed 's%^./*%%' + pep8 --diff '--filename=*.py,*.py.in,*/vdsm,*/supervdsmServer' + [[ 1 -ne 0 ]] + echo 'PEP8 Failed' PEP8 Failed + cat /home/jenkins/workspace/vdsm_master_pep8_gerrit/violations.xml lib/vdsm/tool/configurator.py:41:9: E123 closing bracket does not match indentation of opening bracket's line
Running pep8 on Fedora 19 (version 1.4.6):
That's a centos 6 slave, and it seens that's the greatest python-pep8 we have for centos, it's greater than the on here: http://www.ovirt.org/Vdsm_Developers
David: you are correct, we need to fix the documentation.
Dan: the version on that wiki page is too old - do you have a newer build?
I don't have anything newer at the moment, though I don't really mind fast forwarding. On the meant while, I took myself the liberty of changing your patch to apease the ancient pep8 gods.
participants (3)
-
Dan Kenigsberg -
David Caro -
Nir Soffer