From: "Eli Mesika" <emesika(a)redhat.com&gt; To: "David Caro" <dcaroest(a)redhat.com&gt; Cc: "infra" <infra(a)ovirt.org&gt; Sent: Tuesday, March 11, 2014 1:32:40 AM Subject: Re: Infra scripting style guide proposal ----- Original Message ----- > From: "David Caro" <dcaroest(a)redhat.com&gt; > To: "infra" <infra(a)ovirt.org&gt; > Sent: Monday, March 10, 2014 9:17:13 PM > Subject: Infra scripting style guide proposal > > Hi everyone, > > Following the discussion thread and seeing that there's no more input > there, > I'd > like to propose this style guide: > > http://www.ovirt.org/Bash_style_guide > > As standard for our infrastructure scripts and guideline when reviewing > scripts. > > All the infra members please review the style guide and answer this email > with > your vote (+1 I like it, 0 I don't mind, -1 It has to change), if -1, add > also a > description of the problems you see so we can work on them. Hi David First of all thanks for your efforts in writing that, I am certainly for standards. However, I feel that we have to decide what kind of scripts we want to write. Alon (Bar Lev), for example , is for removing what he is calling 'bashisem' from the infra code, lately we had turned all dbscripts/dbutils code from bash to POSIX. So, I think that we should decide first on the direction ('to bash or not to bash, this is the question') Otherwise, we are left with a bunch of scripts, each written differently, and even if each has its code style guidelines, I believe that it makes our development environment harder to maintain and more buggy ...

> > All the non-infra people, you are welcome to vote also and give input, but > your > single vote will not be decisive. > > I'll close the voting next monday if no changes to the Style guide are > proposed. > > Thanks! > > dcaro +1 > > -- > David Caro > > Red Hat S.L. > Continuous Integration Engineer - EMEA ENG Virtualization R&D > > Email: dcaro(a)redhat.com > Web: www.redhat.com > RHT Global #: 82-62605 > > > _______________________________________________ > Infra mailing list > Infra(a)ovirt.org > http://lists.ovirt.org/mailman/listinfo/infra > _______________________________________________ Infra mailing list Infra(a)ovirt.org http://lists.ovirt.org/mailman/listinfo/infra

Correct. It seems that ovirt is targeted also to non-gnu oses (in the future I suppose) so portability inside the product is an issue, thus making the strict POSIX standard the appropriate tool. I'm not sure if there's any milestone set for that, but as I see it, is quite far, as I've been more than one year in the project, and we haven't got out of redhat based distributions, I see really hard to support non-gnu oses but if that's what was decided, let's go for it. But for any script we use to maintain the infrastructure of the project, from running a jenkins job, to creating repositories or adding a nagios check, we don't need to limit ourselves with POSIX, so we can benefit from the whole range of advantages and features bash offers and that gives us easy to write and easy to read scripts, making it easier to maintain and debug. ----- Original Message ----- > From: "Kiril Nesenko" <knesenko(a)redhat.com&gt; > To: "Eli Mesika" <emesika(a)redhat.com&gt; > Cc: "David Caro" <dcaroest(a)redhat.com&gt;, "infra" <infra(a)ovirt.org&gt; > Sent: Tuesday, March 11, 2014 9:11:28 AM > Subject: Re: Infra scripting style guide proposal > > > > ----- Original Message ----- > > From: "Eli Mesika" <emesika(a)redhat.com&gt; > > To: "David Caro" <dcaroest(a)redhat.com&gt; > > Cc: "infra" <infra(a)ovirt.org&gt; > > Sent: Tuesday, March 11, 2014 1:32:40 AM > > Subject: Re: Infra scripting style guide proposal > > > > > > > > ----- Original Message ----- > > > From: "David Caro" <dcaroest(a)redhat.com&gt; > > > To: "infra" <infra(a)ovirt.org&gt; > > > Sent: Monday, March 10, 2014 9:17:13 PM > > > Subject: Infra scripting style guide proposal > > > > > > Hi everyone, > > > > > > Following the discussion thread and seeing that there's no more input > > > there, > > > I'd > > > like to propose this style guide: > > > > > > http://www.ovirt.org/Bash_style_guide > > > > > > As standard for our infrastructure scripts and guideline when reviewing > > > scripts. > > > > > > All the infra members please review the style guide and answer this email > > > with > > > your vote (+1 I like it, 0 I don't mind, -1 It has to change), if -1, add > > > also a > > > description of the problems you see so we can work on them. > > > > Hi David > > First of all thanks for your efforts in writing that, I am certainly for > > standards. > > However, I feel that we have to decide what kind of scripts we want to > > write. > > Alon (Bar Lev), for example , is for removing what he is calling 'bashisem' > > from the infra code, lately we had turned all dbscripts/dbutils code from > > bash to POSIX. > > So, I think that we should decide first on the direction ('to bash or not > > to > > bash, this is the question') > > Otherwise, we are left with a bunch of scripts, each written differently, > > and > > even if each has its code style guidelines, I believe that it makes our > > development environment harder to maintain and more buggy ... > > Hello Eli, > > Scripts that are going to be shipped with the product should be written in > POSIX shell and this is correct. > But here we are talking about scripts that we (infra team) are going to use > to maintain our infrastructure - so there should be no problem to use bash > here, > since those scripts wont be shipped with the product. > > - Kiril > > > > > > > > > > All the non-infra people, you are welcome to vote also and give input, > > > but > > > your > > > single vote will not be decisive. > > > > > > I'll close the voting next monday if no changes to the Style guide are > > > proposed. > > > > > > Thanks! > > > > > > dcaro +1 > > > > > > -- > > > David Caro > > > > > > Red Hat S.L. > > > Continuous Integration Engineer - EMEA ENG Virtualization R&D > > > > > > Email: dcaro(a)redhat.com > > > Web: www.redhat.com > > > RHT Global #: 82-62605 > > > > > > > > > _______________________________________________ > > > Infra mailing list > > > Infra(a)ovirt.org > > > http://lists.ovirt.org/mailman/listinfo/infra > > > > > _______________________________________________ > > Infra mailing list > > Infra(a)ovirt.org > > http://lists.ovirt.org/mailman/listinfo/infra > > > _______________________________________________ Infra mailing list Infra(a)ovirt.org http://lists.ovirt.org/mailman/listinfo/infra

Correct. It seems that ovirt is targeted also to non-gnu oses (in the future I suppose) so portability inside the product is an issue, thus making the strict POSIX standard the appropriate tool. I'm not sure if there's any milestone set for that, but as I see it, is quite far, as I've been more than one year in the project, and we haven't got out of redhat based distributions, I see really hard to support non-gnu oses but if that's what was decided, let's go for it. But for any script we use to maintain the infrastructure of the project, from running a jenkins job, to creating repositories or adding a nagios check, we don't need to limit ourselves with POSIX, so we can benefit from the whole range of advantages and features bash offers and that gives us easy to write and easy to read scripts, making it easier to maintain and debug.

----- Original Message ----- > From: "Kiril Nesenko" <knesenko(a)redhat.com&gt; > To: "Eli Mesika" <emesika(a)redhat.com&gt; > Cc: "David Caro" <dcaroest(a)redhat.com&gt;, "infra" <infra(a)ovirt.org&gt; > Sent: Tuesday, March 11, 2014 9:11:28 AM > Subject: Re: Infra scripting style guide proposal > > > > ----- Original Message ----- >> From: "Eli Mesika" <emesika(a)redhat.com&gt; >> To: "David Caro" <dcaroest(a)redhat.com&gt; >> Cc: "infra" <infra(a)ovirt.org&gt; >> Sent: Tuesday, March 11, 2014 1:32:40 AM >> Subject: Re: Infra scripting style guide proposal >> >> >> >> ----- Original Message ----- >>> From: "David Caro" <dcaroest(a)redhat.com&gt; >>> To: "infra" <infra(a)ovirt.org&gt; >>> Sent: Monday, March 10, 2014 9:17:13 PM >>> Subject: Infra scripting style guide proposal >>> >>> Hi everyone, >>> >>> Following the discussion thread and seeing that there's no more input >>> there, >>> I'd >>> like to propose this style guide: >>> >>> http://www.ovirt.org/Bash_style_guide >>> >>> As standard for our infrastructure scripts and guideline when reviewing >>> scripts. >>> >>> All the infra members please review the style guide and answer this email >>> with >>> your vote (+1 I like it, 0 I don't mind, -1 It has to change), if -1, add >>> also a >>> description of the problems you see so we can work on them. >> >> Hi David >> First of all thanks for your efforts in writing that, I am certainly for >> standards. >> However, I feel that we have to decide what kind of scripts we want to >> write. >> Alon (Bar Lev), for example , is for removing what he is calling 'bashisem' >> from the infra code, lately we had turned all dbscripts/dbutils code from >> bash to POSIX. >> So, I think that we should decide first on the direction ('to bash or not >> to >> bash, this is the question') >> Otherwise, we are left with a bunch of scripts, each written differently, >> and >> even if each has its code style guidelines, I believe that it makes our >> development environment harder to maintain and more buggy ... > > Hello Eli, > > Scripts that are going to be shipped with the product should be written in > POSIX shell and this is correct. > But here we are talking about scripts that we (infra team) are going to use > to maintain our infrastructure - so there should be no problem to use bash > here, > since those scripts wont be shipped with the product. > > - Kiril >> >> >>> >>> All the non-infra people, you are welcome to vote also and give input, >>> but >>> your >>> single vote will not be decisive. >>> >>> I'll close the voting next monday if no changes to the Style guide are >>> proposed. >>> >>> Thanks! >>> >>> dcaro +1 >>> >>> -- >>> David Caro >>> >>> Red Hat S.L. >>> Continuous Integration Engineer - EMEA ENG Virtualization R&D >>> >>> Email: dcaro(a)redhat.com >>> Web: www.redhat.com >>> RHT Global #: 82-62605 >>> >>> >>> _______________________________________________ >>> Infra mailing list >>> Infra(a)ovirt.org >>> http://lists.ovirt.org/mailman/listinfo/infra >>> >> _______________________________________________ >> Infra mailing list >> Infra(a)ovirt.org >> http://lists.ovirt.org/mailman/listinfo/infra >> > _______________________________________________ Infra mailing list Infra(a)ovirt.org http://lists.ovirt.org/mailman/listinfo/infra

Hi everyone, =20 Following the discussion thread and seeing that there's no more input t=

like to propose this style guide: =20 http://www.ovirt.org/Bash_style_guide =20 As standard for our infrastructure scripts and guideline when reviewing=

=20 All the infra members please review the style guide and answer this ema=

your vote (+1 I like it, 0 I don't mind, -1 It has to change), if -1, a=

description of the problems you see so we can work on them. =20 All the non-infra people, you are welcome to vote also and give input, =

single vote will not be decisive. =20 I'll close the voting next monday if no changes to the Style guide are =

=20 Thanks! =20 dcaro +1 =20 =20 =20 _______________________________________________ Infra mailing list Infra(a)ovirt.org http://lists.ovirt.org/mailman/listinfo/infra =20

-----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJTKrSoAAoJEEBxx+HSYmnDLKkIAJFEtfSQ5ytt/XUugX4wAT0a ViFUhmDiqu8lzkzydb3J7BDVijaDdVxjNlOiy1CxDBNg1kcxMQkWVlQPQbWWp1GS 6E9SjbYb6lHDBD6t9iFTESCvxaurHVLj1EcWG8gnaWOw2Sp5z5M+0I1RWjiX+BVq MY1XpktnbBKu0Rpxjf0VCPWj/anEG9k6Qd+Yp9zDPLRX/4oG6UK9zP49Nyx72ITO v0Rg/k/ZBk5JI4hzFBEP8FCyfU7ZGSmHLTK6f061EMRt5pv/4iqgPOZWCaAXeym7 TE78sbbt5rnrQUKzm8fA3IhXId7FUjIrLRM/5bLUY4S+oBBVkw2N+k8hZM+1HWE= =HHrW -----END PGP SIGNATURE-----