[JIRA] (OVIRT-1821) jenkins 'check-patch.sh' does not always generate differences.html in downstream repos

1 Jan 2018

      This is a multi-part message in MIME format...

------------=_1514819059-25030-101
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

Barak Korren created OVIRT-1821:
-----------------------------------

             Summary: jenkins 'check-patch.sh' does not always generate differences.html in downstream repos
                 Key: OVIRT-1821
                 URL: https://ovirt-jira.atlassian.net/browse/OVIRT-1821
             Project: oVirt - virtualization made easy
          Issue Type: Bug
            Reporter: Barak Korren
            Assignee: infra

The 'check-patch.sh' script in the 'jenkins' repo knows how to generate a 'differences.html' file when job YAML changes.

The 'jenkins' repo is designed to be used as an upstream source repo for other repos, and it is designed that 'check-patch.sh' will be usable on those DS repos.

When YAML changes from the 'jenkins' repo  make it into the DS repos via a patch to the 'upstream-sources.yaml' file in the DS repo, and 'check-patch.sh' runs on that repo, 'differences.html' is not being generated, because the change to 'upstream-sources.yaml' does not look like a job YAML change.

We need to  change 'check-patch.sh' so that when running in a DS repo, it knows how to look and diagnose changes coming from the upstream repo.

--
This message was sent by Atlassian Jira
(v1001.0.0-SNAPSHOT#100075)

------------=_1514819059-25030-101
Content-Type: text/html; charset="UTF-8"
Content-Disposition: inline
Content-Transfer-Encoding: 7bit

<html><body>
<h3>Barak Korren created OVIRT-1821:</h3>
<pre>   Summary: jenkins 'check-patch.sh' does not always generate differences.html in downstream repos
       Key: OVIRT-1821
       URL: https://ovirt-jira.atlassian.net/browse/OVIRT-1821
   Project: oVirt - virtualization made easy
Issue Type: Bug
  Reporter: Barak Korren
  Assignee: infra</pre>
<p>The ‘check-patch.sh’ script in the ‘jenkins’ repo knows how to generate a ‘differences.html’ file when job YAML changes.</p>
<p>The ‘jenkins’ repo is designed to be used as an upstream source repo for other repos, and it is designed that ‘check-patch.sh’ will be usable on those DS repos.</p>
<p>When YAML changes from the ‘jenkins’ repo  make it into the DS repos via a patch to the ‘upstream-sources.yaml’ file in the DS repo, and ‘check-patch.sh’ runs on that repo, ‘differences.html’ is not being generated, because the change to ‘upstream-sources.yaml’ does not look like a job YAML change.</p>
<p>We need to  change ‘check-patch.sh’ so that when running in a DS repo, it knows how to look and diagnose changes coming from the upstream repo.</p>
<p>— This message was sent by Atlassian Jira (v1001.0.0-SNAPSHOT#100075)</p>

<img src="https://u4043402.ct.sendgrid.net/wf/open?upn=i5TMWGV99amJbNxJpSp2-2BJ33BSM3t..." alt="" width="1" height="1" border="0" style="height:1px !important;width:1px !important;border-width:0 !important;margin-top:0 !important;margin-bottom:0 !important;margin-right:0 !important;margin-left:0 !important;padding-top:0 !important;padding-bottom:0 !important;padding-right:0 !important;padding-left:0 !important;"/>
</body></html>

------------=_1514819059-25030-101--

Barak Korren (oVirt JIRA)

tags

participants (1)