CI gives +1 on gerrit as a response to 'ci please build'.
Hi, When issuing 'ci please build' to generate artifacts, on success it sets Continuous-Integration to +1. It should not do that. Thanks, Edy.
Can you provide links with example? On Mon, Jan 16, 2017 at 3:34 PM, Edward Haas <ehaas@redhat.com> wrote:
Hi,
When issuing 'ci please build' to generate artifacts, on success it sets Continuous-Integration to +1.
It should not do that.
Thanks, Edy.
_______________________________________________ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra
-- Eyal Edri Associate Manager RHV DevOps EMEA ENG Virtualization R&D Red Hat Israel phone: +972-9-7692018 irc: eedri (on #tlv #rhev-dev #rhev-integ)
Edy showed me the issue. I think we haven't thought about that. 'ci please build' actually executes build artifacts jobs and when they succeed, they change the "continuous integration" flag to +1. Can we control it from the Gerrit? On Mon, Jan 16, 2017 at 3:42 PM, Eyal Edri <eedri@redhat.com> wrote:
Can you provide links with example?
On Mon, Jan 16, 2017 at 3:34 PM, Edward Haas <ehaas@redhat.com> wrote:
Hi,
When issuing 'ci please build' to generate artifacts, on success it sets Continuous-Integration to +1.
It should not do that.
Thanks, Edy.
_______________________________________________ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra
-- Eyal Edri Associate Manager RHV DevOps EMEA ENG Virtualization R&D Red Hat Israel
phone: +972-9-7692018 <+972%209-769-2018> irc: eedri (on #tlv #rhev-dev #rhev-integ)
_______________________________________________ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra
On Mon, Jan 16, 2017 at 4:05 PM, Gil Shinar <gshinar@redhat.com> wrote:
Edy showed me the issue. I think we haven't thought about that. 'ci please build' actually executes build artifacts jobs and when they succeed, they change the "continuous integration" flag to +1.
Can we control it from the Gerrit?
I couldn't find any reference for response from Jenkins to Grrit in the yaml templates in std CI, so not sure its configurable per job, it might be on the main Jenkins configuration. Barak - do you know where the grading is defined for Gerrit Trigger in YAML?
On Mon, Jan 16, 2017 at 3:42 PM, Eyal Edri <eedri@redhat.com> wrote:
Can you provide links with example?
On Mon, Jan 16, 2017 at 3:34 PM, Edward Haas <ehaas@redhat.com> wrote:
Hi,
When issuing 'ci please build' to generate artifacts, on success it sets Continuous-Integration to +1.
It should not do that.
Thanks, Edy.
_______________________________________________ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra
-- Eyal Edri Associate Manager RHV DevOps EMEA ENG Virtualization R&D Red Hat Israel
phone: +972-9-7692018 <+972%209-769-2018> irc: eedri (on #tlv #rhev-dev #rhev-integ)
_______________________________________________ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra
-- Eyal Edri Associate Manager RHV DevOps EMEA ENG Virtualization R&D Red Hat Israel phone: +972-9-7692018 irc: eedri (on #tlv #rhev-dev #rhev-integ)
You can actually do it from here in the job's configuration: [image: Inline image 1] Not sure how can we do it in yamls I'll check if it is phys-able On Mon, Jan 16, 2017 at 4:14 PM, Eyal Edri <eedri@redhat.com> wrote:
On Mon, Jan 16, 2017 at 4:05 PM, Gil Shinar <gshinar@redhat.com> wrote:
Edy showed me the issue. I think we haven't thought about that. 'ci please build' actually executes build artifacts jobs and when they succeed, they change the "continuous integration" flag to +1.
Can we control it from the Gerrit?
I couldn't find any reference for response from Jenkins to Grrit in the yaml templates in std CI, so not sure its configurable per job, it might be on the main Jenkins configuration. Barak - do you know where the grading is defined for Gerrit Trigger in YAML?
On Mon, Jan 16, 2017 at 3:42 PM, Eyal Edri <eedri@redhat.com> wrote:
Can you provide links with example?
On Mon, Jan 16, 2017 at 3:34 PM, Edward Haas <ehaas@redhat.com> wrote:
Hi,
When issuing 'ci please build' to generate artifacts, on success it sets Continuous-Integration to +1.
It should not do that.
Thanks, Edy.
_______________________________________________ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra
-- Eyal Edri Associate Manager RHV DevOps EMEA ENG Virtualization R&D Red Hat Israel
phone: +972-9-7692018 <+972%209-769-2018> irc: eedri (on #tlv #rhev-dev #rhev-integ)
_______________________________________________ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra
-- Eyal Edri Associate Manager RHV DevOps EMEA ENG Virtualization R&D Red Hat Israel
phone: +972-9-7692018 <+972%209-769-2018> irc: eedri (on #tlv #rhev-dev #rhev-integ)
בתאריך 16 בינו׳ 2017 04:14 PM, "Eyal Edri" <eedri@redhat.com> כתב: On Mon, Jan 16, 2017 at 4:05 PM, Gil Shinar <gshinar@redhat.com> wrote:
Edy showed me the issue. I think we haven't thought about that. 'ci please build' actually executes build artifacts jobs and when they succeed, they change the "continuous integration" flag to +1.
Can we control it from the Gerrit?
I couldn't find any reference for response from Jenkins to Grrit in the yaml templates in std CI, so not sure its configurable per job, it might be on the main Jenkins configuration. Barak - do you know where the grading is defined for Gerrit Trigger in YAML? Yeah we should be able to do it from the trigger YAML.
On 16 January 2017 at 16:14, Eyal Edri <eedri@redhat.com> wrote:
On Mon, Jan 16, 2017 at 4:05 PM, Gil Shinar <gshinar@redhat.com> wrote:
Edy showed me the issue. I think we haven't thought about that. 'ci please build' actually executes build artifacts jobs and when they succeed, they change the "continuous integration" flag to +1.
Can we control it from the Gerrit?
No need we can do it from the job.
I couldn't find any reference for response from Jenkins to Grrit in the yaml templates in std CI, so not sure its configurable per job, it might be on the main Jenkins configuration. Barak - do you know where the grading is defined for Gerrit Trigger in YAML?
Yeah you can use 'skip-vote" [1]. This requires Gerrit Trigger Plugin version >= 2.7.0 [1]: http://docs.openstack.org/infra/jenkins-job-builder/triggers.html#triggers.g... -- Barak Korren bkorren@redhat.com RHCE, RHCi, RHV-DevOps Team https://ifireball.wordpress.com/
Opening a ticket on it. We'll need to check which params to override in the new comment added trigger to not give +1. On Mon, Jan 16, 2017 at 10:01 PM, Barak Korren <bkorren@redhat.com> wrote:
On 16 January 2017 at 16:14, Eyal Edri <eedri@redhat.com> wrote:
On Mon, Jan 16, 2017 at 4:05 PM, Gil Shinar <gshinar@redhat.com> wrote:
Edy showed me the issue. I think we haven't thought about that. 'ci please build' actually executes build artifacts jobs and when they succeed, they change the "continuous integration" flag to +1.
Can we control it from the Gerrit?
No need we can do it from the job.
I couldn't find any reference for response from Jenkins to Grrit in the yaml templates in std CI, so not sure its configurable per job, it might be on the main Jenkins configuration. Barak - do you know where the grading is defined for Gerrit Trigger in YAML?
Yeah you can use 'skip-vote" [1]. This requires Gerrit Trigger Plugin version >= 2.7.0
[1]: http://docs.openstack.org/infra/jenkins-job-builder/ triggers.html#triggers.gerrit
-- Barak Korren bkorren@redhat.com RHCE, RHCi, RHV-DevOps Team https://ifireball.wordpress.com/
-- Eyal Edri Associate Manager RHV DevOps EMEA ENG Virtualization R&D Red Hat Israel phone: +972-9-7692018 irc: eedri (on #tlv #rhev-dev #rhev-integ)
participants (4)
-
Barak Korren -
Edward Haas -
Eyal Edri -
Gil Shinar