On 04/21/2016 03:38 PM, Fred Rolland wrote:

I am not sure how to check if they run as part of check-patch.sh script.

I think they run, but there is a long queue at the moment, so they take long even to start. The real issue, if I understand correctly, is that other jobs like the "findbugs" job are finishing before this even starts, and voting +1. As a result some patches that would have failed get a +1 because findbugs passes.

On Thu, Apr 21, 2016 at 4:28 PM, Eyal Edri <eedri@redhat.com <mailto:eedri@redhat.com>> wrote:

The unit tests moved to standard CI. They should run as part of check-patch.sh, at least this was my understanding this is why they were disabled.

Are you saying that they don't run as part of the check-patch.sh script?

E.

On Thu, Apr 21, 2016 at 4:22 PM, Fred Rolland <frolland@redhat.com <mailto:frolland@redhat.com>> wrote:

Hi team,

I lately rebased master on my local env and run the unit tests and it failed. However, checking on gerrit I could not find that the test are running on the patches ...

Any clue what happened here?

Thanks,

Freddy

_______________________________________________ Infra mailing list Infra@ovirt.org <mailto:Infra@ovirt.org> http://lists.ovirt.org/mailman/listinfo/infra

-- Eyal Edri Associate Manager RHEV DevOps EMEA ENG Virtualization R&D Red Hat Israel

phone: +972-9-7692018 <tel:%2B972-9-7692018> irc: eedri (on #tlv #rhev-dev #rhev-integ)

_______________________________________________ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra

-- Dirección Comercial: C/Jose Bardasano Baos, 9, Edif. Gorbea 3, planta 3ºD, 28016 Madrid, Spain Inscrita en el Reg. Mercantil de Madrid – C.I.F. B82657941 - Red Hat S.L.

They don't run. I just verified it in the Makefile (rpm quick build skip tests). sent https://gerrit.ovirt.org/#/c/56467/1 On Thu, Apr 21, 2016 at 4:42 PM, Fred Rolland <frolland@redhat.com> wrote:

I see BUILD_UT=0 in check-patch.sh script.

On Thu, Apr 21, 2016 at 4:38 PM, Fred Rolland <frolland@redhat.com> wrote:

...

I am not sure how to check if they run as part of check-patch.sh script.

On Thu, Apr 21, 2016 at 4:28 PM, Eyal Edri <eedri@redhat.com> wrote:

...

The unit tests moved to standard CI. They should run as part of check-patch.sh, at least this was my understanding this is why they were disabled.

Are you saying that they don't run as part of the check-patch.sh script?

E.

On Thu, Apr 21, 2016 at 4:22 PM, Fred Rolland <frolland@redhat.com> wrote:

...

Hi team,

I lately rebased master on my local env and run the unit tests and it failed. However, checking on gerrit I could not find that the test are running on the patches ...

Any clue what happened here?

Thanks,

Freddy

_______________________________________________ Infra mailing list Infra@ovirt.org http://lists.ovirt.org/mailman/listinfo/infra

-- Eyal Edri Associate Manager RHEV DevOps EMEA ENG Virtualization R&D Red Hat Israel

phone: +972-9-7692018 irc: eedri (on #tlv #rhev-dev #rhev-integ)

-- Eyal Edri Associate Manager RHEV DevOps EMEA ENG Virtualization R&D Red Hat Israel phone: +972-9-7692018 irc: eedri (on #tlv #rhev-dev #rhev-integ)