Re: Permissions on stable branches
I can abandon, I cannot remove reviewers and I was able to do so till not long ago On Aug 26, 2015 19:38, David Caro <dcaro@redhat.com> wrote:
I see you in the group that has right to abandon on those branches:
https://gerrit.ovirt.org/#/admin/groups/63,members
can you pass me the account id you are using? (on the upper right corner, hit your name -> settings)
On 08/26, Tal Nisan wrote:
ovirt-engine-3.6 ovirt-engine-3.5
On Aug 26, 2015 19:07, David Caro <dcaro@redhat.com> wrote:
What are your branches?
On 08/26, Tal Nisan wrote:
Just noticed that I now don't have the ability to remove reviews in my branches, can someone have a look why it changed?
On 08/20/2015 11:34 AM, David Caro wrote:
On 08/20, Tal Nisan wrote:
It seems that I can abandon 3.6 patches now as well, are you sure I need to be on that group? Nop, you are right, just missed to see that 6 was included in the regexp:
^refs/heads/ovirt-engine-3\.[56]([^-].*)?$
On 08/20/2015 11:19 AM, David Caro wrote: >On 08/19, Tal Nisan wrote: >>Hi all, >>In order to better manage the branches I maintain (ovirt-engine 3.5 & 3.6) >>I'd like to have permissions to abandon patches and change patch topics, can >>you please give me those? >I've given you those right for 3.5 branch, but on 3.6 you have to be in the >ovirt-engine-abandon group, and I'll need ack from itamar or oved for that: > >https://gerrit.ovirt.org/#/admin/groups/70,members >
-- David Caro
Red Hat S.L. Continuous Integration Engineer - EMEA ENG Virtualization R&D
Tel.: +420 532 294 605 Email: dcaro@redhat.com Web: www.redhat.com RHT Global #: 82-62605
-- David Caro
Red Hat S.L. Continuous Integration Engineer - EMEA ENG Virtualization R&D
Tel.: +420 532 294 605 Email: dcaro@redhat.com Web: www.redhat.com RHT Global #: 82-62605
--Pk6IbRAofICFmK5e Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable I'm not aware of any changes, maybe you got a duplicated account, that's wh= y I ask for the account id On 08/26, Tal Nisan wrote:
I can abandon, I cannot remove reviewers and I was able to do so till not= long ago =20 On Aug 26, 2015 19:38, David Caro <dcaro@redhat.com> wrote:
I see you in the group that has right to abandon on those=A0 branches:=
=20
https://gerrit.ovirt.org/#/admin/groups/63,members=20
can you pass me the account id you are using? (on the upper right corne=
r, hit=20
your name -> settings)=20
On 08/26, Tal Nisan wrote:=20
ovirt-engine-3.6=20 ovirt-engine-3.5=20 =20 On Aug 26, 2015 19:07, David Caro <dcaro@redhat.com> wrote:=20
=20 =20 What are your branches?=20 =20 On 08/26, Tal Nisan wrote:=20
Just noticed that I now don't have the ability to remove reviews = in my=20 branches, can someone have a look why it changed?=20 =20 On 08/20/2015 11:34 AM, David Caro wrote:=20
On 08/20, Tal Nisan wrote:=20 >It seems that I can abandon 3.6 patches now as well, are you su= re I need to=20 >be on that group?=20 Nop, you are right, just missed to see that 6 was included in th= e regexp:=20 =20 ^refs/heads/ovirt-engine-3\.[56]([^-].*)?$=20 =20 >On 08/20/2015 11:19 AM, David Caro wrote:=20 >>On 08/19, Tal Nisan wrote:=20 >>>Hi all,=20 >>>In order to better manage the branches I maintain (ovirt-engi= ne 3.5 & 3.6)=20 >>>I'd like to have permissions to abandon patches and change pa= tch topics, can=20 >>>you please give me those?=20 >>I've given you those right for 3.5 branch, but on 3.6 you have= to be in the=20 >>ovirt-engine-abandon group, and I'll need ack from itamar or o= ved for that:=20 >>=20 >>https://gerrit.ovirt.org/#/admin/groups/70,members=20 >>=20 =20 =20 --=20 David Caro=20 =20 Red Hat S.L.=20 Continuous Integration Engineer - EMEA ENG Virtualization R&D=20 =20 Tel.: +420 532 294 605=20 Email: dcaro@redhat.com=20 Web: www.redhat.com=20 RHT Global #: 82-62605=20
--=20 David Caro=20
Red Hat S.L.=20 Continuous Integration Engineer - EMEA ENG Virtualization R&D=20
Tel.: +420 532 294 605=20 Email: dcaro@redhat.com=20 Web: www.redhat.com=20 RHT Global #: 82-62605=20
--=20 David Caro Red Hat S.L. Continuous Integration Engineer - EMEA ENG Virtualization R&D Tel.: +420 532 294 605 Email: dcaro@redhat.com Web: www.redhat.com RHT Global #: 82-62605 --Pk6IbRAofICFmK5e Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJV3fCWAAoJEEBxx+HSYmnDrioH/ia33PLvXAVTeopunZwtQAyn JFx1iEW4tMlo/xPr8mORHxk3hqTo/qqSuTZrkE4YAkvdSOdUUoLDMPL8DcJCvVH2 7g3NTuZjVAk/o+IK56hYKKHgrtPGy6gMyn25EtT2Si6kMDkXIe/i9hQ9ZPvwIS5G NaHCVxhoyzZXEXGS06tku9TpELgBoF9vsaWlOB3gHBqYrV1IcEYdQ/OY6mInT0eo FEN6/EzzevcKPtV1YD1GxlKNn2uUrWDBJQxLf1dtFzwsqLFkLEyzPz0COmNk63cZ YQ14qx/qW+OivsmH8XJVCgGc0+NLajIZDSGsICdi3UDJwmzC7gxkaZwZUyUkYx4= =87cK -----END PGP SIGNATURE----- --Pk6IbRAofICFmK5e--
User id is 10070, I should be able to remove reviewers from patches (mostly the ci automated users for that matter) On 08/26/2015 08:00 PM, David Caro wrote:
I'm not aware of any changes, maybe you got a duplicated account, that's why I ask for the account id
On 08/26, Tal Nisan wrote:
I can abandon, I cannot remove reviewers and I was able to do so till not long ago
On Aug 26, 2015 19:38, David Caro <dcaro@redhat.com> wrote:
I see you in the group that has right to abandon on those branches:
https://gerrit.ovirt.org/#/admin/groups/63,members
can you pass me the account id you are using? (on the upper right corner, hit your name -> settings)
On 08/26, Tal Nisan wrote:
ovirt-engine-3.6 ovirt-engine-3.5
On Aug 26, 2015 19:07, David Caro <dcaro@redhat.com> wrote:
What are your branches?
On 08/26, Tal Nisan wrote:
Just noticed that I now don't have the ability to remove reviews in my branches, can someone have a look why it changed?
On 08/20/2015 11:34 AM, David Caro wrote: > On 08/20, Tal Nisan wrote: >> It seems that I can abandon 3.6 patches now as well, are you sure I need to >> be on that group? > Nop, you are right, just missed to see that 6 was included in the regexp: > > ^refs/heads/ovirt-engine-3\.[56]([^-].*)?$ > >> On 08/20/2015 11:19 AM, David Caro wrote: >>> On 08/19, Tal Nisan wrote: >>>> Hi all, >>>> In order to better manage the branches I maintain (ovirt-engine 3.5 & 3.6) >>>> I'd like to have permissions to abandon patches and change patch topics, can >>>> you please give me those? >>> I've given you those right for 3.5 branch, but on 3.6 you have to be in the >>> ovirt-engine-abandon group, and I'll need ack from itamar or oved for that: >>> >>> https://gerrit.ovirt.org/#/admin/groups/70,members >>> -- David Caro
Red Hat S.L. Continuous Integration Engineer - EMEA ENG Virtualization R&D
Tel.: +420 532 294 605 Email: dcaro@redhat.com Web: www.redhat.com RHT Global #: 82-62605
-- David Caro
Red Hat S.L. Continuous Integration Engineer - EMEA ENG Virtualization R&D
Tel.: +420 532 294 605 Email: dcaro@redhat.com Web: www.redhat.com RHT Global #: 82-62605
--vni90+aGYgRvsTuO Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 08/26, Tal Nisan wrote:
User id is 10070, I should be able to remove reviewers from patches (most= ly the ci automated users for that matter)
I'll need the patch to check it in more detail, that account id is ok. You can override any automated user (CI flag) by just setting it to +1 yourself, that's the preferred way of overriding it as it keeps the automat= ed score and helps us to debug it latter. If you are trying to override another flag, that might be the hooks check, = you should not, if they misbehave they should be fixed, so please send us the patch. If it's not the CI flag, and it's not the gerrit-hooks, then there's an iss= ue on some of the jobs, so it still needs debugging, probably disabling the jo= b. cheers
=20 On 08/26/2015 08:00 PM, David Caro wrote:
I'm not aware of any changes, maybe you got a duplicated account, that's= why I ask for the account id
On 08/26, Tal Nisan wrote:
I can abandon, I cannot remove reviewers and I was able to do so till n= ot long ago
On Aug 26, 2015 19:38, David Caro <dcaro@redhat.com> wrote:
I see you in the group that has right to abandon on those branches:
https://gerrit.ovirt.org/#/admin/groups/63,members
can you pass me the account id you are using? (on the upper right corn=
er, hit
your name -> settings)
On 08/26, Tal Nisan wrote:
ovirt-engine-3.6 ovirt-engine-3.5
On Aug 26, 2015 19:07, David Caro <dcaro@redhat.com> wrote:
What are your branches?
On 08/26, Tal Nisan wrote: >Just noticed that I now don't have the ability to remove reviews in=
my
>branches, can someone have a look why it changed? > >On 08/20/2015 11:34 AM, David Caro wrote: >>On 08/20, Tal Nisan wrote: >>>It seems that I can abandon 3.6 patches now as well, are you sure= I need to >>>be on that group? >>Nop, you are right, just missed to see that 6 was included in the = regexp: >> >>^refs/heads/ovirt-engine-3\.[56]([^-].*)?$ >> >>>On 08/20/2015 11:19 AM, David Caro wrote: >>>>On 08/19, Tal Nisan wrote: >>>>>Hi all, >>>>>In order to better manage the branches I maintain (ovirt-engine= 3.5 & 3.6) >>>>>I'd like to have permissions to abandon patches and change patc= h topics, can >>>>>you please give me those? >>>>I've given you those right for 3.5 branch, but on 3.6 you have t= o be in the >>>>ovirt-engine-abandon group, and I'll need ack from itamar or ove= d for that: >>>> >>>>https://gerrit.ovirt.org/#/admin/groups/70,members >>>> --=20 David Caro
Red Hat S.L. Continuous Integration Engineer - EMEA ENG Virtualization R&D
Tel.: +420 532 294 605 Email: dcaro@redhat.com Web: www.redhat.com RHT Global #: 82-62605 --=20 David Caro
Red Hat S.L. Continuous Integration Engineer - EMEA ENG Virtualization R&D
Tel.: +420 532 294 605 Email: dcaro@redhat.com Web: www.redhat.com RHT Global #: 82-62605 =20
--=20 David Caro Red Hat S.L. Continuous Integration Engineer - EMEA ENG Virtualization R&D Tel.: +420 532 294 605 Email: dcaro@redhat.com Web: www.redhat.com RHT Global #: 82-62605 --vni90+aGYgRvsTuO Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJV3fuWAAoJEEBxx+HSYmnDxDkH/1xs1JDv4PmJkkJHBHViqz+S 3CrhuHJ1FxCP5AfZ6p2O5AEsO0nAXp60YHvyNhmwdcwFfQmvnkb446jdp2YTZVjE lcj7mVvViLeSnkQB0J7CekZ4Fbe/Y7wOOil8L1uCvM+C8meV9E1GE2bWZCC3TxJU MQWrqxnAYQEK9jP79ufYNZarspHVYDravQz6/CWwN+iuisRMZfqbsQD8D1aIXpmq QF4k07QKYcwPSF+EKDEHaNmVnasBO8W5PAg+fH3hSK+MnG6yALi2EyxBmJhjI02a DqiDz2AbUKGau7PSVAiL4ME6lJhYuEB/OQEpUMBFlrLbLwya5RSm2yrxV5VzP78= =OAHL -----END PGP SIGNATURE----- --vni90+aGYgRvsTuO--
This is the patch I was talking about: https://gerrit.ovirt.org/#/c/45376/ I cannot remove the Jenkins CI reviewer On 08/26/2015 08:47 PM, David Caro wrote:
On 08/26, Tal Nisan wrote:
User id is 10070, I should be able to remove reviewers from patches (mostly the ci automated users for that matter) I'll need the patch to check it in more detail, that account id is ok.
You can override any automated user (CI flag) by just setting it to +1 yourself, that's the preferred way of overriding it as it keeps the automated score and helps us to debug it latter.
If you are trying to override another flag, that might be the hooks check, you should not, if they misbehave they should be fixed, so please send us the patch.
If it's not the CI flag, and it's not the gerrit-hooks, then there's an issue on some of the jobs, so it still needs debugging, probably disabling the job.
cheers
On 08/26/2015 08:00 PM, David Caro wrote:
I'm not aware of any changes, maybe you got a duplicated account, that's why I ask for the account id
On 08/26, Tal Nisan wrote:
I can abandon, I cannot remove reviewers and I was able to do so till not long ago
On Aug 26, 2015 19:38, David Caro <dcaro@redhat.com> wrote:
I see you in the group that has right to abandon on those branches:
https://gerrit.ovirt.org/#/admin/groups/63,members
can you pass me the account id you are using? (on the upper right corner, hit your name -> settings)
On 08/26, Tal Nisan wrote:
ovirt-engine-3.6 ovirt-engine-3.5
On Aug 26, 2015 19:07, David Caro <dcaro@redhat.com> wrote: > What are your branches? > > On 08/26, Tal Nisan wrote: >> Just noticed that I now don't have the ability to remove reviews in my >> branches, can someone have a look why it changed? >> >> On 08/20/2015 11:34 AM, David Caro wrote: >>> On 08/20, Tal Nisan wrote: >>>> It seems that I can abandon 3.6 patches now as well, are you sure I need to >>>> be on that group? >>> Nop, you are right, just missed to see that 6 was included in the regexp: >>> >>> ^refs/heads/ovirt-engine-3\.[56]([^-].*)?$ >>> >>>> On 08/20/2015 11:19 AM, David Caro wrote: >>>>> On 08/19, Tal Nisan wrote: >>>>>> Hi all, >>>>>> In order to better manage the branches I maintain (ovirt-engine 3.5 & 3.6) >>>>>> I'd like to have permissions to abandon patches and change patch topics, can >>>>>> you please give me those? >>>>> I've given you those right for 3.5 branch, but on 3.6 you have to be in the >>>>> ovirt-engine-abandon group, and I'll need ack from itamar or oved for that: >>>>> >>>>> https://gerrit.ovirt.org/#/admin/groups/70,members >>>>> > -- > David Caro > > Red Hat S.L. > Continuous Integration Engineer - EMEA ENG Virtualization R&D > > Tel.: +420 532 294 605 > Email: dcaro@redhat.com > Web: www.redhat.com > RHT Global #: 82-62605 -- David Caro
Red Hat S.L. Continuous Integration Engineer - EMEA ENG Virtualization R&D
Tel.: +420 532 294 605 Email: dcaro@redhat.com Web: www.redhat.com RHT Global #: 82-62605
It seems that log in and log out solved the problem, thanks for the help David! On 08/26/2015 08:47 PM, David Caro wrote:
On 08/26, Tal Nisan wrote:
User id is 10070, I should be able to remove reviewers from patches (mostly the ci automated users for that matter) I'll need the patch to check it in more detail, that account id is ok.
You can override any automated user (CI flag) by just setting it to +1 yourself, that's the preferred way of overriding it as it keeps the automated score and helps us to debug it latter.
If you are trying to override another flag, that might be the hooks check, you should not, if they misbehave they should be fixed, so please send us the patch.
If it's not the CI flag, and it's not the gerrit-hooks, then there's an issue on some of the jobs, so it still needs debugging, probably disabling the job.
cheers
On 08/26/2015 08:00 PM, David Caro wrote:
I'm not aware of any changes, maybe you got a duplicated account, that's why I ask for the account id
On 08/26, Tal Nisan wrote:
I can abandon, I cannot remove reviewers and I was able to do so till not long ago
On Aug 26, 2015 19:38, David Caro <dcaro@redhat.com> wrote:
I see you in the group that has right to abandon on those branches:
https://gerrit.ovirt.org/#/admin/groups/63,members
can you pass me the account id you are using? (on the upper right corner, hit your name -> settings)
On 08/26, Tal Nisan wrote:
ovirt-engine-3.6 ovirt-engine-3.5
On Aug 26, 2015 19:07, David Caro <dcaro@redhat.com> wrote: > What are your branches? > > On 08/26, Tal Nisan wrote: >> Just noticed that I now don't have the ability to remove reviews in my >> branches, can someone have a look why it changed? >> >> On 08/20/2015 11:34 AM, David Caro wrote: >>> On 08/20, Tal Nisan wrote: >>>> It seems that I can abandon 3.6 patches now as well, are you sure I need to >>>> be on that group? >>> Nop, you are right, just missed to see that 6 was included in the regexp: >>> >>> ^refs/heads/ovirt-engine-3\.[56]([^-].*)?$ >>> >>>> On 08/20/2015 11:19 AM, David Caro wrote: >>>>> On 08/19, Tal Nisan wrote: >>>>>> Hi all, >>>>>> In order to better manage the branches I maintain (ovirt-engine 3.5 & 3.6) >>>>>> I'd like to have permissions to abandon patches and change patch topics, can >>>>>> you please give me those? >>>>> I've given you those right for 3.5 branch, but on 3.6 you have to be in the >>>>> ovirt-engine-abandon group, and I'll need ack from itamar or oved for that: >>>>> >>>>> https://gerrit.ovirt.org/#/admin/groups/70,members >>>>> > -- > David Caro > > Red Hat S.L. > Continuous Integration Engineer - EMEA ENG Virtualization R&D > > Tel.: +420 532 294 605 > Email: dcaro@redhat.com > Web: www.redhat.com > RHT Global #: 82-62605 -- David Caro
Red Hat S.L. Continuous Integration Engineer - EMEA ENG Virtualization R&D
Tel.: +420 532 294 605 Email: dcaro@redhat.com Web: www.redhat.com RHT Global #: 82-62605
participants (2)
-
David Caro -
Tal Nisan