3:16 a.m.
How would I get this plugin added to ovirt-engine-dashboard and
ovirt-engine-node* ?
And then how would I configure it? (Add myself as a default, at least)
---------- Forwarded message ----------
From: Roy Golan <rgolan(a)redhat.com>
Date: Mon, Jun 19, 2017 at 7:17 AM
Subject: Re: [ovirt-devel] [ENGINE][ACTION_NEEDED] - default maintainers,
per path
To: devel <devel(a)ovirt.org>
The patch is now merged and the it should start working immediately. For
anyone who is listed as a default reviewer I suggest to test it with a test
patch by some other submitter. (except for those who used groups of course)
Thanks everyone for the cooperation on this.
On Mon, May 29, 2017 at 2:24 PM Roy Golan <rgolan(a)redhat.com> wrote:
Hi all,
Some time ago the infra team enabled *gerrit default reviewer plugin*
which you probably noticed if you logged in to gerrit.
What we can do is for example set the stable branch maintainers per branch
automatically:
[filter "branch:ovirt-engine-4.1"]
reviewer = stableBranchMaintainersGroup
Put people based on path:
[filter "branch:master file:^frontend/.*"]
reviewer = j.r.r.t(a)shire.me
*Action Needed:*
Nominate yourself, or others, by amending this patch online [1]. Once this
patch is fully acked and agreed we will merge it. If something can't get
consensus we will defer it from the patch till maintainers agree.
[1] https://gerrit.ovirt.org/#/c/77488/
_______________________________________________
Devel mailing list
Devel(a)ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel
--
GREG SHEREMETA
SENIOR SOFTWARE ENGINEER - TEAM LEAD - RHV UX
Red Hat NA
<https://www.redhat.com/>
gshereme(a)redhat.com IRC: gshereme
<https://red.ht/sig>
4:09 p.m.
I believe you just need to update the 'reviewers' setting on the project.
If you go to https://gerrit.ovirt.org/#/x/reviewers/p/ovirt-engine-dashboard
you should be able to add emails and paths to track.
On Tue, May 1, 2018 at 9:16 PM, Greg Sheremeta <gshereme(a)redhat.com> wrote:
How would I get this plugin added to ovirt-engine-dashboard and
ovirt-engine-node* ?
And then how would I configure it? (Add myself as a default, at least)
---------- Forwarded message ----------
From: Roy Golan <rgolan(a)redhat.com>
Date: Mon, Jun 19, 2017 at 7:17 AM
Subject: Re: [ovirt-devel] [ENGINE][ACTION_NEEDED] - default maintainers,
per path
To: devel <devel(a)ovirt.org>
The patch is now merged and the it should start working immediately. For
anyone who is listed as a default reviewer I suggest to test it with a test
patch by some other submitter. (except for those who used groups of course)
Thanks everyone for the cooperation on this.
On Mon, May 29, 2017 at 2:24 PM Roy Golan <rgolan(a)redhat.com> wrote:
> Hi all,
>
> Some time ago the infra team enabled *gerrit default reviewer plugin*
> which you probably noticed if you logged in to gerrit.
>
> What we can do is for example set the stable branch maintainers per
> branch automatically:
>
> [filter "branch:ovirt-engine-4.1"]
> reviewer = stableBranchMaintainersGroup
>
> Put people based on path:
>
> [filter "branch:master file:^frontend/.*"]
> reviewer = j.r.r.t(a)shire.me
>
>
>
> *Action Needed:*
> Nominate yourself, or others, by amending this patch online [1]. Once
> this patch is fully acked and agreed we will merge it. If something can't
> get consensus we will defer it from the patch till maintainers agree.
>
> [1] https://gerrit.ovirt.org/#/c/77488/
>
>
>
>
>
_______________________________________________
Devel mailing list
Devel(a)ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel
--
GREG SHEREMETA
SENIOR SOFTWARE ENGINEER - TEAM LEAD - RHV UX
Red Hat NA
<https://www.redhat.com/>
gshereme(a)redhat.com IRC: gshereme
<https://red.ht/sig>
_______________________________________________
Infra mailing list
Infra(a)ovirt.org
http://lists.ovirt.org/mailman/listinfo/infra
--
Eyal edri
MANAGER
RHV DevOps
EMEA VIRTUALIZATION R&D
Red Hat EMEA <https://www.redhat.com/>
<https://red.ht/sig> TRIED. TESTED. TRUSTED. <https://redhat.com/trusted>
phone: +972-9-7692018
irc: eedri (on #tlv #rhev-dev #rhev-integ)
4:35 p.m.
(adding devel because this might be interesting for others).
On 1 May 2018 at 21:16, Greg Sheremeta <gshereme(a)redhat.com> wrote:
How would I get this plugin added to ovirt-engine-dashboard and
ovirt-engine-node* ?
Its already available for all projects in gerrit.ovirt.org.
And then how would I configure it? (Add myself as a default, at
least)
Two ways:
With the GUI:
-----------------
In Gerrit UI go to:
Admin -> Projects -> (Old UI) -> (Your project) -> Reviewers (from top bar)
Fill in filter (A file glob pattern - can be '*') and reviewer (An email
address ora gerrit group ) and click "Add".
Don't forget to switch back to new UI from the bottom right link.
From the command line
-------------------------------
In a Git clone of the relevant project do:
# git fetch origin refs/meta/config:meta-config
# git checkout meta-config
Then you can edit the 'reviewers.config' file (Make it if it isn't there)
and put in something like the following:
[filter "*"]
reviewer = jenkins-maintainers
reviewer = dron(a)redhat.com
Once you're done with it commit the change and push it with:
# git push -u origin meta-config refs/meta/config
Since we have '-u' there, the next time around you change the
'meta-config'
branch you can just do:
# git push -u origin
And that's about it.
One thing to note - every project has a '<project-name>-maintainers' group,
so its useful to add it it default.
---------- Forwarded message ----------
From: Roy Golan <rgolan(a)redhat.com>
Date: Mon, Jun 19, 2017 at 7:17 AM
Subject: Re: [ovirt-devel] [ENGINE][ACTION_NEEDED] - default maintainers,
per path
To: devel <devel(a)ovirt.org>
The patch is now merged and the it should start working immediately. For
anyone who is listed as a default reviewer I suggest to test it with a test
patch by some other submitter. (except for those who used groups of course)
Thanks everyone for the cooperation on this.
On Mon, May 29, 2017 at 2:24 PM Roy Golan <rgolan(a)redhat.com> wrote:
> Hi all,
>
> Some time ago the infra team enabled *gerrit default reviewer plugin*
> which you probably noticed if you logged in to gerrit.
>
> What we can do is for example set the stable branch maintainers per
> branch automatically:
>
> [filter "branch:ovirt-engine-4.1"]
> reviewer = stableBranchMaintainersGroup
>
> Put people based on path:
>
> [filter "branch:master file:^frontend/.*"]
> reviewer = j.r.r.t(a)shire.me
>
>
>
> *Action Needed:*
> Nominate yourself, or others, by amending this patch online [1]. Once
> this patch is fully acked and agreed we will merge it. If something can't
> get consensus we will defer it from the patch till maintainers agree.
>
> [1] https://gerrit.ovirt.org/#/c/77488/
>
>
>
>
>
_______________________________________________
Devel mailing list
Devel(a)ovirt.org
http://lists.ovirt.org/mailman/listinfo/devel
--
GREG SHEREMETA
SENIOR SOFTWARE ENGINEER - TEAM LEAD - RHV UX
Red Hat NA
<https://www.redhat.com/>
gshereme(a)redhat.com IRC: gshereme
<https://red.ht/sig>
_______________________________________________
Infra mailing list
Infra(a)ovirt.org
http://lists.ovirt.org/mailman/listinfo/infra
--
Barak Korren
RHV DevOps team , RHCE, RHCi
Red Hat EMEA
redhat.com | TRIED. TESTED. TRUSTED. | redhat.com/trusted
2186
days inactive
2187
days old
2 comments
3 participants
participants (3)
-
Barak Korren -
Eyal Edri -
Greg Sheremeta