Re: [Users] [GSOC][Gerrit] add potential reviewers - questions

From: "Eyal Edri" <eedri(a)redhat.com&gt; To: "Tomasz Kołek" <tomasz-kolek(a)o2.pl&gt; Cc: users(a)ovirt.org, "infra" <infra(a)ovirt.org&gt; Sent: Tuesday, March 11, 2014 4:37:22 PM Subject: Re: [Users] [GSOC][Gerrit] add potential reviewers - questions ----- Original Message ----- > From: "Tomasz Kołek" <tomasz-kolek(a)o2.pl&gt; > To: users(a)ovirt.org > Sent: Monday, March 10, 2014 9:56:28 PM > Subject: [Users] [GSOC][Gerrit] add potential reviewers - questions > > > > Hi > > I'd like to contribute (within GSOC) in idea: Gerrit add potential > reviewers. > > Maybe at first I’ll introduce myself. > I'm Tomek, student from Poland. I study Computer Science at University of > Wroclaw. The next year will be last year of my first degree study, I hope. > As a python programmer I'm working since one year at Nokia Solutions and > Networks (don't worry I intend to change my job to another or to > participation at GSOC). Every day at work and school I'm using version > control system (Git and SVN). At work we were using to Gerrit as a review > system but currently we're using JIRA to report review statuses. > I love spend my free time in mountains (mainly polish - Tatras mountains). > That's all about me. > > I've got a few questions about project description. > Please tell me if my problem's understanding is good or not. > We need to add a few flags/methods to git review module. This flags should > allow to add potential reviewers in gerrit. > So: > Let's assume that we've got special flags for this operations. What's next? > 1. In gerrit system we need to add special place for potential reviewers? > 2. Potential reviewers should agree that they want to review? > 3. We can have more than one accepted reviewer? Hi Tomasz, I'm not sure i understood exactly what you mean by 'potential reviewers'. do want gerrit (hook?) to automatically add reviewers to a patch according to the code sent? so in fact you'll have a place somewhere for mapping code & specific developers? cause if you mean by adding reviewers to a patch, that's easily done by just clicking the '+' sign on each patch. those reviewers should have logged in at least once to gerrit.ovirt.org in order to be in the list of potential viewers, and they don't require any special permissions to review with +1/-1 any patch sent. you can add as many reviewers as you want to a patch. does that answer your question? Eyal. > > I know above questions might seem chaotic but I think answers allow me to > better understanding Yours needments > > Best regards > Tomasz Kolek > > _______________________________________________ > Users mailing list > Users(a)ovirt.org > http://lists.ovirt.org/mailman/listinfo/users > _______________________________________________ Users mailing list Users(a)ovirt.org http://lists.ovirt.org/mailman/listinfo/users