6:45 p.m.
Il 12/06/2014 17:26, René Koch ha scritto:
Hi Sandro,
Sadly I don't have time to work on one of these bugs, but I have a general question
on how contributing to oVirt works. [2] explains in detail how to
push code to gerrit.
As I wanted to start contributing to oVirt I started with the easiest way by extending
the list of operating systems. So I created a bug for this
(1101219), pushed to code to gerrit (referenced to this bug id) and Jenkins build job was
successful. So I did everything mentioned in [2] - but what
now?
Shall I just wait and see what happens?
Should I post to ovirt-devel that someone will review the code?
Good questions. Posting to ovirt-devel will help in having people to review your patches.
I did "git blame" on the file you changed in http://gerrit.ovirt.org/28113 and
added those who already changed that file for reviewing the patch.
Who decides which oVirt version will include this code or if this
code will be included or needs adaptions (I only know that a certain score in gerrit
is required and some developers are allowed to rate a commit)?
I'm aware that my commit isn't fancy at all and there's no need for any
priority, but just want to know what's the right workflow in case I have more
time to work on some bugs...
I guess these questions could be interesting for users (basically for users who are not
familiar with a professional development setup/workflow
including gerrit like me) who want to work on the bugs in june edition as well...
I agree. You did everything right since now:
- opened a bz
- pushed a patch referencing it
- added the gerrit reference to bugzilla
what you just miss is adding other people for reviewing the patch.
Oved Ourfali already set whiteboard to virt, so this is a virt team patch and virt team
maintainers will merge your patch once it's ready.
Itamar Heim also reviewd the bug you pushed and set target release to 3.5.0.
Now you just need to wait for other developers to review the patch and maintainer to merge
it.
If there will be comments on your patch a new version of the patch may be needed (just
amend the patch and push again with the same Change-ID)
and it will be reviewed again.
you can find more info on gerrit here:
https://gerrit-review.googlesource.com/Documentation
Thanks,
René
On 06/12/2014 04:11 PM, Sandro Bonazzola wrote:
> Hi,
> have you got some free time and do you want to get involved in oVirt
integration?
> After the success of first edition we're now proposing this again.
> Here are a couple of bugs you can hopefully fix in less that one day or you can just
try to reproduce providing info:
>
> Bug 1091651 - Misleading error message when first host cannot be reached during
hosted-engine deployment
> Bug 1080823 - [RFE] make override of iptables configurable when using hosted-engine
> Bug 1065350 - hosted-engine should prompt a question at the user when the host was
already a host in the engine
> Bug 1097635 - ovirt-hosted-engine-setup fails with Modules libvirt contains invalid
configuration
>
> Is this the first time you try to contribute to oVirt project?
> You can start from here [1][2]!
>
> [1] http://www.ovirt.org/Develop
> [2] http://www.ovirt.org/Working_with_oVirt_Gerrit
>
>
--
Sandro Bonazzola
Better technology. Faster innovation. Powered by community collaboration.
See how it works at redhat.com
6:58 p.m.
New subject: Get involved in oVirt integration! June edition
On 06/12/2014 11:45 AM, Sandro Bonazzola wrote:
Itamar Heim also reviewd the bug you pushed and set target release to
3.5.0.
for oVirt bugs, i set all 'bugs' (not features) to the next version as
kind of default target. they can be moved later for either future, or to
stable versions as well if needed.
3817
days inactive
3817
days old
1 comments
2 participants
participants (2)
-
Itamar Heim -
Sandro Bonazzola