Re: [Users] RPM spec file for virtio-win rpm
On 11/05/2012 08:52 AM, Daniel Rowe wrote:
Hi
I updated the rpm spec here:
https://github.com/fasrc/virtio-win/blob/master/virtio-win.spec
For the latest iso from here:
http://alt.fedoraproject.org/pub/alt/virtio-win/latest/images/bin/
Just in case anyone needs it.
Thanks for it. Just a side note to that. It is quite
common to update
the %changelog section about what has been changed.
It would be nice if you would so so as well.
Instead of using %{buildroot}/usr/share/virtio-win you would use
%{buildroot}%{_datadir}/virtio-win
Also it is a good practise to use install instead of mkdir and cp
And at least for current fedora release you must no longer use rm -rf
%{buildroot}
Thanks for your work :-)
Regards
Daniel Rowe
--
Regards,
Vinzenz Feenstra
Senior Software Engineer
IRC: vfeenstr or evilissimo
Red Hat Czech Republic