Re: [Users] Excessive syslog logging from vdsm/sampling.py

From: "Ayal Baron" <abaron(a)redhat.com&gt; To: "Nir Soffer" <nsoffer(a)redhat.com&gt; Cc: "Sander Grendelman" <sander(a)grendelman.com&gt;, "Michal Skrivanek" <mskrivan(a)redhat.com&gt;, users(a)ovirt.org Sent: Wednesday, December 18, 2013 1:27:36 PM Subject: Re: [Users] Excessive syslog logging from vdsm/sampling.py ----- Original Message ----- > ----- Original Message ----- > > From: "Sander Grendelman" <sander(a)grendelman.com&gt; > > To: "Itamar Heim" <iheim(a)redhat.com&gt; > > Cc: users(a)ovirt.org, "Michal Skrivanek" <mskrivan(a)redhat.com&gt; > > Sent: Wednesday, December 18, 2013 11:40:36 AM > > Subject: Re: [Users] Excessive syslog logging from vdsm/sampling.py > > > > - vdsm-4.13.0-11.el6.x86_64 > > - FC storage domain > > - no floppies attached to VMs as far as I know (any way to test this?) > > > > On Wed, Dec 18, 2013 at 10:21 AM, Itamar Heim <iheim(a)redhat.com&gt; wrote: > > > On 12/17/2013 09:04 AM, Sander Grendelman wrote: > > >> > > >> Any ideas on this one? > > >> > > >> On Mon, Dec 16, 2013 at 11:31 AM, Sander Grendelman > > >> <sander(a)grendelman.com&gt; wrote: > > >>> > > >>> The syslog on my ovirt nodes is constantly logging errors from > > >>> sampling.py: > > >>> > > >>> Dec 16 11:22:47 gnkvm01 vdsm vm.Vm ERROR > > >>> vmId=`66aa5555-2299-4d93-931d-b7a2e421b7e9`::Stats function failed: > > >>> <AdvancedStatsFunction _highWrite at 0x1733dc0>#012Traceback (most > > >>> recent call last):#012 File "/usr/share/vdsm/sampling.py", line 351, > > >>> in collect#012 statsFunction()#012 File > > >>> "/usr/share/vdsm/sampling.py", line 226, in __call__#012 retValue > > >>> = > > >>> self._function(*args, **kwargs)#012 File "/usr/share/vdsm/vm.py", > > >>> line 509, in _highWrite#012 if not vmDrive.blockDev or > > >>> vmDrive.format != 'cow':#012AttributeError: 'Drive' object has no > > >>> attribute 'format' > > This is not spam, but a real error in the code: > > Dec 16 11:22:47 gnkvm01 vdsm vm.Vm ERROR > vmId=`66aa5555-2299-4d93-931d-b7a2e421b7e9`::Stats function failed: > <AdvancedStatsFunction _highWrite at 0x1733dc0>#012Traceback (most > recent call last): > File "/usr/share/vdsm/sampling.py", line 351, in > collectstatsFunction() > File "/usr/share/vdsm/sampling.py", line 226, in __call__ > retValue = self._function(*args, **kwargs) > File "/usr/share/vdsm/vm.py", line 509, in _highWrite > if not vmDrive.blockDev or vmDrive.format != 'cow': > AttributeError: 'Drive' object has no attribute 'format' > > We should check why vmDrive does not have the format attribute in your > case. Probably because this was checked during migration it's a race between migration finish and monitoring checking this. You can see the error repeated in other cases as well (in bugzilla): 988047, 994534