Crap, didn't realize I just had to restart vdsm for the new API.py to take
effect.
Anyway I edited fencing.py and added back the compatibility code, and its
all working for now.
I'm going to work on touch up changes on fence_raritan so that we can get
it submitted into the next release hopefully, all of these other hacks will
become moot at that time.
On Tue, Mar 25, 2014 at 2:08 PM, Dan Kenigsberg <danken(a)redhat.com> wrote:
On Tue, Mar 25, 2014 at 11:37:13AM -0700, David Smith wrote:
> I created fence_raritan.
>
> Unfortunately it looks like fencing.py is where the legacy --option was
> translated to --action. I believe ovirt calls fencing.py as a proxy to
> execute fence_raritan?
>
> The version of fence-agents I pulled from git has the backwards
> compatibility removed;
>
https://lists.fedorahosted.org/pipermail/cluster-commits/2013-February/00...
>
>
> So if I added support for it in fence_raritan I'm not sure it would work
(I
> can try) but also the fence-agents guys probably wouldn't take the
> submission to have it added to future code.
Indeed - I do not expect upstream fence-agents to accept the legacy
option. However, you could backport your own code to el6, and create a
"fence-agents-raritan" rpm from it.
>
> I edited API.py as in
http://gerrit.ovirt.org/#/c/26075/ and re-compiled
> API.py to pyc and pyo files and copied to all my hosts, yet I'm still
> getting an error, so I'm wondering if that change is incomplete or I
missed
> some other step to make this actually work. It's really a bummer
> especially since the default behavior with no action is reboot ;)
I suppose that you have missed something. My don't you place API.py
under /usr/share/vdsm ? And make sure you restart vdsmd, to make the new
code take effect?
>
>
> *Thread-199071::DEBUG::2014-03-25
10:28:10,587::API::1110::vds::(fenceNode)
>
fenceNode(addr=10.105.128.25,port=,agent=raritan,user=admin,passwd=XXXX,action=status,secure=,options=port=/system1/outlet6)*
>
>
> *Thread-199071::DEBUG::2014-03-25
10:28:13,104::API::1136::vds::(fenceNode)
> rc 0 in agent=fence_raritan*
> *ipaddr=10.105.128.25*
> *login=admin*
> *option=status*
> *passwd=XXXX*
> *port=/system1/outlet6 out Success: Rebooted*
> * err Parse error: Ignoring unknown option 'option=status'*
>
>
> On Tue, Mar 25, 2014 at 6:28 AM, Dan Kenigsberg <danken(a)redhat.com>
wrote:
>
> > On Tue, Mar 25, 2014 at 05:46:58AM -0400, Eli Mesika wrote:
> > > AFAIK this is related to
http://gerrit.ovirt.org/#/c/24343/ which
> > changed --option to --action
> > > danken ?
> >
> > I smells very much related.
> > Where is fence_raritan comming from? Could you have the el6 version of
> > it support the legacy --option name?
> >
> > If not, we could consider taking
http://gerrit.ovirt.org/#/c/26075/.
> >
> > Dan.
> >