Re: [Users] [GSOC][Gerrit] add potential reviewers - questions

Hi, Thank You for the answers, these give me basic look at the problem. Is not a problem (from my point of view) to implement a few flags for the command, like: add reviewers --auto --max=5 --using_blame etc, depends only on our requirements. I'm almost sure that good way is automatic way as Eyal mentioned, I know it might make a little mess but will be easier for new contributor. Why almost? Because what with a situation where all of potential reviewers are not interested to review patch? Maybe we should try to find "the most reviewing" people, maybe it will be good way? BR, Tomek -----Original Message----- From: Maor Lipchuk [mailto:mlipchuk@redhat.com] Sent: Tuesday, March 11, 2014 8:40 PM To: Meital Bourvine; Eyal Edri Cc: Tomasz Kołek; users(a)ovirt.org; infra Subject: Re: [Users] [GSOC][Gerrit] add potential reviewers - questions Hi Tomasz, I'm very please to hear that you are interested in the GSOC project, see my answers inline. It's great to see that you know the material pretty well, I'm interested to hear some more ideas and feedbacks. I will start a thread soon (Maybe also schedule a call) once getting more feedbacks from other contributors, so we can brain storm some more and get practical with it. If you have any more questions, please don't hesitate to ask me. thanks, Maor On 03/11/2014 04:53 PM, Meital Bourvine wrote: Adding a plugin to gerrit is an interesting idea although it will require the administrator to add it in the server, and I want that the operation will be more available to any submitter in any project. I think that we can address it in a later phase though. no, since gerrit does not question the reviewer if he wants to be added or not I think we should keep this behaviour as well. although as I see it, the operation of adding the reviewers, will not be completely automatic for the submitter, we should let the submitter of the patch to choose which reviewers he wants to add, very similar to the screen being used when doing a rebase in git. (see attached file add_reviewers.png) Yes, that is correct.