Hi Sven, You can file a bug here for better tracking: https://bugzilla.redhat.com/enter_bug.cgi?product=ovirt ----- Original Message ----- > From: "Sven Kieske" <S.Kieske(a)mittwald.de&gt; > To: users(a)ovirt.org > Sent: Wednesday, October 23, 2013 5:05:56 PM > Subject: [Users] [BUG] vdsm-hooks-qos > > Hi, > > I think I found a spelling bug in: > http://gerrit.ovirt.org/gitweb?p=vdsm.git;a=blob_plain;f=vdsm_hooks/qos/b... > > there are two occasions where "peak" is written as "peek". > > Lines: 30, 35

From: "Dan Kenigsberg" <danken(a)redhat.com&gt; To: "Alissa Bonas" <abonas(a)redhat.com&gt; Cc: users(a)ovirt.org Sent: Thursday, October 24, 2013 12:07:45 PM Subject: Re: [Users] [BUG] vdsm-hooks-qos On Thu, Oct 24, 2013 at 04:38:28AM -0400, Alissa Bonas wrote: > Hi Sven, > > You can file a bug here for better tracking: > https://bugzilla.redhat.com/enter_bug.cgi?product=ovirt > > ----- Original Message ----- > > From: "Sven Kieske" <S.Kieske(a)mittwald.de&gt; > > To: users(a)ovirt.org > > Sent: Wednesday, October 23, 2013 5:05:56 PM > > Subject: [Users] [BUG] vdsm-hooks-qos > > > > Hi, > > > > I think I found a spelling bug in: > > http://gerrit.ovirt.org/gitweb?p=vdsm.git;a=blob_plain;f=vdsm_hooks/qos/b... > > > > there are two occasions where "peak" is written as "peek". > > > > Lines: 30, 35 Thanks for this report. Since the fix is so easy, I am not sure that a new BZ entry is needed. Please note that as of ovirt-3.3, QoS is controllable my the main stream (with NIC profiles) so the hook may not be necessary any longer. Nonetheless, would you review/verify http://gerrit.ovirt.org/20495 Regrads Dan.

Hi, thanks for the quick fix! The code looks good, I still have no gerrit account, maybe I should create one (where and how?)

I'm aware of the 3.3 features, but we still stick with 3.2.3 here. I hope we can give 3.3. another try when 3.3.1. is out, hopefully stable enough! PS: How do you get write access to the wiki?

Because the hook documentation is somewhat incomplete, and I could maybe improve it already.

I also found no docs on how vdsm creates network devices for the vm in libvirt (routed, switched, nat or forward mode etc.). Is there something available I am not aware of? Maybe I just looked in the wrong directions.

From: "Dan Kenigsberg" <danken(a)redhat.com&gt; To: "Sven Kieske" <S.Kieske(a)mittwald.de&gt; Cc: users(a)ovirt.org, doron(a)redhat.com Sent: Friday, October 25, 2013 4:38:50 PM Subject: Re: [Users] [BUG] vdsm-hooks-qos On Fri, Oct 25, 2013 at 10:12:58AM +0000, Sven Kieske wrote: > Hi, > > please keep in mind to provide a sane upgrade path for the people > using vdsm-hook-qos if you deprecate it, thanks! > > Am 24.10.2013 17:24, schrieb Doron Fediuck: > > Dan, > > Is there a way to deprecate this starting 3.3.2 as we have an integrated > > solution? > Well, the hook has some benefits over NIC profiles (you can tweak any parameter of any vnic with no global definitions), so I am guessing that some would like to keep using it. I suppose that we should link to http://www.ovirt.org/Features/Vnic_Profiles from the hook readme, so that people would think twice before starting to use the hook. Dan.