Re: [ovirt-users] [Bug 1319323] New: VLAN ID check for duplicates

30 Mar 2016

      --------------000508050504010509050906
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit

Any one have an idea on how to "hack" or "patch" ovirt so that instead 
of rejecting a new network with duplicate vlan id it would just warn, or 
even just ignore?

On 03/18/2016 01:54 PM, bugzilla@redhat.com wrote:
...
https://bugzilla.redhat.com/show_bug.cgi?id=1319323
Bug ID: 1319323
            Summary: VLAN ID check for duplicates
            Product: ovirt-engine
            Version: 3.3
          Component: RFEs
           Severity: medium
           Assignee: sherold@redhat.com
           Reporter: bill.james@j2.com
         QA Contact: gklein@redhat.com
                 CC: bugs@ovirt.org
         oVirt Team: Network
              Flags: testing_ack?
              Flags: planning_ack?
Description of problem:
Adding new network with vlan tag, ovirt doesn't allow duplicate VLAN IDs.
But it should be allowed, because if you are using multiple interfaces you can
have the same vlan ID as long as they aren't assigned to the same interface on
the hardware node.
Version-Release number of selected component (if applicable):
ovirt-engine-3.6.3.4-1.el7.centos.noarch
How reproducible:
100%
Steps to Reproduce:
1. Just add network with same vlan id as an already added interface.
2.
3.
Actual results:
See email thread labeled "Re: [ovirt-users] multiple NICs VLAN ID conflict".
GUI says vlan already used.
Expected results:
Duplicate VLAN ID should be checked when you are assign network to the hardware
node, not when creating the interface.
Additional info:
Trying to work around this with vdsm hooks in before_network_setup,
after_get_caps and after_get_stats is very difficult to get it to work right.
(see email thread)
Yaniv Kaul <mailto:ykaul@redhat.com> 2016-03-20 03:12:24 EDT

Perhaps only WARN.

--------------000508050504010509050906
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
  <head>
    <meta content="text/html; charset=utf-8" http-equiv="Content-Type">
  </head>
  <body text="#000000" bgcolor="#FFFFFF">
    Any one have an idea on how to "hack" or "patch" ovirt so that
    instead of rejecting a new network with duplicate vlan id it would
    just warn, or even just ignore?<br>
    <br>
    <br>
    <div class="moz-cite-prefix">On 03/18/2016 01:54 PM,
      <a class="moz-txt-link-abbreviated" href="mailto:bugzilla@redhat.com">bugzilla@redhat.com</a> wrote:<br>
    </div>
    <blockquote cite="mid:bug-1319323-393952@bugzilla.redhat.com"
      type="cite">
      <pre wrap=""><a class="moz-txt-link-freetext" href="https://bugzilla.redhat.com/show_bug.cgi?id=1319323">https://bugzilla.redhat.com/show_bug.cgi?id=1319323</a>

            Bug ID: 1319323
           Summary: VLAN ID check for duplicates
           Product: ovirt-engine
           Version: 3.3
         Component: RFEs
          Severity: medium
          Assignee: <a class="moz-txt-link-abbreviated" href="mailto:sherold@redhat.com">sherold@redhat.com</a>
          Reporter: <a class="moz-txt-link-abbreviated" href="mailto:bill.james@j2.com">bill.james@j2.com</a>
        QA Contact: <a class="moz-txt-link-abbreviated" href="mailto:gklein@redhat.com">gklein@redhat.com</a>
                CC: <a class="moz-txt-link-abbreviated" href="mailto:bugs@ovirt.org">bugs@ovirt.org</a>
        oVirt Team: Network
             Flags: testing_ack?
             Flags: planning_ack?

Description of problem:
Adding new network with vlan tag, ovirt doesn't allow duplicate VLAN IDs.
But it should be allowed, because if you are using multiple interfaces you can
have the same vlan ID as long as they aren't assigned to the same interface on
the hardware node.

Version-Release number of selected component (if applicable):
ovirt-engine-3.6.3.4-1.el7.centos.noarch

How reproducible:
100%

Steps to Reproduce:
1. Just add network with same vlan id as an already added interface.

2.
3.

Actual results:
See email thread labeled "Re: [ovirt-users] multiple NICs VLAN ID conflict".
GUI says vlan already used.

Expected results:
Duplicate VLAN ID should be checked when you are assign network to the hardware
node, not when creating the interface.

Additional info:
Trying to work around this with vdsm hooks in before_network_setup,
after_get_caps and after_get_stats is very difficult to get it to work right.
(see email thread)

</pre>
    </blockquote>
    <span class="bz_comment_user"> <span class="vcard redhat_user"><a
          class="email" href="mailto:ykaul@redhat.com" title="Yaniv Kaul
          <ykaul@redhat.com>"> <span class="fn">Yaniv Kaul</span></a>
      </span> </span> <span class="bz_comment_time"> 2016-03-20
      03:12:24 EDT </span>
    <pre class="bz_comment_text
                 bz_wrap_comment_text" id="comment_text_1">Perhaps only WARN.

</pre>
  </body>
</html>

--------------000508050504010509050906--

Bill James

tags

participants (1)