On 06/20/2012 05:46 PM, Andrey Gordeev wrote: > > Vm custom parameters not passed to vdsm hooks environment. Vm started > normally, no errors in log files. > > oVirt Engine version: 3.1.0-3 , builded by me for CentOS 6.2 from git > (540a75e0f7bc4b9ed879471d3d830d575c6d6060). > vdsm version 4.10.0-0.58 , bulded by me for CentOS 6.2 from git > (2987ee3c3281e16f55be46974eee1be44a1bebc7). > > Custom parameters added by engine-config -s > UserDefinedVMProperties=... to all versions (3.1,3.0,2.2) i assume you defined the custom properties at the VM level as well?

do you see them when re-editing the VM?

> > In what may be the problem? > > > P.S. > Correspond logs are attached. > > > > > _______________________________________________ > Users mailing list > Users(a)ovirt.org > http://lists.ovirt.org/mailman/listinfo/users

On 06/20/2012 07:38 PM, Andrey Gordeev wrote: >Andrey Gordeev aka dreyou >20.06.2012 19:34 user "Itamar Heim" <iheim(a)redhat.com ><mailto:iheim@redhat.com>> wrote: > > > > On 06/20/2012 05:46 PM, Andrey Gordeev wrote: > >> > >> Vm custom parameters not passed to vdsm hooks environment. Vm started > >> normally, no errors in log files. > >> > >> oVirt Engine version: 3.1.0-3 , builded by me for CentOS 6.2 from git > >> (540a75e0f7bc4b9ed879471d3d830d575c6d6060). > >> vdsm version 4.10.0-0.58 , bulded by me for CentOS 6.2 from git > >> (2987ee3c3281e16f55be46974eee1be44a1bebc7). > >> > >> Custom parameters added by engine-config -s > >> UserDefinedVMProperties=... to all versions (3.1,3.0,2.2) > > > > > > i assume you defined the custom properties at the VM level as well? > >Yes. > > > do you see them when re-editing the VM? > > > >Yes. Shahar/Omer - care to take a look if something happened to custom properties? thanks, Itamar

> > > > >> > >> In what may be the problem? > >> > >> > >> P.S. > >> Correspond logs are attached. > >> > >> > >> > >> > >> _______________________________________________ > >> Users mailing list > >> Users(a)ovirt.org <mailto:Users@ovirt.org> > >> http://lists.ovirt.org/mailman/listinfo/users > > > > >

2012/6/20 Shahar Havivi <shaharh(a)redhat.com&gt;: > On 20.06.12 20:38, Itamar Heim wrote: >> On 06/20/2012 07:38 PM, Andrey Gordeev wrote: >> >Andrey Gordeev aka dreyou >> >20.06.2012 19:34 user "Itamar Heim" <iheim(a)redhat.com >> ><mailto:iheim@redhat.com>> wrote: >> > > >> > > On 06/20/2012 05:46 PM, Andrey Gordeev wrote: >> > >> >> > >> Vm custom parameters not passed to vdsm hooks environment. Vm started >> > >> normally, no errors in log files. >> > >> >> > >> oVirt Engine version: 3.1.0-3 , builded by me for CentOS 6.2 from git >> > >> (540a75e0f7bc4b9ed879471d3d830d575c6d6060). >> > >> vdsm version 4.10.0-0.58 , bulded by me for CentOS 6.2 from git >> > >> (2987ee3c3281e16f55be46974eee1be44a1bebc7). >> > >> >> > >> Custom parameters added by engine-config -s >> > >> UserDefinedVMProperties=... to all versions (3.1,3.0,2.2) >> > > >> > > >> > > i assume you defined the custom properties at the VM level as well? >> > >> >Yes. >> > >> > > do you see them when re-editing the VM? >> > > >> > >> >Yes. >> >> Shahar/Omer - care to take a look if something happened to custom >> properties? >> >> thanks, >>    Itamar > sure, > first please check that the parameters pass to vdsm in /usr/log/vdsm/vdsm.log, > look for the last string of "call vmCreate", in this line you will see all the > parameters that pass to vdsm from the engine. > if you don't see the parameters this is an engine bug. > if you do see it, please check the hooks directories for your hook (such as > before_vm_start which is under /usr/libexec/vdsm/hooks/ (look for all other > directories as well), you hook script should be with executable (+x) and with > permission to vdsm user (36:36). > I'm checked vdsm.log, no parameters in call vmCreate string. > and also please submit the name of the hook, (ie 50_pincpu) and the value that > you have in the UserDefinedVMProperties under 3.1 version. > I'm tested this issue with my own hook for libvirt nfilter (script 50_snfilter) and with the standart hostusb hook (script 50_hostusb) Here the output of "engine-config -g UserDefinedVMProperties": UserDefinedVMProperties: hostusb=[\w:&]+;snfilter=^.+$ version: 3.1

> Shahar. >> >> > >> > > >> > >> >> > >> In what may be the problem? >> > >> >> > >> >> > >> P.S. >> > >> Correspond logs are attached. >> > >> >> > >> >> > >> >> > >> >> > >> _______________________________________________ >> > >> Users mailing list >> > >> Users(a)ovirt.org <mailto:Users@ovirt.org> >> > >> http://lists.ovirt.org/mailman/listinfo/users >> > > >> > > >> > >> -- Andrey Gordeev aka Dreyou. _______________________________________________ Users mailing list Users(a)ovirt.org http://lists.ovirt.org/mailman/listinfo/users

On 21.06.12 11:03, Shahar Havivi wrote: > On 21.06.12 10:04, Andrey Gordeev wrote: > > 2012/6/20 Shahar Havivi <shaharh(a)redhat.com&gt;: > > > On 20.06.12 20:38, Itamar Heim wrote: > > >> On 06/20/2012 07:38 PM, Andrey Gordeev wrote: > > >> >Andrey Gordeev aka dreyou > > >> >20.06.2012 19:34 user "Itamar Heim" <iheim(a)redhat.com > > >> ><mailto:iheim@redhat.com>> wrote: > > >> > > > > >> > > On 06/20/2012 05:46 PM, Andrey Gordeev wrote: > > >> > >> > > >> > >> Vm custom parameters not passed to vdsm hooks environment. Vm started > > >> > >> normally, no errors in log files. > > >> > >> > > >> > >> oVirt Engine version: 3.1.0-3 , builded by me for CentOS 6.2 from git > > >> > >> (540a75e0f7bc4b9ed879471d3d830d575c6d6060). > > >> > >> vdsm version 4.10.0-0.58 , bulded by me for CentOS 6.2 from git > > >> > >> (2987ee3c3281e16f55be46974eee1be44a1bebc7). > > >> > >> > > >> > >> Custom parameters added by engine-config -s > > >> > >> UserDefinedVMProperties=... to all versions (3.1,3.0,2.2) > > >> > > > > >> > > > > >> > > i assume you defined the custom properties at the VM level as well? > > >> > > > >> >Yes. > > >> > > > >> > > do you see them when re-editing the VM? > > >> > > > > >> > > > >> >Yes. > > >> > > >> Shahar/Omer - care to take a look if something happened to custom > > >> properties? > > >> > > >> thanks, > > >>    Itamar > > > sure, > > > first please check that the parameters pass to vdsm in /usr/log/vdsm/vdsm.log, > > > look for the last string of "call vmCreate", in this line you will see all the > > > parameters that pass to vdsm from the engine. > > > if you don't see the parameters this is an engine bug. > > > if you do see it, please check the hooks directories for your hook (such as > > > before_vm_start which is under /usr/libexec/vdsm/hooks/ (look for all other > > > directories as well), you hook script should be with executable (+x) and with > > > permission to vdsm user (36:36). > > > > > > > I'm checked vdsm.log, no parameters in call vmCreate string. > > > > > > > and also please submit the name of the hook, (ie 50_pincpu) and the value that > > > you have in the UserDefinedVMProperties under 3.1 version. > > > > > > > I'm tested this issue with my own hook for libvirt nfilter (script > > 50_snfilter) and with the standart hostusb hook (script 50_hostusb) > > > > Here the output of "engine-config -g UserDefinedVMProperties": > > > > UserDefinedVMProperties: hostusb=[\w:&]+;snfilter=^.+$ version: 3.1 > Ok, thanks, > I was able to reproduce the problem and I will send fix shortly, > Thank you > > Shahar. Fix is now upstream, at: http://gerrit.ovirt.org/#/c/5583/

> > > > > Shahar. > > >> > > >> > > > >> > > > > >> > >> > > >> > >> In what may be the problem? > > >> > >> > > >> > >> > > >> > >> P.S. > > >> > >> Correspond logs are attached. > > >> > >> > > >> > >> > > >> > >> > > >> > >> > > >> > >> _______________________________________________ > > >> > >> Users mailing list > > >> > >> Users(a)ovirt.org <mailto:Users@ovirt.org> > > >> > >> http://lists.ovirt.org/mailman/listinfo/users > > >> > > > > >> > > > > >> > > > >> > > > > > > > > -- > > Andrey Gordeev aka Dreyou. > > _______________________________________________ > > Users mailing list > > Users(a)ovirt.org > > http://lists.ovirt.org/mailman/listinfo/users