I've identified 3 ancient vdsm-hooks that have been obsoleted by proper oVirt features. vdsm-hook-isolatedvlan: obsoleted in ovirt-4.2.6 by clean-traffic-gateway filter https://gerrit.ovirt.org/#/q/I396243e1943eca245ab4da64bb286da19f9b47ec vdsm-hook-qos: obsoleted in ovirt-3.3 by https://www.ovirt.org/documentation/sla/network-qos/ vdsm-hook-noipspoof: obsoleted in ovirt-4.0 by choosing the "clean-traffic" filter https://ovirt.org/feature/networkfilter I would like to remove this code from vdsm-4.30, destined for ovirt-4.3. Is there any objection for that? Is anybody still using them? Regards, Dan.
On Thu, Oct 4, 2018 at 12:37 PM Dan Kenigsberg <danken@redhat.com> wrote:
I've identified 3 ancient vdsm-hooks that have been obsoleted by proper oVirt features.
vdsm-hook-isolatedvlan: obsoleted in ovirt-4.2.6 by clean-traffic-gateway filter https://gerrit.ovirt.org/#/q/I396243e1943eca245ab4da64bb286da19f9b47ec
Hello Dan, you mention "clean-traffic-gateway" filter and "clean-traffic" filter. They are to be considered different, correct? Because both in my upstream oVirt engine 4.2.6.4-1.el7 and in my RHV engine 4.2.6.4-0.1.el7ev I only see the "clean-traffic" one. Perhaps it is "filtered out" because the hosts are not 7.6, as I see from https://bugzilla.redhat.com/show_bug.cgi?id=1603115 that it is a libvirt feature to be backported to 7.6, so not available in 7.5 perhaps...? If so, as RH EL 7.6 is not out yet, and then it will pass some weeks/months at least before CentOS 7.6 will be released and guys updating the hypervisors, I think it's not time yet to remove the old vdsm-hook-isolatedvlan Any clarification if I was wrong? Thanks, Gianluca
On Tue, Oct 9, 2018 at 4:13 PM Gianluca Cecchi <gianluca.cecchi@gmail.com> wrote:
On Thu, Oct 4, 2018 at 12:37 PM Dan Kenigsberg <danken@redhat.com> wrote:
I've identified 3 ancient vdsm-hooks that have been obsoleted by proper oVirt features.
vdsm-hook-isolatedvlan: obsoleted in ovirt-4.2.6 by clean-traffic-gateway filter https://gerrit.ovirt.org/#/q/I396243e1943eca245ab4da64bb286da19f9b47ec
Hello Dan, you mention "clean-traffic-gateway" filter and "clean-traffic" filter. They are to be considered different, correct? Because both in my upstream oVirt engine 4.2.6.4-1.el7 and in my RHV engine 4.2.6.4-0.1.el7ev I only see the "clean-traffic" one. Perhaps it is "filtered out" because the hosts are not 7.6, as I see from https://bugzilla.redhat.com/show_bug.cgi?id=1603115 that it is a libvirt feature to be backported to 7.6, so not available in 7.5 perhaps...?
If so, as RH EL 7.6 is not out yet, and then it will pass some weeks/months at least before CentOS 7.6 will be released and guys updating the hypervisors, I think it's not time yet to remove the old vdsm-hook-isolatedvlan
Any clarification if I was wrong?
No, you are not wrong. I intend to remove this hook only from the master branch, destined for ovirt-4.3. I believe that CentOS-7.6 would be released much before ovirt-4.3, but there is no need to start gambling. These patches can wait. Are you using vdsm-hook-isolatedvlan? Would you agree to check if clean-traffic-gateway answers your needs? All you need is to download https://libvirt.org/git/?p=libvirt.git;a=blob;f=examples/xml/nwfilter/clean-... and then virsh nwfilter-define /tmp/clean-traffic-gateway.xml on each host.
Il giorno gio 4 ott 2018 alle ore 12:37 Dan Kenigsberg <danken@redhat.com> ha scritto:
I've identified 3 ancient vdsm-hooks that have been obsoleted by proper oVirt features.
vdsm-hook-isolatedvlan: obsoleted in ovirt-4.2.6 by clean-traffic-gateway filter https://gerrit.ovirt.org/#/q/I396243e1943eca245ab4da64bb286da19f9b47ec
vdsm-hook-qos: obsoleted in ovirt-3.3 by https://www.ovirt.org/documentation/sla/network-qos/
vdsm-hook-noipspoof: obsoleted in ovirt-4.0 by choosing the "clean-traffic" filter https://ovirt.org/feature/networkfilter
I would like to remove this code from vdsm-4.30, destined for ovirt-4.3. Is there any objection for that? Is anybody still using them?
Please open a bug for this and be sure to reference it in commit message so it will be properly tracked in 4.3 release notes. Thanks,
Regards, Dan. _______________________________________________ Users mailing list -- users@ovirt.org To unsubscribe send an email to users-leave@ovirt.org Privacy Statement: https://www.ovirt.org/site/privacy-policy/ oVirt Code of Conduct: https://www.ovirt.org/community/about/community-guidelines/ List Archives: https://lists.ovirt.org/archives/list/users@ovirt.org/message/GG2D4PPNNYJLZL...
-- SANDRO BONAZZOLA MANAGER, SOFTWARE ENGINEERING, EMEA R&D RHV Red Hat EMEA <https://www.redhat.com/> sbonazzo@redhat.com <https://red.ht/sig>
participants (3)
-
Dan Kenigsberg -
Gianluca Cecchi -
Sandro Bonazzola