[ovirt-devel] local vdsm build fails

[Nir Soffer]

----- Original Message -----
> From: "Dan Kenigsberg" <danken at redhat.com>
> To: "Piotr Kliczewski" <piotr.kliczewski at gmail.com>, fsimonce at redhat.com, nsoffer at redhat.com, dcaro at redhat.com
> Cc: devel at ovirt.org
> Sent: Friday, June 6, 2014 12:15:18 PM
> Subject: Re: [ovirt-devel]  local vdsm build fails
> 
> On Fri, Jun 06, 2014 at 09:19:11AM +0200, Piotr Kliczewski wrote:
> > All,
> > 
> > I pulled the latest vdsm from master and noticed that build is failing.
> > 
> > Here is the patch that causes the failuer:
> > 
> > http://gerrit.ovirt.org/#/c/28226
> > 
> > and looking at jenkins comments I can see that jenkins was failing
> > with the same reason:
> > 
> > http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/1064/console

Nir has already fix that as well. The storage tests were just fine, but
a post build script was running cp incorrectly.

David pointed that we need a way to distinguish between test errors and failures.
He suggested looking up strings in the test output - we should not go there, unless
we want to "fix" this many more times in the future.

I suggest to use the these rules:

- SUCCESS - make check returns 0
- FAILURE - make check returns 1
- ERROR - anything else returned by make check or any other script.

I think that make check does work like this, but it should be easy to change.

What do you think?

> 
> Thanks for your report. Nir has already fixed this in
> http://gerrit.ovirt.org/28426.
> 
> It was introduced in http://gerrit.ovirt.org/#/c/28226/ but missed also
> because we have turned PYFLAKES off in unit test jobs. We must turn it on in
> at least one of the tests (or initiate a new jenkins job for `make
> check-local`).
> 
> As a quick fix, David has re-enabled PYFLAKES in
> http://jenkins.ovirt.org/view/By%20Project/view/vdsm/job/vdsm_master_unit_tests/configure
> 
> Regards,
> Dan.
>