[ovirt-devel] local vdsm build fails

[Federico Simoncelli]

----- Original Message -----
> From: "Dan Kenigsberg" <danken at redhat.com>
> To: "Piotr Kliczewski" <piotr.kliczewski at gmail.com>, fsimonce at redhat.com, nsoffer at redhat.com, dcaro at redhat.com
> Cc: devel at ovirt.org
> Sent: Friday, June 6, 2014 11:15:18 AM
> Subject: Re: [ovirt-devel]  local vdsm build fails
> 
> On Fri, Jun 06, 2014 at 09:19:11AM +0200, Piotr Kliczewski wrote:
> > All,
> > 
> > I pulled the latest vdsm from master and noticed that build is failing.
> > 
> > Here is the patch that causes the failuer:
> > 
> > http://gerrit.ovirt.org/#/c/28226


Sorry, the patch was verified in a series. I relied on gerrit running pyflakes
for each individual patch (I didn't know it was disabled).

Just to be on the safe side if a patch explicitly says (in the comment setting
the "verified" flag) that was tested in a series we should probably merge the
entire set together. There may be more important side effects other than just
not being able to build. Sadly there's not always time to verify a long series
one by one.

-- 
Federico


> > and looking at jenkins comments I can see that jenkins was failing
> > with the same reason:
> > 
> > http://jenkins.ovirt.org/job/vdsm_master_storage_functional_tests_localfs_gerrit/1064/console
> 
> Thanks for your report. Nir has already fixed this in
> http://gerrit.ovirt.org/28426.
> 
> It was introduced in http://gerrit.ovirt.org/#/c/28226/ but missed also
> because we have turned PYFLAKES off in unit test jobs. We must turn it on in
> at least one of the tests (or initiate a new jenkins job for `make
> check-local`).
> 
> As a quick fix, David has re-enabled PYFLAKES in
> http://jenkins.ovirt.org/view/By%20Project/view/vdsm/job/vdsm_master_unit_tests/configure
> 
> Regards,
> Dan.