[ovirt-devel] Regarding site bug fix

[shubham dubey]

Thanks for help.
One more thing I want to know is that, is it necessary to fork the
ovirt-site first into your repository to send a pr.

On Wed, May 31, 2017 at 11:57 PM, Dan Kenigsberg <danken at redhat.com> wrote:

> On Wed, May 31, 2017 at 9:20 PM, shubham dubey <sdubey504 at gmail.com>
> wrote:
> > Hi,
> > I want to fix some issues in ovirt site. Since I never did a pull request
> > before,
> > hence want to know few things.
> > 1)can I fix multiple bug and send a single pr for them.
>
> You can send one pull request, but each of its commits should fix a
> single issue. Then again, if the fixes are unrelated to each other,
> you'd better use different PRs.
>
> > 2) when I fix a issue did I need to write something in the comment of the
> > bug (like 'fixed' or 'patch send').
>
> Actually, you should usually write something longer, such as "fix a
> broken link" or "add a clearer paragraph, as the former text was
> confusing" - anything that can explain to your reviewer the motivation
> for your commit.
>
>
> >
> > thanks in advance and I will appreciate for extra related info:)
> >
> > Shubham
> >
> > _______________________________________________
> > Devel mailing list
> > Devel at ovirt.org
> > http://lists.ovirt.org/mailman/listinfo/devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ovirt.org/pipermail/devel/attachments/20170601/77b20bf4/attachment.html>