[ovirt-devel] Building the oVirt Engine master branch fails due to isort, python issues

Mon Feb 26 13:37:11 UTC 2018

Strange, I've just tried to build latest master using
python2-isort-4.2.5-8.el7 on latest RHEL 7.4 and it finished successfully
without any errors ...

On Mon, Feb 26, 2018 at 2:31 PM, Yedidyah Bar David <didi at redhat.com> wrote:

> On Mon, Feb 26, 2018 at 3:19 PM, Steven Rosenberg <srosenbe at redhat.com>
> wrote:
> > Dear Yedidyah,
> >
> > Thank you for your response. I have attached the two dump files. The
> first
> > is the original error for isort, dump.txt. The second dump_isort.txt is
> > after installing python2_isort.
>
> This is the error:
>
> pep8 <lots of files>
> packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/
> network/ovirtproviderovn.py:474:25:
> E126 continuation line over-indented for hanging indent
> packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/
> network/ovirtproviderovn.py:481:25:
> E126 continuation line over-indented for hanging indent
> packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/
> network/ovirtproviderovn.py:488:25:
> E126 continuation line over-indented for hanging indent
> packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/
> network/ovirtproviderovn.py:635:21:
> E126 continuation line over-indented for hanging indent
> packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/
> network/ovirtproviderovn.py:637:21:
> E126 continuation line over-indented for hanging indent
> packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/
> network/ovirtproviderovn.py:639:21:
> E126 continuation line over-indented for hanging indent
> packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/
> network/ovirtproviderovn.py:641:21:
> E126 continuation line over-indented for hanging indent
> packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/
> network/ovirtproviderovn.py:645:21:
> E126 continuation line over-indented for hanging indent
> packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/
> network/ovirtproviderovn.py:652:21:
> E126 continuation line over-indented for hanging indent
> packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/
> network/ovirtproviderovn.py:654:21:
> E126 continuation line over-indented for hanging indent
> packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/
> network/ovirtproviderovn.py:658:21:
> E126 continuation line over-indented for hanging indent
> packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/
> network/ovirtproviderovn.py:663:21:
> E126 continuation line over-indented for hanging indent
> packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/
> network/ovirtproviderovn.py:664:21:
> E126 continuation line over-indented for hanging indent
> packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/
> network/ovirtproviderovn.py:872:13:
> E126 continuation line over-indented for hanging indent
> packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/db/
> configuration.py:255:13:
> E126 continuation line over-indented for hanging indent
> packaging/setup/plugins/ovirt-engine-rename/ovirt-engine/
> database.py:313:21:
> E126 continuation line over-indented for hanging indent
> packaging/setup/plugins/ovirt-engine-rename/ovirt-engine/
> database.py:314:21:
> E126 continuation line over-indented for hanging indent
> packaging/setup/plugins/ovirt-engine-common/base/core/
> duplicated_constants_check.py:109:17:
> E124 closing bracket does not match visual indentation
> + ret=1
>
> Perhaps a newer version of pep8 finds more bugs in our code.
>
> Pushed this to get a more explanatory error:
>
> https://gerrit.ovirt.org/88186
>
> Best regards,
>
> >
> > With Best Regards.
> >
> > Steven Rosenberg.
> >
> > On Mon, Feb 26, 2018 at 3:10 PM, Yedidyah Bar David <didi at redhat.com>
> wrote:
> >>
> >> Hi,
> >>
> >> On Mon, Feb 26, 2018 at 2:39 PM, Steven Rosenberg <srosenbe at redhat.com>
> >> wrote:
> >> > Dear Martin,
> >> >
> >> > I should add I am running RHEL 7.4 (Maipo).
> >> >
> >> > With Best Regards.
> >> >
> >> > Steven Rosenberg.
> >> >
> >> > On Mon, Feb 26, 2018 at 2:24 PM, Martin Perina <mperina at redhat.com>
> >> > wrote:
> >> >>
> >> >> Didi/Sandro, any ideas about it? AFAIK on CentOS/RHEL 7 everything
> >> >> works
> >> >> as expected ...
> >> >>
> >> >>
> >> >> On Mon, Feb 26, 2018 at 11:58 AM, Steven Rosenberg
> >> >> <srosenbe at redhat.com>
> >> >> wrote:
> >> >>>
> >> >>> Dear Martin Perina,
> >> >>>
> >> >>> We found some issues with the oVirt Engine master branch when
> updating
> >> >>> the version via git pull.
> >> >>>
> >> >>> We then performed the make command:
> >> >>>
> >> >>> make clean install-dev PREFIX=~/ovirt_engine_master
> >> >>> DEV_BUILD_SCL_POSTGRESQL=1
> >> >>>
> >> >>> It seems a new dependency was added for isort, so the make fails
> with
> >> >>> the
> >> >>> following error:
> >> >>>
> >> >>>
> >> >>>
> >> >>> ------------------------------------------------------------
> --------------------------------------------------------
> >> >>>
> >> >>>
> >> >>>
> >> >>> packaging/setup/plugins/ovirt-engine-rename/ovirt-engine/
> database.py:313:21:
> >> >>> E126 continuation line over-indented for hanging indent
> >> >>>
> >> >>>
> >> >>> packaging/setup/plugins/ovirt-engine-rename/ovirt-engine/
> database.py:314:21:
> >> >>> E126 continuation line over-indented for hanging indent
> >> >>>
> >> >>>
> >> >>> packaging/setup/plugins/ovirt-engine-common/base/core/
> duplicated_constants_check.py:109:17:
> >> >>> E124 closing bracket does not match visual indentation
> >> >>> + ret=1
> >> >>> + which isort
> >> >>> + echo 'WARNING: tool '\''isort'\'' is missing'
> >> >>> WARNING: tool 'isort' is missing
> >>
> >> This is just a warning
> >>
> >> >>> + exit 1
> >>
> >> Most likely the error causing it to exit 1 happened earlier, please
> >> check/share
> >> more of the output.
> >>
> >> >>> make[1]: *** [validations] Error 1
> >> >>> make[1]: Leaving directory `/home/srosenbe/Documents/git/
> ovirt-engine'
> >> >>> make: *** [all-dev] Error 2
> >> >>>
> >> >>>
> >> >>>
> >> >>> ------------------------------------------------------------
> --------------------------------------------------------
> >> >>>
> >> >>> To attempt to address this issue, we guessed and installed
> >> >>> python2-isort
> >> >>> through yum, though the readme states it is optional.
> >> >>>
> >> >>> Though the process continued, it then failed in the python module:
> >> >>>
> >> >>>
> >> >>>
> >> >>> /home/srosenbe/Documents/git/ovirt-engine/packaging/
> pythonlib/ovirt_engine/service.py
> >> >>>
> >> >>> That error is here:
> >> >>>
> >> >>>
> >> >>>
> >> >>> ------------------------------------------------------------
> ---------------------------------------------------------------
> >> >>>
> >> >>>
> >> >>> ---
> >> >>>
> >> >>> /home/srosenbe/Documents/git/ovirt-engine/packaging/
> pythonlib/ovirt_engine/service.py:before
> >> >>> 2018-02-12 12:17:26
> >> >>> +++
> >> >>>
> >> >>> /home/srosenbe/Documents/git/ovirt-engine/packaging/
> pythonlib/ovirt_engine/service.py:after
> >> >>> 2018-02-26 12:07:11.233915
> >> >>> @@ -31,6 +31,7 @@
> >> >>>  import time
> >> >>>
> >> >>>  import daemon
> >> >>> +
> >> >>>
> >> >>>  from dateutil import tz
> >> >>>
> >>
> >> This is an output of 'isort --diff', and not the actual error.
> >>
> >> (isort --check, which is what we run to test the code, does not fail if
> >> the diff it would have suggested consists of only difference in the
> number
> >> of empty lines. It would still be nice to patch service.py to have
> another
> >> empty line, but not needed).
> >>
> >> >>> + exit 1
> >>
> >> Same. Error was most likely earlier.
> >>
> >> Best regards,
> >>
> >> >>> make[1]: *** [validations] Error 1
> >> >>> make[1]: Leaving directory `/home/srosenbe/Documents/git/
> ovirt-engine'
> >> >>> make: *** [all-dev] Error 2
> >> >>>
> >> >>>
> >> >>>
> >> >>> ------------------------------------------------------------
> ---------------------------------------------------------------
> >> >>>
> >> >>> Please advise if you have a quick fix or when this issue will be
> >> >>> addressed.
> >> >>>
> >> >>> Thank you for your time and consideration.
> >> >>>
> >> >>> With Best Regards.
> >> >>>
> >> >>> Steven Rosenberg.
> >> >>>
> >> >>
> >> >>
> >> >>
> >> >> --
> >> >> Martin Perina
> >> >> Associate Manager, Software Engineering
> >> >> Red Hat Czech s.r.o.
> >> >
> >> >
> >>
> >>
> >>
> >> --
> >> Didi
> >
> >
>
>
>
> --
> Didi
>

-- 
Martin Perina
Associate Manager, Software Engineering
Red Hat Czech s.r.o.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.ovirt.org/pipermail/devel/attachments/20180226/fe3ee778/attachment.html>