Change in ovirt-engine[master]: bootstrap: cleanup command used to gather node id

dfediuck at redhat.com dfediuck at redhat.com
Sun Aug 5 10:06:42 UTC 2012


Doron Fediuck has submitted this change and it was merged.

Change subject: bootstrap: cleanup command used to gather node id
......................................................................


bootstrap: cleanup command used to gather node id

1. There is no apparent reason to encapsulate within echo.

2. There is no reason to explicit execute bash.

3. There is no reason to use full path for system utilities,
   utilities may reside at different locations at differnt
   setups.

If an issue will be found, it should be clearly documented.

Change-Id: Iace5593ab5585d1c8e25dcf76882480f3b6676d0
Signed-off-by: Alon Bar-Lev <alonbl at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsInstaller.java
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Doron Fediuck: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/6720
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iace5593ab5585d1c8e25dcf76882480f3b6676d0
Gerrit-PatchSet: 11
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck at redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib at redhat.com>



More information about the Engine-commits mailing list