Change in ovirt-engine[master]: core: SyntaxChecker cleanup I

lhornyak at redhat.com lhornyak at redhat.com
Thu Aug 9 14:19:58 UTC 2012


Laszlo Hornyak has submitted this change and it was merged.

Change subject: core: SyntaxChecker cleanup I
......................................................................


core: SyntaxChecker cleanup I

- final parameters in overcomplicated functions where possible, so that
  they can be tracked easily
- variable.equals("CONSTANT") and StringHelper.EqOp(variable,
  "CONSTANT") replaced by "CONSTANT".equals(variable)
- some decision factored out to new methods

Change-Id: I8da7918b8c048af46313d99663e44142118eee49
Signed-off-by: Laszlo Hornyak <lhornyak at redhat.com>
---
M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SyntaxChecker.java
1 file changed, 30 insertions(+), 17 deletions(-)

Approvals:
  Laszlo Hornyak: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/7035
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8da7918b8c048af46313d99663e44142118eee49
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <lhornyak at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck at redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik at redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak at redhat.com>



More information about the Engine-commits mailing list