Change in ovirt-engine[master]: bootstrap: new implementation for apache-sshd usage

[dfediuck at redhat.com]

Doron Fediuck has submitted this change and it was merged.

Change subject: bootstrap: new implementation for apache-sshd usage
......................................................................


bootstrap: new implementation for apache-sshd usage

Major changes:

  1. Do not use temporary files for compression/decompression.

  2. Do not use wget to pull large files, use ssh for all transfers.

  3. One pass on files for digest, compress/decompress, send/receive.

  4. Do not pull every 1 second for bytes/status.

  5. Test for command status code.

  6. File transfer using ssh and md5sum at same session, md5sum written to
     stderr.

  7. Limit buffer size when reading remote output, so we won't exhaust all
     memory.

  8. Do not echo back whole file content when sending file.

  9. Consistent error, exception handling and debugging information.

 10. More unit tests.

Split between pure ssh implementation[1] and application logic[2].

Unit tests now have their own dedicated generic sshd[3], for proper
work in embedded mode ssh apache-ssh-0.7.0 is required.

Separate unit tests dedicated to OVirtSSH implementation, by default
embedded apache-sshd is used, this can be overridden by setting
java system properties, see[4].

As unit tests takes long time, use -Penable-ssh-tests to activate.

[1] org.ovirt.engine.core.utils.ssh.OVirtSSH
[2] org.ovirt.engine.core.utils.hostinstall.MinaInstallWrapper
[3] org.ovirt.engine.core.utils.ssh.SSHD
[4] org.ovirt.engine.core.utils.ssh.TestCommon

Change-Id: I50ba60f2db364114907485da3074feb714615e0c
Signed-off-by: Alon Bar-Lev <alonbl at redhat.com>
---
M backend/manager/modules/utils/pom.xml
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/hostinstall/VdsInstallerSSH.java
A backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ssh/ConstraintByteArrayOutputStream.java
A backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ssh/ProgressInputStream.java
A backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ssh/ProgressOutputStream.java
A backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ssh/SSHClient.java
D backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/hostinstall/DummyPasswordAuthenticator.java
D backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/hostinstall/DummyPublickeyAuthenticator.java
D backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/hostinstall/KeystoreKeyPairProvider.java
M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/hostinstall/VdsInstallerSSHTest.java
D backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/hostinstall/VdsInstallerSSHTimeoutTest.java
A backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/ssh/BasicTest.java
A backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/ssh/CommandTest.java
A backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/ssh/ConstraintByteArrayOutputStreamTest.java
A backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/ssh/SSHD.java
A backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/ssh/TestCommon.java
A backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/ssh/TimeoutTest.java
A backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/ssh/TransferTest.java
M pom.xml
19 files changed, 2,314 insertions(+), 1,313 deletions(-)

Approvals:
  Doron Fediuck: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/6722
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I50ba60f2db364114907485da3074feb714615e0c
Gerrit-PatchSet: 15
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay at redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck at redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland at redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib at redhat.com>
Gerrit-Reviewer: Shireesh Anjal <sanjal at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>