Change in ovirt-engine[master]: backend: Fix 'remove-quota' canDo logic (#844652)

gchaplik at redhat.com gchaplik at redhat.com
Sun Aug 12 15:23:06 UTC 2012


Gilad Chaplik has submitted this change and it was merged.

Change subject: backend: Fix 'remove-quota' canDo logic (#844652)
......................................................................


backend: Fix 'remove-quota' canDo logic (#844652)

https://bugzilla.redhat.com/844652

The logic of the remove-quota-command was wrong (old logic)

It was fixed to support the folowing logic:
 - If quota is still in use by a VM or Disk
	Don't allow to delete the quota

Change-Id: I0ed5166fc1b8fec94b3f90013ef76474f33b327d
Signed-off-by: Ofri Masad <omasad at redhat.com>
---
M backend/manager/dbscripts/quota_sp.sql
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveQuotaCommand.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/QuotaDAO.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/QuotaDAODbFacadeImpl.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
9 files changed, 55 insertions(+), 13 deletions(-)

Approvals:
  Gilad Chaplik: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/6926
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0ed5166fc1b8fec94b3f90013ef76474f33b327d
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: ofri masad <omasad at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik at redhat.com>
Gerrit-Reviewer: ofri masad <omasad at redhat.com>



More information about the Engine-commits mailing list