Change in ovirt-engine[master]: core: attach of Illegal disk should not be allowed (#848074)

mlipchuk at redhat.com mlipchuk at redhat.com
Thu Aug 16 13:24:05 UTC 2012


Maor Lipchuk has submitted this change and it was merged.

Change subject: core: attach of Illegal disk should not be allowed (#848074)
......................................................................


core: attach of Illegal disk should not be allowed (#848074)

https://bugzilla.redhat.com/show_bug.cgi?id=848074

Illegal disk should not be allowed to be attached to VMs, only to be
deleted, since we can't know if this disk is valid in the storage or
not.

Change-Id: I35fe4123c40de371a6f338bc3655923ab51400e1
Signed-off-by: Maor Lipchuk <mlipchuk at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachDiskToVmCommand.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M backend/manager/modules/utils/src/test/resources/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
5 files changed, 16 insertions(+), 5 deletions(-)

Approvals:
  Maor Lipchuk: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/7205
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I35fe4123c40de371a6f338bc3655923ab51400e1
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Ori Liel <oliel at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list