Change in ovirt-engine[master]: core: Fix calculations of snapshot quota (#848028)

gchaplik at redhat.com gchaplik at redhat.com
Thu Aug 23 12:23:09 UTC 2012


Gilad Chaplik has submitted this change and it was merged.

Change subject: core: Fix calculations of snapshot quota (#848028)
......................................................................


core: Fix calculations of snapshot quota (#848028)

https://bugzilla.redhat.com/848028

Fix 1: The sized used for quota calculation of each snapshot was fixed.
The former value was the size of the predefined disk, the new value is
the actual size the snapshot took in storage.

Fix 2: The snapshot-preview did not pass the quota ID to the new active
image. After the commit, the active image was linked to a null qouta and
so a new snapshot could not be taken.

Change-Id: I6cf5d23a9c5c90b64b330cadf4f7c1b67fad45fa
Signed-off-by: Ofri Masad <omasad at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestoreAllSnapshotsCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/TryBackToAllSnapshotsOfVmCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DiskImage.java
4 files changed, 46 insertions(+), 10 deletions(-)

Approvals:
  Gilad Chaplik: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/7338
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I6cf5d23a9c5c90b64b330cadf4f7c1b67fad45fa
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: ofri masad <omasad at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck at redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik at redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-Reviewer: ofri masad <omasad at redhat.com>



More information about the Engine-commits mailing list