Change in ovirt-engine[master]: core: Add lock to a disk in attach to VM command (#834888)

tnisan at redhat.com tnisan at redhat.com
Sun Aug 26 10:37:55 UTC 2012


Tal Nisan has submitted this change and it was merged.

Change subject: core: Add lock to a disk in attach to VM command (#834888)
......................................................................


core: Add lock to a disk in attach to VM command (#834888)

https://bugzilla.redhat.com/834888

Added lock to the disk entity when attaching a disk to a VM in
case the disk is not shareable, also added a validation to the cando
action in case when the disk is not shareable and already attached to
another VM, for some reason this was not checked and the only thing
blocking from attaching a non shareable disk to multiple VM was the UI

Change-Id: Ib9e47fe370b230b4bd69f108954031cda3bba6a3
Signed-off-by: Tal Nisan <tnisan at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachDiskToVmCommand.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
6 files changed, 21 insertions(+), 4 deletions(-)

Approvals:
  Tal Nisan: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/7337
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib9e47fe370b230b4bd69f108954031cda3bba6a3
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list