Change in ovirt-engine[master]: core: Add local configuration helper

yzaslavs at redhat.com yzaslavs at redhat.com
Tue Aug 28 10:53:44 UTC 2012


Yair Zaslavsky has submitted this change and it was merged.

Change subject: core: Add local configuration helper
......................................................................


core: Add local configuration helper

This patch adds the LocalConfig class intended to centralize the
management of local configuration stored in the
/etc/sysconfig/ovirt-engine file (or whatever the ENGINE_VARS
environment variable points to).

The name "local" is intended to convey the difference between the
configuration that is specific to a particular node and the
configuration that is "global", stored in the database, and shared
by all the nodes in a (future) cluster.

The intended use is something like this:

  LocalConfig config = LocalConfig.getInstance();
  String myVar = config.getProperty("MY_VAR");

In addition to this generic interface it also supports other
methods to get the values of well known variables, like port
numbers and directories, for example:

  int httpPort = config.getExternalHttpPort();
  int httpsPort = config.getExternalHttpPort();

These methods contain some logic to decide if the external
port is the one used by the web server or the one used by the
application server.

Change-Id: Ib0106a71c3a1c7c145d4ca836225ce2a26aa115f
Signed-off-by: Juan Hernandez <juan.hernandez at redhat.com>
---
A backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/LocalConfig.java
1 file changed, 326 insertions(+), 0 deletions(-)

Approvals:
  Juan Hernandez: Verified
  Yair Zaslavsky: Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/6673
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ib0106a71c3a1c7c145d4ca836225ce2a26aa115f
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl at redhat.com>
Gerrit-Reviewer: Anonymous Coward #1000055
Gerrit-Reviewer: Doron Fediuck <dfediuck at redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez at redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list