Change in ovirt-engine[master]: engine: Exception when updating lun disk properties (#844153...

mlipchuk at redhat.com mlipchuk at redhat.com
Wed Aug 29 08:38:51 UTC 2012


Maor Lipchuk has submitted this change and it was merged.

Change subject: engine: Exception when updating lun disk properties (#844153)
......................................................................


engine: Exception when updating lun disk properties (#844153)

https://bugzilla.redhat.com/844153

When updating properties of a LUN disk, the audit logger attempted to
retrieve the storage pool id of the disk.  The method to return the id
cast the Parameter to a DiskImage, even though the Parameter was a
LunDisk, causing a ClassCastException.

Because the storage pool isn't in the audit log, remove the method
UpdateVmDiskCommand.getStoragePoolId() altogether.

Change-Id: Iba86289c25937002c9c07a06db5651bca4485d38
Signed-off-by: Greg Padgett <gpadgett at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java
1 file changed, 0 insertions(+), 7 deletions(-)

Approvals:
  Maor Lipchuk: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/7230
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iba86289c25937002c9c07a06db5651bca4485d38
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Greg Padgett <gpadgett at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server



More information about the Engine-commits mailing list