Change in ovirt-engine[master]: engine: Removed useless checks at ConnectHostToStoragePoolSe...

mkublin at redhat.com mkublin at redhat.com
Mon Dec 3 10:22:00 UTC 2012


Michael Kublin has submitted this change and it was merged.

Change subject: engine: Removed useless checks at ConnectHostToStoragePoolServersCommand
......................................................................


engine: Removed useless checks at ConnectHostToStoragePoolServersCommand

The following checks at canDoaction are useless, the command is called only once form
InitVdsOnUp and the same checks are performed before a call to command

Change-Id: I25c6f4db1108b513663b81fbc7956e66edd9c797
Signed-off-by: Michael Kublin <mkublin at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectHostToStoragePoolServersCommand.java
1 file changed, 21 insertions(+), 27 deletions(-)

Approvals:
  Michael Kublin: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/9567
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I25c6f4db1108b513663b81fbc7956e66edd9c797
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Kublin <mkublin at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>



More information about the Engine-commits mailing list