Change in ovirt-engine[master]: tools: Fixing npe at notification service log

yzaslavs at redhat.com yzaslavs at redhat.com
Wed Dec 5 16:54:43 UTC 2012


Yair Zaslavsky has submitted this change and it was merged.

Change subject: tools: Fixing npe at notification service log
......................................................................


tools: Fixing npe at notification service log

Both MAIL_FORM and MAIL_USER are not mandatory to send
a notification, but if a notification sending has failed
the log message uses the from object (which is set either by using
MAIL_FROM if exists at the configuration
, or by MAIL_USER if MAIL_FROM doesn't exist in
the configuration).
The log is fixed to handle possible NPEs

Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=880597
Change-Id: If25ef37b0d9ff79737e7dfe8283322acb81c1dcb
signed-off-by: Yair Zaslavsky <yzaslavs at redhat.com>
---
M backend/manager/tools/engine-notifier/engine-notifier-service/src/main/java/org/ovirt/engine/core/notifier/utils/sender/mail/JavaMailSender.java
1 file changed, 12 insertions(+), 5 deletions(-)

Approvals:
  Yair Zaslavsky: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/9726
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If25ef37b0d9ff79737e7dfe8283322acb81c1dcb
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzaslavs at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>



More information about the Engine-commits mailing list