Change in ovirt-engine[master]: restapi: Privileged user cannot create VM via API (#876460)

mpastern at redhat.com mpastern at redhat.com
Mon Dec 10 08:36:12 UTC 2012


Michael Pasternak has submitted this change and it was merged.

Change subject: restapi: Privileged user cannot create VM via API (#876460)
......................................................................


restapi: Privileged user cannot create VM via API (#876460)

PowerUser can create VM from GUI but the operation
fails from API. /api/vms to create a VM throws
insufficient permissions error.

Change-Id: I604883bc48dce3f326046d59534fb9134c1bbb29
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=876460
Signed-off-by: Ravi Nori <rnori at redhat.com>
---
M backend/manager/dbscripts/vds_groups_sp.sql
M backend/manager/dbscripts/vm_templates_sp.sql
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVdsGroupByNameQuery.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmTemplateQuery.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetVmTemplateParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsGroupDAO.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsGroupDAODbFacadeImpl.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsGroupDAOHibernateImpl.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmTemplateDAO.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmTemplateDAODbFacadeImpl.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VdsGroupDAOTest.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmsResource.java
13 files changed, 127 insertions(+), 7 deletions(-)

Approvals:
  Michael Pasternak: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/9248
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I604883bc48dce3f326046d59534fb9134c1bbb29
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <rnori at redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali at redhat.com>
Gerrit-Reviewer: Ravi Nori <rnori at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>



More information about the Engine-commits mailing list