Change in ovirt-engine[master]: userportal: NPE in OsTypeImage

tjelinek at redhat.com tjelinek at redhat.com
Wed Dec 19 09:52:10 UTC 2012


Tomas Jelinek has submitted this change and it was merged.

Change subject: userportal: NPE in OsTypeImage
......................................................................


userportal: NPE in OsTypeImage

The OsTypeImage creates the name of the default OS type
like: "otherOs" + nameUniquePart + IMAGE, where the IMAGE is "Image",
the nameUniquePart is "Large" or "Small".

Than takes this name and looks up the specific image from the
ApplicationResourcesWithLookup. The probelm was, that the otherOsSmallImage
was written with capital "O", which caused periodic NPE thrown on
FE.

Fixed by expecting the "OtherOs..." on OsTypeImage and adjusted also
other names in ApplicationResourcesWithLookup.

Change-Id: I2690cda0142f5c7849b3ad4bcc251906658244f1
Signed-off-by: Tomas Jelinek <tjelinek at redhat.com>
---
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/ApplicationResourcesWithLookup.java
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/widget/basic/OsTypeImage.java
2 files changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Tomas Jelinek: Verified; Looks good to me, approved
  Daniel Erez: Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/10209
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I2690cda0142f5c7849b3ad4bcc251906658244f1
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik at redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek at redhat.com>



More information about the Engine-commits mailing list