Change in ovirt-engine[master]: core: Add event for MAC pool initialization error

yzaslavs at redhat.com yzaslavs at redhat.com
Mon Dec 24 10:27:38 UTC 2012


Yair Zaslavsky has submitted this change and it was merged.

Change subject: core: Add event for MAC pool initialization error
......................................................................


core: Add event for MAC pool initialization error

This patch performs two issues:
a. Fixing inconsistency in handling MacPoolManager.freeMac
(in some cases - the exception is caught and ignored, in some cases -
not - this is behavior is incorrect).
b. Introducing event to mark failure in mac pool initialization (similar to the event log
of mac address already in use)

Bug-Url: https://bugzilla.redhat.com/885441
Change-Id: Ibaa3d9eb23016b4866e5cfa39f919378e09fdf2d
signed-off-by: Yair Zaslavsky <yzaslavs at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmInterfaceCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MacPoolManager.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java
M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
5 files changed, 16 insertions(+), 7 deletions(-)

Approvals:
  Yair Zaslavsky: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/10197
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ibaa3d9eb23016b4866e5cfa39f919378e09fdf2d
Gerrit-PatchSet: 13
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzaslavs at redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika at redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik at redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs at redhat.com>



More information about the Engine-commits mailing list