Change in ovirt-engine[master]: engine: Refactor CommonNetworkValidation

mkolesni at redhat.com mkolesni at redhat.com
Sun Dec 30 06:38:13 UTC 2012


Mike Kolesnik has submitted this change and it was merged.

Change subject: engine: Refactor CommonNetworkValidation
......................................................................


engine: Refactor CommonNetworkValidation

1. Moved to super class (since only used from inheriting classes of
NetworkCommon).
2. Changed to instance method, which allows:
2.1. Using DAO instance methods.
2.2. Using addCanDoActionMessage method.
3. Renamed method & variables to appropriate names.

Change-Id: Ie55a702efbeaaa852de93411fc5eaebc68ceefff
Signed-off-by: Mike Kolesnik <mkolesni at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/NetworkCommon.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/RemoveNetworkCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/UpdateNetworkCommand.java
3 files changed, 19 insertions(+), 24 deletions(-)

Approvals:
  Mike Kolesnik: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/10462
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie55a702efbeaaa852de93411fc5eaebc68ceefff
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Mike Kolesnik <mkolesni at redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer at redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Muli Salem <msalem at redhat.com>



More information about the Engine-commits mailing list