Change in ovirt-engine[master]: restapi: Vnic's network update when portMirroring is set beh...

alkaplan at redhat.com alkaplan at redhat.com
Sun Dec 30 12:45:23 UTC 2012


Alona Kaplan has submitted this change and it was merged.

Change subject: restapi: Vnic's network update when portMirroring is set behaves wrong
......................................................................


restapi: Vnic's network update when portMirroring is set behaves wrong

If port mirroring is set, the port mirroring network should be equal to
the vnic's network. Otherwise, an exception should be thrown.
There was a bug, the equlity was checked just if the port mirroring was
updated.
So, in case that the network was updated and the port mirroring wasn't-
an exception wasn't thrown although it should be.

Change-Id: Icbb346805f91bd3964550a19b18b3d0a0c40e12c
Signed-off-by: Alona Kaplan <alkaplan at redhat.com>
---
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmNicResource.java
1 file changed, 42 insertions(+), 17 deletions(-)

Approvals:
  Alona Kaplan: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/10441
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Icbb346805f91bd3964550a19b18b3d0a0c40e12c
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern at redhat.com>



More information about the Engine-commits mailing list