Change in ovirt-engine[master]: core, ui: VM, Template name - support Unicode characters

derez at redhat.com derez at redhat.com
Sun Dec 30 20:23:37 UTC 2012


Daniel Erez has submitted this change and it was merged.

Change subject: core,ui: VM,Template name - support Unicode characters
......................................................................


core,ui: VM,Template name - support Unicode characters

Adjusted VM/Template name validations to accept Unicode characters.

* VmStatic/VmTemplate/AddVmTemplateParameters:
  use ValidI18NName annotation for name field.
* ValidationUtils/I18NNameValidation: add '.' as valid character
  (to preserve current name validation which support '.').
* UnitVmModel: use I18NNameValidation for name validation.

Change-Id: I4105c327bdfce9587ae8ab2dcfc8180cf90cb4af
Signed-off-by: Daniel Erez <derez at redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddVmTemplateParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmStatic.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmTemplate.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/utils/ValidationUtils.java
M backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/utils/I18NRegexpTest.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/validation/I18NNameValidation.java
7 files changed, 16 insertions(+), 35 deletions(-)

Approvals:
  Daniel Erez: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/10473
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4105c327bdfce9587ae8ab2dcfc8180cf90cb4af
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel at redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>



More information about the Engine-commits mailing list