Change in ovirt-engine[master]: engine: Improve network queries by reducing joins

[masayag at redhat.com]

Moti Asayag has submitted this change and it was merged.

Change subject: engine: Improve network queries by reducing joins
......................................................................


engine: Improve network queries by reducing joins

By extending the vm_interface_view with additional two
columns (entity_type and vds_group_id) we reduce the need
for a join with vms/vm_static tables in procedures that need
to identify vm or template interfacess.

Modifying the queries revealed inaccurate tests related to
vm network interfaces, in which same network interface
entity was abused to represent both VM nic and Template nic.

Change-Id: I7e869dc9e583f1257652eb04d62bb10ae414eb48
Signed-off-by: Moti Asayag <masayag at redhat.com>
---
M backend/manager/dbscripts/create_views.sql
M backend/manager/dbscripts/network_sp.sql
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/FixturesTool.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmDeviceDAOTest.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmNetworkInterfaceDAOTest.java
M backend/manager/modules/dal/src/test/resources/fixtures.xml
6 files changed, 65 insertions(+), 26 deletions(-)

Approvals:
  Moti Asayag: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/10445
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I7e869dc9e583f1257652eb04d62bb10ae414eb48
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <masayag at redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer at redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni at redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag at redhat.com>