Change in ovirt-engine[master]: core: (Partially) Cleanup VmCommand

lhornyak at redhat.com lhornyak at redhat.com
Mon Jul 2 16:31:53 UTC 2012


Laszlo Hornyak has submitted this change and it was merged.

Change subject: core: (Partially) Cleanup VmCommand
......................................................................


core: (Partially) Cleanup VmCommand

Performed some general java cleanup in VmCommand:
1. Replaced singleton resource access (e.g. DbFacade.getInstance(),
   Backend.getInstance()) with protected access methods where possible.
2. Replace FQCNs with imports.
3. Replace depracated StringHelper with commons' StringUtils.
4. Document empty method.
5. Eclipse IDE formatting.

Change-Id: Ie933ed461ae9b74e10f7bfc45fb7d9416d4fc31b
Signed-off-by: Allon Mureinik <amureini at redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java
1 file changed, 33 insertions(+), 35 deletions(-)

Approvals:
  Laszlo Hornyak: Verified; Looks good to me, approved


--
To view, visit http://gerrit.ovirt.org/5828
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie933ed461ae9b74e10f7bfc45fb7d9416d4fc31b
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>



More information about the Engine-commits mailing list